From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.1308.1609872319341453014 for ; Tue, 05 Jan 2021 10:45:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=akMgm8nX; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609872318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vhxCUNszSBF6UvSUKBWboFzX16/wJRRMm+0RgFvpkfE=; b=akMgm8nXwo75x+hhYh2B/SDeKzT6U+XUnAIG9q3nvf6n9WG8HclZvRTGy4WKUVGwmq+fi1 cXdM1IgWMhwL6QCNN8bMSW5eDeJml5IOu8SWYbwqxQd5+h1clyevmi4Dzu6F7j6r8dvjgL tAASAmJRUIfvhg/jW4NwnJN9XMzyZp8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-1lU9kLSNN5WCWe8v9s7NWQ-1; Tue, 05 Jan 2021 13:45:17 -0500 X-MC-Unique: 1lU9kLSNN5WCWe8v9s7NWQ-1 Received: by mail-wr1-f71.google.com with SMTP id o17so207631wra.8 for ; Tue, 05 Jan 2021 10:45:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vhxCUNszSBF6UvSUKBWboFzX16/wJRRMm+0RgFvpkfE=; b=MmL8QutSpTrQ1F3vG/am4s4VSiEk+Dx0nLyShMJXxbRP0U+0vOhdkQwCq3B8E2pGP5 DsZc2DmioyoaQmIACDpy2S3zwbjZf17TnEG1M+uEQB9gmoqxShpbwBAoICck8Oml2DWt wRSwwjmyQ/Mlc/JQKvX6oBWfMXvK+DUC4sxKorNlv82EADqooII9myqANE7H+zbMBdgU Vo3uDXLo5x8jCxE9g9dChcXqxVIefaJdzdO3mqjdchgrGGRdcjpGCfUHo/r2l2YXj8nF J86z0BffjVzt5XcdhbfBLe4J5y4NkRbUA/lS5nMyWXer3Zx9aQFpj2UFonn2PzlbeCwZ 7S5w== X-Gm-Message-State: AOAM5326yGz6ekRrDgyKm3FfxVrfuV1Mv6DhB4DFplwnx474ZUM/CHbr 3B4NmncoEnHi/s/c57bH+G3lKqm55jjuWuTcbo+RwWySpJWAKSTVIxKnDGpoIN3VhlI/ONVoRoI vKVEttjGBL8NxMA== X-Received: by 2002:a05:600c:2219:: with SMTP id z25mr446419wml.27.1609872315068; Tue, 05 Jan 2021 10:45:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQfjBCy7He8skBQjvluVfLeJ9XL0gLgMaq+IXA4Q2E9nLkXm39++NCmc2SLrlcVSNhnMD+pg== X-Received: by 2002:a05:600c:2219:: with SMTP id z25mr446403wml.27.1609872314898; Tue, 05 Jan 2021 10:45:14 -0800 (PST) Return-Path: Received: from [192.168.1.36] (241.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.241]) by smtp.gmail.com with ESMTPSA id l20sm782489wrh.82.2021.01.05.10.45.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jan 2021 10:45:13 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v4 3/7] Platform/RaspberryPi: Split MMC register definitions To: devel@edk2.groups.io, jeremy.linton@arm.com Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, pete@akeo.ie, samer.el-haj-mahmoud@arm.com, awarkentin@vmware.com References: <20210105163420.1711652-1-jeremy.linton@arm.com> <20210105163420.1711652-4-jeremy.linton@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Tue, 5 Jan 2021 19:45:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210105163420.1711652-4-jeremy.linton@arm.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 1/5/21 5:34 PM, Jeremy Linton wrote: > The current MMC (really SDHCI) definitions are tied to the > Arasan controller. As we intend to reuse the definitions lets > make the base address configurable when the driver loads. > > This assumes we won't ever want to run both the eMMC2 > and Arasan SDHCI controller at the same time. > > Signed-off-by: Jeremy Linton > Reviewed-by: Andrei Warkentin > --- > .../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c | 9 ++++- > .../Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h | 42 ++++++++++++---------- > 2 files changed, 32 insertions(+), 19 deletions(-) > > diff --git a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c > index 88e9126e35..c8fdfc193b 100644 > --- a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c > +++ b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c > @@ -16,6 +16,7 @@ STATIC CARD_DETECT_STATE mCardDetectState = CardDetectRequired; > UINT32 LastExecutedCommand = (UINT32) -1; > > STATIC RASPBERRY_PI_FIRMWARE_PROTOCOL *mFwProtocol; > +STATIC UINTN MmcHsBase; I expect EDK2 style to ask for 'mMmcHsBase'. With it: Reviewed-by: Philippe Mathieu-Daude