From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.17082.1660664030348273471
 for <devel@edk2.groups.io>;
 Tue, 16 Aug 2022 08:33:50 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7CF4106F;
	Tue, 16 Aug 2022 08:33:50 -0700 (PDT)
Received: from [10.57.44.12] (unknown [10.57.44.12])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C49DA3F66F;
	Tue, 16 Aug 2022 08:33:48 -0700 (PDT)
Message-ID: <e1481015-a9e4-9dcc-a283-d57f5c65cc63@arm.com>
Date: Tue, 16 Aug 2022 17:33:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config
To: Kun Qin <kuqin12@gmail.com>, devel@edk2.groups.io
Cc: Sami Mujawar <Sami.Mujawar@arm.com>,
 Alexei Fedorov <Alexei.Fedorov@arm.com>, Joe Lopez <joelopez@microsoft.com>
References: <20220810222853.1916-1-kuqin12@gmail.com>
 <20220810222853.1916-7-kuqin12@gmail.com>
From: "PierreGondois" <pierre.gondois@arm.com>
In-Reply-To: <20220810222853.1916-7-kuqin12@gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hello Kun,

Is this patch still required ?
Cf: https://edk2.groups.io/g/devel/message/92204

The CM_ARM_PCI_CONFIG_SPACE_INFO struct should be enough to describe
the PCI ECAM, so CM_ARM_PCI_ADDRESS_MAP_INFO.SpaceCode being set to
PCI_SS_CONFIG should be an invalid case.
If not I don't think a v5 should be necessary.

Also I ran the patchset on KvmTool and everything was working.

Regards,
Pierre

On 8/11/22 00:28, Kun Qin wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
> 
> This change added a switch case handling for PCI_SS_CONFIG during SSDT
> generation. This will allow PCI config case return EFI_SUCCESS instead of
> EFI_INVALID_PARAMETER.
> 
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> 
> Co-authored-by: Joe Lopez <joelopez@microsoft.com>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
> 
> Notes:
>      v2:
>      - Added Reviewed-by tag [Pierre]
>      
>      v3:
>      - No change
>      
>      v4:
>      - Added Reviewed-by tag [Sami]
> 
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
> index dd75fc27e60e..c6fbd09c43f8 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
> @@ -606,6 +606,11 @@ GeneratePciCrs (
>                      );
>           break;
>   
> +      case PCI_SS_CONFIG:
> +        // Do nothing
> +        Status = EFI_SUCCESS;
> +        break;
> +
>         default:
>           Status = EFI_INVALID_PARAMETER;
>       } // switch