From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.4992.1622110883639238966 for ; Thu, 27 May 2021 03:21:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S5K9dW1u; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622110882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JWvJJbvA94mKaajesu+lQ0UruprRitBktgBg5VJH72I=; b=S5K9dW1uZHqi9T0YI4+QkwQeG4E2bbhsTjQjuZGRaCztRH0Na1WO9OTX1nqUOU0jABTGHK Q+3phdGPxNoi4IQwfMe79DrBPtK+pjkXVCqrF6oVB3PnoKJW5ybiq0BXKcx46DRWqizOeN yswqGUN7k7uSdy3NktCQ1R7Lv4WJCSg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-h1WZ6pDyM4Op2jn44iYLTw-1; Thu, 27 May 2021 06:21:21 -0400 X-MC-Unique: h1WZ6pDyM4Op2jn44iYLTw-1 Received: by mail-wm1-f70.google.com with SMTP id y65-20020a1ce1440000b0290195e7df1743so115207wmg.3 for ; Thu, 27 May 2021 03:21:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JWvJJbvA94mKaajesu+lQ0UruprRitBktgBg5VJH72I=; b=sZ1IFJqYER30QVAjGP6aFjTfsfByObGr50gL2RRsttojMi5O+8z2IFD+pZTzsFhCs3 VJHDOJAzhG6anZGBT10X2Rr3bqyeWh969iFrqdzHdi3Sg4ypZ4L5y+mpNAX7QXmeTAmc mvZOdeVYnd0f0oe5Znbwp3HQM8ad7CJM2sgRvyXhCBEVr8l2OCjvxAT3QRHetQdnb7OK ZmydDgFtAZ1Flq4PmgHywI0vGroVPgEW8bqnPN+C0AfTWZgrc6hwR4QR9R7YWpRIx9Gw KcB/EQC+uIimkrkQx4k8wpE6k3Vxst0HHigK2eKk8/ApncVy0jU3wJNQT9prRJP2NKyU JthQ== X-Gm-Message-State: AOAM532XbdDzci6At8d5WOLeAq5JA1K+CQAM1DTE3FeS5cxe2tZ2Bv/F a7HpKmMVrLUM1rbYxCo3ss3eomSu35nMZijeYfKHb4ZXy6ouA/ElDuSy+KPS0Uof9VDCSpC7Q1+ er2Ba18mfj3nYRg== X-Received: by 2002:a1c:9804:: with SMTP id a4mr2230418wme.34.1622110880067; Thu, 27 May 2021 03:21:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsexENZ1YG/KAnEpqKPFR+OMKYwSb3RuRD4w4LRZ98Wf6zHqFJdtlB/BjpKxer11O0gFR7YQ== X-Received: by 2002:a1c:9804:: with SMTP id a4mr2230396wme.34.1622110879863; Thu, 27 May 2021 03:21:19 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id s1sm2191389wre.67.2021.05.27.03.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 03:21:19 -0700 (PDT) Subject: Re: [PATCH 23/43] OvmfPkg: drop PcdPciDisableBusEnumeration from the AmdSev platform To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Jordan Justen , Min Xu , Tom Lendacky References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-24-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 12:21:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-24-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > With the Xen-dependent PcdSetBoolS() call removed from > OvmfPkg/PlatformPei, the "AmdSevX64.dsc" platform never writes > "PcdPciDisableBusEnumeration". This means we don't need a dynamic default > for the PCD in the DSC file; it could be declared Fixed-at-Build. > > However, because the PCD's default value in "MdeModulePkg.dec" is FALSE, > remove the (same-value) platform default altogether. > > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Min Xu > Cc: Philippe Mathieu-Daudé > Cc: Tom Lendacky > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daude