From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 01B082119A843 for ; Fri, 14 Dec 2018 11:57:28 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3ED0D3F73C; Fri, 14 Dec 2018 19:57:27 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-122-117.rdu2.redhat.com [10.10.122.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id C2E6E5D6B3; Fri, 14 Dec 2018 19:57:25 +0000 (UTC) To: Supreeth Venkatesh , Leif Lindholm , Andrew Fish , Michael D Kinney Cc: "edk2-devel@lists.01.org" , "Jin, Eric" References: <20181212033214.10456-1-eric.jin@intel.com> <31cc8b433744850df7d65f73d3f2a6aa7840e71b.camel@arm.com> <20181214105917.qaplwp3vtspieig7@bivouac.eciton.net> <359acbc9-1e0f-722d-0096-67d77ab3c6c0@redhat.com> From: Laszlo Ersek Message-ID: Date: Fri, 14 Dec 2018 20:57:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 14 Dec 2018 19:57:27 +0000 (UTC) Subject: Re: Line endings: Was "Re: [edk2-test][Patch] uefi-sct/SctPkg:Correct macro name style in HwErrRecVariable Test" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 19:57:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/14/18 18:12, Supreeth Venkatesh wrote: > On Fri, 2018-12-14 at 14:24 +0100, Laszlo Ersek wrote: >> On 12/14/18 11:59, Leif Lindholm wrote: >>> Hmm, this gets me thinking... >>> >>> We were discussing before about doing a line ending conversion in >>> edk2, and let the git gools provide native line endings (as >>> designed). >>> >>> Is this a good opportunity to run a pilot with edk2-test, where >>> much >>> less history will be lost? >> >> Well, history won't be lost, in the sense that people running "git >> blame" will need one more execution of "git blame" (to "look past" >> the >> whitespace change commit), but yes, it will result in a minor >> inconvenience. >> >> And, I think, converting the edk2-test repo would not be a bad test >> at all. >> > Thanks Leif/Laszlo. I volunteer to try the tool. However, I admit that > I have not tried this before, any pointers/instructions on how to do > this? I imagine you'd run a "find" command to locate all source/text files (skip ".git"), then feed them to xargs / dos2unix. The trick is more in the git settings, once the internal representation has been converted to LF only. I'm thinking that "core.whitespace", "am.keepcr" and "core.autocrlf" should be set the "right way". (= to be researched) Thanks Laszlo