From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.81]) by mx.groups.io with SMTP id smtpd.web10.5222.1688034826340213070 for ; Thu, 29 Jun 2023 03:33:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ShUVmxrg; spf=pass (domain: arm.com, ip: 40.107.20.81, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KyszVxlBViBtjwwU1KM3fMCYuH5PMJX8NmxMa2cdld8=; b=ShUVmxrgnc8yBsNFWA0UHcI0+KI3XX6djLdI24h3hD4YRKb9EWHLeuW3eFCt1Bfl2EQAF3KRK+UJ+2Vbh6HdpqH+RkKjr6KLARZZfoXsjTufpoFKsbvu0nIKaErjHuts8OaYIPpHDU98PiDu71Reo071+hC+Rt38Hp5aSJqw498= Received: from AM0PR01CA0087.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::28) by AM8PR08MB6514.eurprd08.prod.outlook.com (2603:10a6:20b:36b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Thu, 29 Jun 2023 10:33:39 +0000 Received: from AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:10e::4) by AM0PR01CA0087.outlook.office365.com (2603:10a6:208:10e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 10:33:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT012.mail.protection.outlook.com (100.127.141.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.20 via Frontend Transport; Thu, 29 Jun 2023 10:33:38 +0000 Received: ("Tessian outbound 7c913606c6e6:v142"); Thu, 29 Jun 2023 10:33:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7b19f31444abd389 X-CR-MTA-TID: 64aa7808 Received: from 6d4c3644b7a8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E0C81C54-0112-4034-B7B1-A0F075D91647.1; Thu, 29 Jun 2023 10:33:31 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6d4c3644b7a8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Jun 2023 10:33:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ExjZEqx86WAfEwhozzM9gH2rtazDblKwU04RsDRKdHCgkAuuroVoMa0b6BuuBHibvouNpXQeYPj8EaHDe6dNT8KYBBp072gyzyqRm6a4n8xap8nCyoH0oGh5Nc4tZwLv59cOmVw8ZhYnlMxmvnODk7wVDEOggt1+D7gey286TwM/RoAmmRDq9xCTSEz7VE0oJvGgyFxxxHXqW+K8EbN1Di/UhG5UVEh/PXhDORchGsWnTLOXbaIkTGNCH1DrguVEvxagYrZvnZ+YjJ22ghJNQ6AGGF36tw3zOI2m096smp5S2qCQ0bV64OhF8xJkSTQNekUaduzzcPCyimFypbCUmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KyszVxlBViBtjwwU1KM3fMCYuH5PMJX8NmxMa2cdld8=; b=FodEZelzkuPyTa45NruGTnFS+GQXwXgQb0/38xiYHLLoNdklLZauuU3TKSxEQpDbaWWZLTFZ5gUS0zI/eHNqrT5HNnDGHqAGJTvL3Pz7gB+4eSZFENqwS7t8MOc4xP5sm2y4x7enYTVBnTKh2tQYWKUwkHr9q3n8dosSNOFCDt2nus4zh8+ZoqEsezS93Q1kP+0MerWFyrjv5TcYwMlduNsVIr8o7w5YZpCAovs6Z4b4rEW4I2xUuj/stZuYuBbOGHJ5/hYY2BNj47egIqA8ZXYgycZziUn6WD3uWti8nz9qP1fDPV5mZYdtRRgdFC3UFtL57LDl3WRzyOAD0iIzhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KyszVxlBViBtjwwU1KM3fMCYuH5PMJX8NmxMa2cdld8=; b=ShUVmxrgnc8yBsNFWA0UHcI0+KI3XX6djLdI24h3hD4YRKb9EWHLeuW3eFCt1Bfl2EQAF3KRK+UJ+2Vbh6HdpqH+RkKjr6KLARZZfoXsjTufpoFKsbvu0nIKaErjHuts8OaYIPpHDU98PiDu71Reo071+hC+Rt38Hp5aSJqw498= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PA4PR08MB6240.eurprd08.prod.outlook.com (2603:10a6:102:ec::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Thu, 29 Jun 2023 10:33:29 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8ef4:aa57:6248:7850]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8ef4:aa57:6248:7850%4]) with mapi id 15.20.6544.019; Thu, 29 Jun 2023 10:33:29 +0000 Message-ID: Date: Thu, 29 Jun 2023 11:33:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 1/2] SecurityPkg: RngDxe: Unify handling of zero guid To: Kun Qin , devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Pierre Gondois , "nd@arm.com" References: <20230628203357.2001-1-kuqin12@gmail.com> <20230628203357.2001-2-kuqin12@gmail.com> From: "Sami Mujawar" In-Reply-To: <20230628203357.2001-2-kuqin12@gmail.com> X-ClientProxiedBy: LO4P123CA0563.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::11) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PA4PR08MB6240:EE_|AM7EUR03FT012:EE_|AM8PR08MB6514:EE_ X-MS-Office365-Filtering-Correlation-Id: d96729d7-eeeb-4a73-ac37-08db788c4d1e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8GPxYJ8djZGoMtDdXInBmFrpJ38oDlQ7qSBBlJP+5dXK+lbZjwCc1D9gV6DVhtMcGKrSgtTgW+2e1bEPMrBhj11gRozW3jiXgc2YWu/6FR5gUOH0TlhCtpv9k34fz+TgZ9E5DQ8XRt7mYqVnpF260KstL/PZ09j2sLOQ1Ae7T+9eDaOWQyY3IK9eY94EY/Lf7pvas61ZRCiQLnwClCLKcTMoVskH0Vgn4uJTr2aXXaAjlmTBiL7RtaZvafQeZCG3l4cASgOzvggv2P01etwNJJn2szEzpvH7LGcS5W5PSx/fyeXYTqbQ9lwT+Rx2cosKCkMso79EU67Fo579pjYZOPD9URKBf0MowDc4jJdAk1Cv4yTraAzEo4V9tFUphzYrjeOM59ZaBKqA9WN+DMh60EThug8/HG1tZhWDaHFvFg8I4p7AEX8X1zTptIdNEUuaNtcO07SCVOnMq4wvVok1DKLmLBGAlcvxzjGwYUZpl1IyzKxCkYsv3H7+PBXs0BAWpx4z/okHxVt3j2w+7JVWMbPmHqPik8zBFzGITHy1DeBSZkAvwS5KWi/997H60X5q7jxXfGXZCow5HPZ0hmX8rtbzM6mz0ARD9FwXaDalx0ugV+Yhi4d34BB5vlUmkgy50ndOEP/jvfnKURO1nVPQNMZnQbajZeAmV0tJQ2WmHzY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(366004)(346002)(136003)(451199021)(5660300002)(66476007)(26005)(2906002)(186003)(38100700002)(2616005)(6506007)(6512007)(8936002)(83380400001)(53546011)(41300700001)(44832011)(66946007)(66556008)(36756003)(6666004)(31696002)(6486002)(478600001)(966005)(86362001)(45080400002)(54906003)(8676002)(4326008)(316002)(15650500001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6240 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25114410-c22b-42ff-5418-08db788c475f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VZo9FrolSIj675anyFEfNBJo0t3TRgoWoPfG4fC2jA4Htb4LCmdaZPweTNQg5ZQbKqEpgYP14wuOXaq9RoSVSslloHZ79HOFVY2Si4CFa5LgdulCImzmFN7TYnpwNCLg2ldK3HYy8Q8MiGLvrHTmwlv2yKOcwBxsfonXRfDmXWIeZLehCD1I3b6xJ55DcUjqrTle7N7SsoaHxgS2JrgCZYmmWM5SH+Pzcd60ZixV/ZotHhSFr9PS/Qq3wnILkIwSCnp7XYOJsC2HbUXZ8LNUktFVuQSZd96p+5yLixB6ge8zymlEa1VAOdZaTNZm1FyN0mE4CUJ4uiWUIKUXlnozJRnYIF854ByLvNLvOTGwie7s1ZW0+2jJCrPsd6atPkZaBP6yElTGZRbm+Pq6pDf+yDSc1Pgj4i2rykPTtamIMVFJXNk+xWQRw03G92fmMfdc1SxSUgvVWjTEIoiZbZ4tQdQ/VyZUE0MZgbJX7wKpCvZ5PVdS7NwDvZh7ct0x6mZlmvEdSQxHJ5r3lW/7DJQa2sH+304mgP1XVVKWA4M+vy1VHTAsCgg+r+uaYS0fRcbLB+g4MSmPgABVLqfB/dtq4DTIgOmsvdnz2xhYtMvpZkBnb83Mi+fQP07RAwnnWhFnVIxzRJU+6T5Gnh6u+eIeUfR0HYC7FAtL7N+G8N9Efa2JHqohR2439MK02nKv51nbKUIShlMJ6ZFE4F8mz1f5BicZQYNd2TodBZTDrJ8eQT+NHUMxxmmrg66e7WeWTfdZ7+auFFPLtAV7cY4LdyYhsSYf14/p28/HqRM0VYw1qLQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(136003)(346002)(376002)(396003)(451199021)(40470700004)(36840700001)(46966006)(41300700001)(6512007)(966005)(40460700003)(6486002)(316002)(2906002)(5660300002)(53546011)(44832011)(6506007)(26005)(36756003)(8676002)(8936002)(186003)(15650500001)(82740400003)(81166007)(356005)(40480700001)(2616005)(36860700001)(336012)(54906003)(45080400002)(86362001)(31696002)(478600001)(47076005)(83380400001)(31686004)(4326008)(6666004)(82310400005)(70586007)(70206006)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 10:33:38.7042 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d96729d7-eeeb-4a73-ac37-08db788c4d1e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6514 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Kun, Can you look at Pierre's series and see if this issue is resolved, please? I have also made further suggestions at https://edk2.groups.io/g/devel/message/106511. Regards, Sami Mujawar On 28/06/2023 09:33 pm, Kun Qin wrote: > From: Kun Qin > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4491 > > The existing logic of initializing `mAvailableAlgoArrayCount` will treat > the zero GUID in `PcdCpuRngSupportedAlgorithm` as a legit case and > increment `mAvailableAlgoArrayCount`, causing the RNG protocol be > published. > > However, when the protocol is invoked, any zero GUID will be filtered > out, leaving a possible edge case where the protocol only has a zero GUID > based algorithm and being filtered out will always result in an ASSERT. > > This change marked the zero GUID as an issue and will not increment the > counter and thus avoid publishing the protocol completely. > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Sami Mujawar > Cc: Pierre Gondois > > Signed-off-by: Kun Qin > --- > SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/AArch64Algo.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/AArch64Algo.c b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/AArch64Algo.c > index e8be217f8a8c..de279cdadeea 100644 > --- a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/AArch64Algo.c > +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/AArch64Algo.c > @@ -47,15 +47,16 @@ GetAvailableAlgorithms ( > ); > > mAvailableAlgoArrayCount++; > > > > - DEBUG_CODE_BEGIN (); > > if (IsZeroGuid (PcdGetPtr (PcdCpuRngSupportedAlgorithm))) { > > + DEBUG_CODE_BEGIN (); > > DEBUG (( > > DEBUG_WARN, > > "PcdCpuRngSupportedAlgorithm should be a non-zero GUID\n" > > )); > > + > > + DEBUG_CODE_END (); > > + mAvailableAlgoArrayCount--; > > } > > - > > - DEBUG_CODE_END (); > > } > > > > // Raw algorithm (Trng) >