From: Paolo Bonzini <pbonzini@redhat.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] VfrCompile: fix invalid comparison between pointer and integer
Date: Wed, 15 Feb 2017 10:11:20 +0100 [thread overview]
Message-ID: <e1944b3b-b8e6-dc0f-c8ac-66af6f7a54ad@redhat.com> (raw)
In-Reply-To: <B9726D6DCCFB8B4CA276A9169B02216D51E1235B@SHSMSX103.ccr.corp.intel.com>
On 15/02/2017 09:46, Zhu, Yonghong wrote:
>
> "-s ''" is an error, current the error message is not same as no option, because the content after the " all be treated as -s 's input.
> May I know what's your comment on Nikolai SAOUKH's patch ?
>
> - if (mStringFileName == '\0' ) {
> + if (mStringFileName == NULL || *mStringFileName == '\0' ) {
If "-s ''" is an error, it should be pointless to check *mStringFileName.
Paolo
next prev parent reply other threads:[~2017-02-15 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 12:54 [PATCH] VfrCompile: fix invalid comparison between pointer and integer Paolo Bonzini
2017-02-13 13:55 ` Zhu, Yonghong
2017-02-13 14:18 ` Paolo Bonzini
2017-02-15 8:46 ` Zhu, Yonghong
2017-02-15 9:11 ` Paolo Bonzini [this message]
2017-02-16 9:03 ` Zhu, Yonghong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1944b3b-b8e6-dc0f-c8ac-66af6f7a54ad@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox