From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA1B281EDE for ; Wed, 15 Feb 2017 01:11:18 -0800 (PST) Received: by mail-wr0-x241.google.com with SMTP id i10so30431384wrb.0 for ; Wed, 15 Feb 2017 01:11:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=4HlZxdaxbmVA+026O+dQMZ786Mv1hNq+KFwvminIpLE=; b=l6x6tNrLwGDiwgxRDswEIoH+Lwo2YNK/WLNX3etajJTe88F5TsG3wJCwBHaHA+HJWE 016NvZR4Wz9NwmEUVmEwMJMaBYxvspYmY/+2JuqhbhuXpDvujoaNvjGhv3zI1OIelSw1 JpOPU+54HRQJOxHwRKjEofiu52pMJqQxY7lzWHv4ISm36UQeyzOf+wD8AbkGMwWEfT8E xD86TaJyLmdCCLabdixf4eHDbikojb2ksE2ar8wbIOJ4UIGWVXMvVe4qXTUVVQgs0Apq Or+7kP1yYUYFfDHjFLcRXCt1mOyjfq5lZLFgPc+Ww38QcNHFZz5HmAKcJNqO6J6qM3yH FWgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=4HlZxdaxbmVA+026O+dQMZ786Mv1hNq+KFwvminIpLE=; b=byhkYavKGAonuMrpjf9lOLA7qA5lTuufAPiExkICBCMCj7ZLLFUFrVqhg3H97bNax7 AkRcVkRHBZftd4yji+TsPL4FaS4Q0iFWXCYAHYXZOq2c5TvFLHyvncpQr5cItG4dS+He HtoSQNGdNn/JAA/7U+kSBOh6MDBR/gejvpd+cIdyJS1oYyjdrsni+ij25ZSCTVtTeq46 I1fUr5x+kSm02yPOwLY30/k9mKnazTt9qK3S77LS8Imz0EHDhGMgWZsn0vmK/inmzORx T+Cv7p7t0JB6QDdlwTvTiyzJ6X5pAdlHe4A++As2rFRYDsQ9Ue9tIaxHTI/CMzOE5XVa Q7KQ== X-Gm-Message-State: AMke39lxLhAYQR66T3f8L5pVxWYsACqUhnQdaBqt1j5H3z1y/aUbvvQMe8KLWLAlv66lHw== X-Received: by 10.223.179.78 with SMTP id k14mr7694318wrd.34.1487149877101; Wed, 15 Feb 2017 01:11:17 -0800 (PST) Received: from [192.168.10.165] (94-39-187-56.adsl-ull.clienti.tiscali.it. [94.39.187.56]) by smtp.googlemail.com with ESMTPSA id b8sm4066617wrb.17.2017.02.15.01.11.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Feb 2017 01:11:16 -0800 (PST) Sender: Paolo Bonzini To: "Zhu, Yonghong" , "edk2-devel@ml01.01.org" References: <20170213125400.27421-1-pbonzini@redhat.com> Cc: "Gao, Liming" From: Paolo Bonzini Message-ID: Date: Wed, 15 Feb 2017 10:11:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] VfrCompile: fix invalid comparison between pointer and integer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2017 09:11:19 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 15/02/2017 09:46, Zhu, Yonghong wrote: > > "-s ''" is an error, current the error message is not same as no option, because the content after the " all be treated as -s 's input. > May I know what's your comment on Nikolai SAOUKH's patch ? > > - if (mStringFileName == '\0' ) { > + if (mStringFileName == NULL || *mStringFileName == '\0' ) { If "-s ''" is an error, it should be pointless to check *mStringFileName. Paolo