From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web09.420.1631659041516556564 for ; Tue, 14 Sep 2021 15:37:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@ibm.com header.s=pp1 header.b=Sk34joyy; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: stefanb@linux.ibm.com) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 18EM0JsM016794; Tue, 14 Sep 2021 18:37:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=LaP3ntBCqHlxrvUbKrEhOiRk4wFHMjiXrGRQls8g2XU=; b=Sk34joyyo2t2zLMe6XNacn64UGdT20XozMebRMs3FY8QsuPYMPLjUnA68pmnJLcFU8JG szOksj+pIIUtnCZfeLN9ab7aUoKNiEefETR1xfLdHDc5FiK5JNAOxTkSQnqR6Fr1gRic L1Xbp8Aeo2wv3vAgBigtoFFXCmAKgxJ8uVkA8Gf+EkJv7+tPyN3F0mDWPXBlbgiFUKs9 PV0U9+UoW/NSJsbZE+RK2DJSJi9mbeipr89b/mGI3a7ecrvsTMM2v9tA18cXX7u/eYgQ YK3ymOBgyiXYEbo7sNCgYwDhdgn15SFzFGUkFAV2WDkyhysx9HVgvpeKwqli+ea+E650 0g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b345cgkfn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 18:37:20 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 18EMS9qw029319; Tue, 14 Sep 2021 18:37:19 -0400 Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com with ESMTP id 3b345cgkff-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 18:37:19 -0400 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18EMavfj006777; Tue, 14 Sep 2021 22:37:19 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma02dal.us.ibm.com with ESMTP id 3b0m3bcebv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Sep 2021 22:37:19 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18EMbHbs45482460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Sep 2021 22:37:18 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D32B7BE05A; Tue, 14 Sep 2021 22:37:17 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 71F4DBE058; Tue, 14 Sep 2021 22:37:17 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 14 Sep 2021 22:37:17 +0000 (GMT) Subject: Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: "mhaeuser@posteo.de" , "spbrogan@outlook.com" , "marcandre.lureau@redhat.com" , "kraxel@redhat.com" References: <20210914141818.2583900-1-stefanb@linux.ibm.com> From: "Stefan Berger" Message-ID: Date: Tue, 14 Sep 2021 18:37:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: aHJDbr5RAiGqnukKQBEaGMLsfm5gwUeD X-Proofpoint-GUID: _XPiR65CtnwVwYCu-iwn0FAocfXmiq7x X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 suspectscore=0 spamscore=0 mlxlogscore=686 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109140123 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0b-001b2d01.pphosted.com id 18EM0JsM016794 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/14/21 6:26 PM, Yao, Jiewen wrote: > Reviewed-by: Jiewen Yao > > I will wait for a week, to see if there is any feedback from AMD or Bhyve= reviewer. I can repost as v3 with your Reviewed-by's cc'ing them. =C2=A0=C2=A0=C2=A0 Stefan > > Thank you > Yao Jiewen > > >> -----Original Message----- >> From: Stefan Berger >> Sent: Tuesday, September 14, 2021 10:18 PM >> To: devel@edk2.groups.io >> Cc: mhaeuser@posteo.de; spbrogan@outlook.com; >> marcandre.lureau@redhat.com; kraxel@redhat.com; Yao, Jiewen >> ; Stefan Berger >> Subject: [PATCH v2 0/4] OvmfPkg: Disable the TPM 2 platform hierarchy >> >> This series of patches adds support for disabling the TPM 2 platform >> hierarchy to Ovmf. To be able to do this we have to handle TPM 2 >> physical presence interface (PPI) opcodes before the TPM 2 platform >> hierarchy is disabled otherwise TPM 2 commands that are sent due to the >> PPI opcodes may fail if the platform hierarchy is already disabled. >> Therefore, we need to invoke the handler function >> Tcg2PhysicalPresenceLibProcessRequest from within >> PlatformBootManagerBeforeConsole. Since handling of PPI opcodes may >> require >> interaction with the user, we also move PlatformInitializeConsole >> to before the handling of PPI codes so that the keyboard is available >> when needed. The PPI handling code will activate the default consoles >> only if it requires user interaction. >> >> Regards, >> Stefan >> >> v2: >> - 1/4: Added missing link library >> - 2/4: Modified other BdsPlatform.c files as well >> - Added Yao's comments to 1/2 and 2/2 >> >> Stefan Berger (4): >> OvmfPkg/TPM PPI: Connect default consoles for user interaction >> OvmfPkg: Handle TPM 2 physical presence opcodes much earlier >> OvmfPkg: Reference new Tcg2PlatformDxe in the build system for >> compilation >> OvmfPkg: Reference new Tcg2PlatformPei in the build system >> >> OvmfPkg/AmdSev/AmdSevX64.dsc | 8 ++++++++ >> OvmfPkg/AmdSev/AmdSevX64.fdf | 2 ++ >> .../PlatformBootManagerLib/BdsPlatform.c | 19 +++++++++++-------- >> .../PlatformBootManagerLibBhyve/BdsPlatform.c | 16 +++++++++------- >> .../PlatformBootManagerLibGrub/BdsPlatform.c | 16 +++++++++------- >> .../DxeTcg2PhysicalPresenceLib.c | 5 +++++ >> .../DxeTcg2PhysicalPresenceLib.inf | 1 + >> OvmfPkg/OvmfPkgIa32.dsc | 8 ++++++++ >> OvmfPkg/OvmfPkgIa32.fdf | 2 ++ >> OvmfPkg/OvmfPkgIa32X64.dsc | 8 ++++++++ >> OvmfPkg/OvmfPkgIa32X64.fdf | 2 ++ >> OvmfPkg/OvmfPkgX64.dsc | 8 ++++++++ >> OvmfPkg/OvmfPkgX64.fdf | 2 ++ >> 13 files changed, 75 insertions(+), 22 deletions(-) >> >> -- >> 2.31.1 > > >=20 > >