From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on061e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe44::61e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3933521B0386F for ; Wed, 24 May 2017 15:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5PjnFKA8I78fl7Anh5Qz7RDSF8ufRTETYtTLRPius8k=; b=UdtABeIqbpd8/VaCkRvoJH9T4YpfZLYO1tg9AU7TGVnUsPERiQAmTIuW/ouULlI9o9EtNbTRk9C2Oyx8MEwUSr4L6P2nka0+eLqQk/2Uqy9Kk+mPNHnvq6l9Oh7BFL51M4/F/5IEgLtEco+oEgjQm0fyQMf9Vm9tqun+NypuwxE= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from [10.236.136.62] (165.204.77.1) by SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Wed, 24 May 2017 22:12:35 +0000 CC: , , To: Laszlo Ersek , , References: <1495466592-21641-1-git-send-email-brijesh.singh@amd.com> <1495466592-21641-5-git-send-email-brijesh.singh@amd.com> <868ad318-c652-55c2-4b4c-eeeec2f826c6@redhat.com> From: Brijesh Singh Message-ID: Date: Wed, 24 May 2017 17:12:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <868ad318-c652-55c2-4b4c-eeeec2f826c6@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR08CA0091.namprd08.prod.outlook.com (10.172.143.157) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-MS-Office365-Filtering-Correlation-Id: 1dd9d6c6-91f7-423f-e948-08d4a2f1fbb4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 3:nCDg1ptg/XTj04P6jGz2jYCW3G1vIEPCJcqucuXzpGy6Mg+FTROUAoN2Yx2S5L/idZbtmgJ1xa2H7JYJcKmp5zBXfE1pS7jzNDHmYfXlU6LcesLoHQzhTph3OsYFfP6CnR0KJu8E7iuiXNYAN2hKYKGcKoeKK51iZoI3jRZZCBrRjZnM2lUnKGD6k5IBloY6R0txW+pkwr7GhwcKEBXvqmO0pOJ75WikoxpKK2e1GwHXTq6bVmrDAmFT4z2w9oNZkrKIFps1l3lHbtXVZn21sEJOLylIzteN0LCBFWplAchgo7jyUUK5VLmJCz8W0vlC9BO4x/2ZIeh44YnfE0Imc+vIytpJbm5LG2UidzmzFs8=; 25:RNxLA3U5pw8dBu1aqtL+Ah4pYhED1buuRxv2onzD2+ymTT9pFnk7nBl1N5+wqglDehYKEnLjRF3f3isJOT8OGrcYV6MFoAwy2M0LfXtfvLTwSkA2uynokMaCC8dtAUb2me6IRm9ew92iauR/Wx5j1dpfJHaxn858DwCMjoDGb3w5gqFW7OETwQZIIe0Vso5swjE3GhGjENx4ElztkAs0Bu345+CeLDid3nYDc0CRXVMnsMtYGeTDWa9dbgu187W/VQuZZiS9l4Na4kI94fXi8B7YXwRnehPX+ZTxIb2afOcrg3hvizfCXO3tKB565OecBWH77W4WD6bmHAeitInjiHXtd+KaZ+2awIIfDhkTJAtCIRc7+a9fhSGU48EaSIQxntLY/Yb6tzWIyexDYIRmyPKCov41YG8uyxUOZcgIkly+Koyz7cyW4tfYoX2Nho/JqgHKpov8vI0S00H5fO845E+aPvqH6wjH4cpmF59bEuQ= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 31:bZAW85g+Vfip2Wzcw0B4JIZ3UMzympM6TDJ54z9B5V/R4EG7pEsN2qnzriWVL24wKEGr60LFlCHXlU4b1QVyP1WcsBZHNJlQMhhHIz/1mrVookwxrHPvqxoHL4+gaGRepOihyKjOncVYh60qA84aolYjmJUN1DH05BsQ4oIpPsu+y4o4+Y385iIZYOYMtN4eMojOCDKXSPRhKEwLhoAN5BWQHuS2HLzsNCOUzu/MnX0=; 20:GlJ55KLXF9cFjlHW6f1I9cxggztbDRlIUHiIpuKojMg7t1/01+RT2/OnueIg0t+Av0NygwkyMaJ66y8kb8974ofzW/yTCdZSYpIezEHHnhXDsqLnuAR1nZClL1U6s1O240qw+HZOwgWtuNzRlAj82PFA+L4K5/MiMW1QBPnogmkAbtRc8vli0nOLr20IWk4uHp/3RSy64t8pjqDIxe6WFq5E40CY/Ito0IBXcZuo9eOWzaXl/+JbtwKCCLHQ40gpNo1OheXk7fqsJyJh1UzEUPneZKTsKPDiidlNrHDgWqeNs6mEviABW64SBD3m+rv6uyW3cZqyMkY7re/N+HNAjswtfPSl9e+a9+91ZKeZulmdSVhCLYW8s6E9s+FdulNBykV/8LyMj9ejvzoYGTqve7hciEQk2H4f4U6YqiV+SOUJvgKaYMn5TL9bom3Q6iccR2fDxSeTbEdA6wGytvnORr1wi++Nwa6kH9bkd4e/YoglOLwhgj+Zg6kFX9rS6IXY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148); SRVR:SN1PR12MB0158; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 4:CTreehowt2zBV4LpKw6jUiu9MUyy10wVBw8TowZ/flXtfTl7dPpAN1rCKAC3moNf3YT96thILE+98d1b46BPEI3qX3WbcKpoo5LdhbbzwhTGafvxlThqjIaOcYvhfemUrKex5iJlIUcNC3BLWVKDlzGw2dtnjd6PYffpuYT3GZKdN6uL2z2JL56PwB8gP/1TEC3xKgNyFhDCFDg8L0FXpYG37adzCoCzs5BHkgGKqTzsjnpCmA86XFwjnW6TwWvua5LZo4v/0II+j7nGr0VZdyW7J/C/WCmIxRHEwvjoYvH7iDS0RfFaHq0E6A63D25U1EU0ntme28oOzTBAe0s+7Tu5LQvT2uV6mZJab7lpUJIebDvMQXIuWbw52J03VHt9Oz2tU3YGkq9LCxto4BoWXcGe8gGCRADpJzrWh5/K2moLrhGzvy4wwbiJkTPYV9OmYiCSV1QG7T0Y4UOhaslxgbpv5YPvR2H7IqOxuY0QeE4MQchuBREyT2UDbZvWxeU3oCcNTZLyldIe2i55lBXlOHZmjT6ctaW/HnzVOOd1NbYV57vnDlviY7kFI5k1AsZBCa7UGvgiScZdTkMankXjCriJnlSWT9huAjhJl5cjwWknAM/T2v+JcAVhsoguhxwCmpPzUbK4wKf92J+86A8aYdU4jqE88sbc0tzz7s7O4x8YPgXM4NyZwzDf+2Du/XdjKWKQCLtaCTBxsEWx863BXTZo9VnqgIkc4YH5IJyhUykQQNNcFkNsQJyQ6PZDow4x2rKPp1g9zRdvsmkYUuwPGnqKJx/R2pOWIfbW4HuNutg= X-Forefront-PRVS: 031763BCAF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6049001)(39450400003)(39410400002)(39850400002)(39860400002)(39840400002)(39400400002)(24454002)(377454003)(6666003)(2950100002)(38730400002)(23676002)(76176999)(54356999)(8676002)(53936002)(81166006)(4001350100001)(6246003)(25786009)(50986999)(230700001)(5660300001)(54906002)(189998001)(36756003)(53546009)(478600001)(305945005)(33646002)(50466002)(90366009)(6486002)(86362001)(47776003)(77096006)(2906002)(7736002)(31686004)(42186005)(83506001)(31696002)(229853002)(6116002)(3846002)(65956001)(65806001)(2201001)(66066001)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0158; H:[10.236.136.62]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOmgrTGg5S2FmUXh0akFIN0ZpTEtmVUtuaS9v?= =?utf-8?B?eFNqdXpuaC8zUE95SU9jNldSd1hWeGo2bHRrZHFGaFNCOG9KUXhpMjU3RjR4?= =?utf-8?B?aVliM3ZJenZZbnNGWDc0SXkxb1RjbUMzMVpOdWQrd0t5TVNudHVsSXhuT1h5?= =?utf-8?B?Z1lRMUFiOXdCTUNRd1dqTnVzenB0a1hvTVk0UVo5UVJVelkwUU04RlRvcmRU?= =?utf-8?B?enFVeG0rSGNvV0R6YnBSazNEakdVNTNpTkxmNVlvSXlYdUljeFg3ZVdpbDJ2?= =?utf-8?B?MFJwdjJwZWkzSW1MNTVEQzZBeUZSS0FTUzJZVGZRdlptZWdNS2wwSzQrU1JS?= =?utf-8?B?bzBqdnVHMFZPYjlvWjJXYUk3QWpyL3RyY0lhV3I1UThJb1hpbGRDc3RmZENG?= =?utf-8?B?V0hMUjh0ZVpYQlMxdmFoSXBrTlVwKzJHSVp2TjFIT0ExQ1lER2RzZ0JKamtM?= =?utf-8?B?TGJKMjExZFJJRVlSZEo2QXQ0Yld1djdBSHNYbk8vWEhPVzJTV0RpRms2VmZ2?= =?utf-8?B?L0J0RlRrK0xmTDNJa3hkSXpGV0R5eExlRUUyOVZvUFlvZlhxWXowSHZicFpq?= =?utf-8?B?R3VDTUF0QUwyZ0duQmhLZURpMkE0NXdoNzBacjhKS1lSUUhsUmhjQnhraXZF?= =?utf-8?B?UndtMW1PRDJlaTQybHA4L2lkUGNEeVBLRkVHS2pxbi9qWXU0T2l0QWwyRHpK?= =?utf-8?B?MzM3dFhNb0R4WnY1Vm1DdmQ3OElLYXZIWjVpeEJMTlJHeTdCaFVrb2hmZWlo?= =?utf-8?B?c3Y1bTBtQ2tQWnorcUFXQnFRRmliUndkaGlsVG1idTdSRmNPMTdkd0hPS1Ny?= =?utf-8?B?TGpJYXJLNEpFZllNQ0RFTHdMck9KWVg5VU9nTlFaOGFma01LVDZKRW9PSzMx?= =?utf-8?B?SnBJNmZJbVJyczVoUUR6SDlHV0JuQWtZemtmZW84bHh3bnNoTG1Lc1ZxVkJH?= =?utf-8?B?dWxWc2hYSGZmamx0VnViWTArWnhyZU1ManZIVnVOeVl4N3luQUxERkFPZ3Y1?= =?utf-8?B?Tm5WekZrZjhHS2VnTjB2V2FUZHB4NURTNUZwQ2FGUDhjdWNuQSt1WUpqbFE1?= =?utf-8?B?QkV5VndGU1FsWnd2Ym1NSU4xZnVReXVHMWw2U2hnSFN4OHpXVTZIRTNrUk0w?= =?utf-8?B?K2ZLQXoxSmNQWGprNXBuQVd0bCtNTFFzZGlKR1ROYjl3YUlXbFg4Qm44SmZ2?= =?utf-8?B?Ulh3V1FtWWNjMWpxU1JMRHZNWXl5dGxHRUFFRzlCcjNPaDBEWThCaktQbG9J?= =?utf-8?B?eVFQTHU3NnNWYmUrM2NwM0hNTXMvZkUzNTVHTnB3NTBFVGxaTXFybDhOWnNM?= =?utf-8?B?TGpjeVEwSHRzZTFubGhub3hNUDQzM2lISnRvdXg5amg2UlhjV2VETjE2enNJ?= =?utf-8?B?V3dOVGJHWHdKUSs1TTFqN1kvR1B5MUk0Uml3bE5jZG5rS1FCT3hBcmpISGli?= =?utf-8?B?dEVKY1lXTDNENnRwOFRTQ2VSRko2MTZUd21KUzdoWTZRV3U1UEtTalhOdkcw?= =?utf-8?B?UlFValBzK3BJUUd0b2trVk9abEJwMlJDZnZtbUVWY0VDbFNIYm5Qb21pK0hD?= =?utf-8?B?eVFIbWxIUlhmalpNQ0V3SHBmMlFJeWVEYmdQMUNNM0dwUndFN25kbll1aGlW?= =?utf-8?B?aUJITy9KNEVuWXVNbGFseDVnNnJ6bG5SckdBZXI5aXBFcG9Zck96c1p4Q0RX?= =?utf-8?B?MEhRQ3JXS1FBVXJuMlhKUFM5WTVFWVpnT0xVWkNpSXNhV1d3TG5JbE1LVU1T?= =?utf-8?Q?3sEVwGftlyJznY30q7f7jr3hSxeKb/K3W8Mxc=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 6:kvqaufRBwjdiuumy3MUFtyAN2WarediEJDJZm1Ck+2UnmWbaAh0LULn5MFNhQdg2/yLxOaSjgOh9SEN2NhRuqI0ey6wahiwbo1EVjUDStIs6txTG15V+pQcuoFDORQCS2vMfQNvz/+a6H4kvIIOL/xT1WKJrpc9uwoM+Per8wHI1J8p3K4Y6uWx2YW62c1huwJtCAulnASV9N74pBIHx087+UO0oJtVtZxH82+flXGC5niYQj6OqsCozIiLKSGIWv+G12e5Ov0DiuQTWRjiryu4MmkbhYmsYUQx+h11ezPT6eFDCLnUbNtYGvdPTnNn76Tg/nZcp5ewFLbjWApvBmMhl1LcO1KJh3+oSOu/LvylhYY68PqpPqhBaCPv03UJ/bLZPSXxYTcI/cvgzyC4lDR0eTTibCEzWIKqzR2k1ri2IDEsQla4UmHbXOePBGYNUVWVTIJsppQiebKQOLkBeG9VByLA/Wwyoh9yV8rw9iim4nmL6/bKALlroVw1HMzULsFXf8brmSn7QxGTIkIbCNZ7ljS5lHVGaeNgAXJVEnIg=; 5:uuHjfMHbwsxEsWaxtab0aHuKLKWQ5LWGs9cxx8uHWT5O0er9PjTJoZSCYLqT+qKdGfc3pBueY4Ku5Q3QI3PEKWtWsUshkIosUwWmS+xeEipr9g+JN0S7RiaeSjSW+TFWD75R8Syf/cUBRsDWqpaLzg==; 24:nkHyz1Hn261w9DVnJ+E7Ic8r174DQFxppLM6kQiZSYA8cXE2Ir82gck/XK+VQZj5M6d4s83vBR/TJnTw5N4hINmncPh0Zgh/EOCCFDeiNKU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0158; 7:7ZVXabVk6mMoY+iTpmTgKKgVhSSfbyZr7UXisBZirPE5wDLw5/dKcswkgnZH6oNomFXhpLHmUYHNi6I+6sRS4eb3C8h9vGPBD8LUvc7+IG7bv99EjNVxxXHmdyTRDIm5JIMFszr89IuBSznBgeeUrqHer6Vu8nU6o1k/oqgM2WxHflKZF43C8TiGTiCb9ci7nXjN/0p+ZQrk2PCzGDz1vWrm+4Gb4lGSahOGBJKnB1ies2FAp29nQqmx+4lqPZpAltNrW6gdjttnS/u6bLI4cnWmyPI5gDC3ZBVzWhc+nvVTdOhHvX2BVUgnpKUN75RlXRtZSBCZDGKMLj9W9BeaDg==; 20:rhOC7SjSVzq/mdjSK6rENZugbNvCF00dwCtrn8B6G2S+NbotCP0UDdYOY4yXDjHv0ak6GH3csrHLHhCTkzsZbn/QloaCo2eDCl0E5whRKN91aTBE0KU4hDJkA48NpuDHBGBFnzYUt+xVCKGSXcKysnarwbvBENGLL5bxgl4wJzCJzf3m8SQAATu5jK9oFZsXz5biGLeN4axqoI7oqKeaSsFlavUx0qWCpq2qv6z7L2EWSrqbs+UQZyDQU6HgLQHe X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2017 22:12:35.3275 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Subject: Re: [PATCH v5 04/14] OvmfPkg/BaseMemcryptSevLib: Add SEV helper library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 22:12:38 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Laszlo, On 05/24/2017 08:06 AM, Laszlo Ersek wrote: > > (2) please check the lines where you added (as I asked, thanks) > gEfiCallerBaseName and __FUNCTION__. On most lines, the indentation is > incorrect, relative to "DEBUG ((". Just so I get it right this time, can you please confirm that below indentation is correct: DEBUG ((DEBUG_VERBOSE, "%a:%a Set C-bit Cr3 %Lx Base %Lx Length %Lx flush %d\n", gEfiCallerBaseName, __FUNCTION__, Cr3BaseAddress, PhysicalAddress, Length, Flush)); I was trying to look into other files and some have different style, and checkpatch didn't complain the formatting error hence I thought what I had was correct. -Brijesh