From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Fri, 19 Jul 2019 05:46:01 -0700
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 27E0F3082E0F;
	Fri, 19 Jul 2019 12:46:01 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-195.ams2.redhat.com [10.36.116.195])
	by smtp.corp.redhat.com (Postfix) with ESMTP id F181B5D719;
	Fri, 19 Jul 2019 12:45:59 +0000 (UTC)
Subject: Re: [Patch 0/5] UefiCpuPkg: Enable Edkii Mp Services2 Ppi.
To: Eric Dong <eric.dong@intel.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Chandana Kumar <chandana.c.kumar@intel.com>,
 Star Zeng <star.zeng@intel.com>
References: <20190719072811.6352-1-eric.dong@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <e1aef2ba-8e48-47bb-72a8-5b505775068f@redhat.com>
Date: Fri, 19 Jul 2019 14:45:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190719072811.6352-1-eric.dong@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Fri, 19 Jul 2019 12:46:01 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/19/19 09:28, Eric Dong wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1973
> 
> CpuFeatures solution introduces a policy which write msr bases
> on scope info. With this policy enabled, for the msr which is
> package scope, CpuFeature PEIM driver boots hang.
> The reason for this failure is current CPU MP Ppi not supports
> start bsp and AP at the same time.
> 
> This patch serial introduce new API named StartupAllCPUs. And
> it add new ppi namded Edkii Mp Services2 Ppi, include EFI MP
> Serivces PPI and this new API.
> 
> With this new PPi, CPU features PEI solution can start all CPUs
> at the same time.
> 
> Because this patch only add one new API, i did belew tests:
> 1. Test StartupAllCpus with timeout == 0 pass.
> 2. Test StartupAllCpus with timeout != 0 pass.

I'd like to regression test patches 1 through 4.

It seems like Ray requested code updates for patch #2 and #4. Thus I
prefer to regression test v2, with those requests addressed.

Thanks
Laszlo