Re: [PATCH 57/79] OvmfPkg/Csm: Fix various typos

["David Woodhouse" <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 2806 bytes --]

On Tue, 2019-12-03 at 21:50 +0100, Laszlo Ersek wrote:
> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
> > From: Antoine Coeur <coeur@gmx.fr>
> > 
> > Fix various typos in documentation, comments and strings.
> > 
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> > ---
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf           |  2 +-
> >   OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h                          | 10 +++++-----
> >   OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h                 |  8 ++++----
> >   OvmfPkg/Csm/Include/Framework/BootScript.h                          |  2 +-
> >   OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h |  2 +-
> >   OvmfPkg/Csm/Include/Protocol/IsaIo.h                                |  2 +-
> >   OvmfPkg/Csm/Include/Protocol/LegacyBios.h                           |  6 +++---
> >   OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h                   |  4 ++--
> >   OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h                          |  2 +-
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h                     |  8 ++++----
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h                |  4 ++--
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h             |  2 +-
> >   OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c                          |  4 ++--
> >   OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c                          |  6 +++---
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c                              |  6 +++---
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c                       |  4 ++--
> >   OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c                               |  8 ++++----
> >   OvmfPkg/Csm/LegacyBiosDxe/Thunk.c                                   |  4 ++--
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c                | 14 +++++++-------
> >   OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c                         | 18 +++++++++---------
> >   OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni           |  8 ++++----
> >   21 files changed, 62 insertions(+), 62 deletions(-)
> 
> CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based
> on "Maintainers.txt".
> 
> Conditional on David's R-b, you can add:
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>

Looks sane to me, except there's one line in which you make a
correction but still leave BIOS spelled in lower case as 'bios'.
Shouldn't that have capitals?

Reviewed-by: David Woodhouse <dwmw2@infradead.org>


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]