From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: <devel@edk2.groups.io>, <sahil@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID
Date: Mon, 28 Nov 2022 12:33:15 +0000 [thread overview]
Message-ID: <e1d45586-e36e-dee2-1b3c-7d37cc8f7a8d@quicinc.com> (raw)
In-Reply-To: <20221124155528.355076-1-sahil@arm.com>
Hi Sahil,
Please split the license update out into a separate patch.
/
Leif
On 2022-11-24 15:55, sahil@arm.com wrote:
> There is no need for a separate ID for CCIX host bridge,
> therefore reusing PCIe PNP ID for CCIX.
> Also, updating the file's license to resolve error during
> ECC checks.
>
> Signed-off-by: sahil <sahil@arm.com>
> ---
> Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
> index 1f38f654a8ce..4c1acf154ca0 100644
> --- a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
> +++ b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c
> @@ -1,10 +1,11 @@
> /** @file
>
> -* PCI Host Bridge Library instance for ARM Neoverse N1 platform
>
> -*
>
> -* Copyright (c) 2019 - 2022, ARM Limited. All rights reserved.<BR>
>
> -*
>
> -* SPDX-License-Identifier: BSD-2-Clause-Patent
>
> -*
>
> +
>
> + PCI Host Bridge Library instance for ARM Neoverse N1 platform
>
> +
>
> + Copyright (c) 2019 - 2022, ARM Limited. All rights reserved.<BR>
>
> +
>
> + SPDX-License-Identifier: BSD-2-Clause-Patent
>
> +
>
> **/
>
>
>
> #include <PiDxe.h>
>
> @@ -65,8 +66,8 @@ STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRootBridgeDevicePath[ROOT_COMPLEX_
> (UINT8)(sizeof (ACPI_HID_DEVICE_PATH) >> 8)
>
> }
>
> },
>
> - EISA_PNP_ID(0x0A09), // CCIX
>
> - 0
>
> + EISA_PNP_ID(0x0A08), // CCIX
>
> + 1
>
> },
>
> {
>
> END_DEVICE_PATH_TYPE,
>
prev parent reply other threads:[~2022-11-28 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 15:55 [edk2-platforms][PATCH V1 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID sahil
2022-11-28 12:33 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1d45586-e36e-dee2-1b3c-7d37cc8f7a8d@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox