From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.116500.1669638803105449719 for ; Mon, 28 Nov 2022 04:33:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=PbhwBvlj; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ASBxYMu031646; Mon, 28 Nov 2022 12:33:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=jxBNyN5iLyZB4ZzOHZssGOl67Sxnqa19nUo0oZeWiuU=; b=PbhwBvljLu49tF7lNrABq67vS1DoWCcbiPvG/gdhn2SUxS2DosVsDM2Cig/TT8rfjfAG f9SAqORmAwZsZw/lgyeBanQazKeGbeMfKIWnnvRuz6Q+YioyeJLmljboQOh9q1qzwfOJ Gxv5C1Dh8iz2wHhBb0n7ouCzWPnZe9/tLPl6yEAFY4k5lYEbIZkjahaTKQ8f/wWqJRzK iX95XgdrDIaa/NhnAbNxAWuIN0a9Hl32c2XIa2Rl6V1HcLsMH08sjs6IPBVLe4AcrDcA bgw/36MF8OB+hocjPj5ZA5H+HXxnSQXP6T8BalULj+3pOeNy3XgEUMyfERAjG4+T7A6M tQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m38gq4hbb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 12:33:19 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ASCXI00003371 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 12:33:18 GMT Received: from [10.251.40.198] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 28 Nov 2022 04:33:17 -0800 Message-ID: Date: Mon, 28 Nov 2022 12:33:15 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID To: , CC: Ard Biesheuvel , Sami Mujawar References: <20221124155528.355076-1-sahil@arm.com> From: "Leif Lindholm" In-Reply-To: <20221124155528.355076-1-sahil@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 8yXgOqYy8OYISZTHxFydz3WayaiNiCED X-Proofpoint-ORIG-GUID: 8yXgOqYy8OYISZTHxFydz3WayaiNiCED X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_10,2022-11-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1011 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 spamscore=0 mlxlogscore=963 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280096 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Hi Sahil, Please split the license update out into a separate patch. / Leif On 2022-11-24 15:55, sahil@arm.com wrote: > There is no need for a separate ID for CCIX host bridge, > therefore reusing PCIe PNP ID for CCIX. > Also, updating the file's license to resolve error during > ECC checks. > > Signed-off-by: sahil > --- > Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c > index 1f38f654a8ce..4c1acf154ca0 100644 > --- a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c > +++ b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c > @@ -1,10 +1,11 @@ > /** @file > > -* PCI Host Bridge Library instance for ARM Neoverse N1 platform > > -* > > -* Copyright (c) 2019 - 2022, ARM Limited. All rights reserved.
> > -* > > -* SPDX-License-Identifier: BSD-2-Clause-Patent > > -* > > + > > + PCI Host Bridge Library instance for ARM Neoverse N1 platform > > + > > + Copyright (c) 2019 - 2022, ARM Limited. All rights reserved.
> > + > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > **/ > > > > #include > > @@ -65,8 +66,8 @@ STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRootBridgeDevicePath[ROOT_COMPLEX_ > (UINT8)(sizeof (ACPI_HID_DEVICE_PATH) >> 8) > > } > > }, > > - EISA_PNP_ID(0x0A09), // CCIX > > - 0 > > + EISA_PNP_ID(0x0A08), // CCIX > > + 1 > > }, > > { > > END_DEVICE_PATH_TYPE, >