From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.615.1587141486435796648 for ; Fri, 17 Apr 2020 09:38:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dIpuyrMb; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587141485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sWGU8jibzOTELGeT3HZzg7rBJ6Od1GjPm/1Rrn5Ax5o=; b=dIpuyrMb+BLI62ktsh4kURLQeWt9b3xw3iz8qSO3+E7cRxVW1CWC3s3BnB7RAJhsoF+Ng9 25LNx3R4AXIlP6vwv0D0g+Nm2yiEcfZ3sQMBHbB81Dtyq2tgMwACLMBVf2dasi5B1NDNgO Lv/YWqp+SWFzSNrEF+PMGh9LZAuZX7w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-83-oMHKPU2NMz2i2BxwMI-pkg-1; Fri, 17 Apr 2020 12:38:00 -0400 X-MC-Unique: oMHKPU2NMz2i2BxwMI-pkg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A567A800D53; Fri, 17 Apr 2020 16:37:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-253.ams2.redhat.com [10.36.113.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9268760BFB; Fri, 17 Apr 2020 16:37:58 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 04/13] OvmfPkg: Add QemuFwCfgS3LibNull To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel References: <1e62907d1bae3e60ebe2be8dd23f07dd65cb9049.1586991816.git.rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 17 Apr 2020 18:37:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1e62907d1bae3e60ebe2be8dd23f07dd65cb9049.1586991816.git.rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hi, On 04/16/20 01:09, Rebecca Cran wrote: > Add a null implementation library fof QemuFwCfgS3Lib, to support bhyve. > > Signed-off-by: Rebecca Cran > --- > .../DxeQemuFwCfgS3LibFwCfgNull.inf | 32 ++ > .../QemuFwCfgS3LibNull/QemuFwCfgS3DxeNull.c | 307 ++++++++++++++++++ > .../QemuFwCfgS3PeiDxeNull.c | 31 ++ > 3 files changed, 370 insertions(+) > create mode 100644 OvmfPkg/Library/QemuFwCfgS3LibNull/DxeQemuFwCfgS3LibFwCfgNull.inf > create mode 100644 OvmfPkg/Library/QemuFwCfgS3LibNull/QemuFwCfgS3DxeNull.c > create mode 100644 OvmfPkg/Library/QemuFwCfgS3LibNull/QemuFwCfgS3PeiDxeNull.c I'm extremely sorry if I gave you bad advice on this. We already have a Null instance of this library; it should be ready for use in BhyvePkg. The ArmVirtQemu and ArmVirtQemuKernel platforms in ArmVirtPkg already consume it. The INF file is located at: OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf Thanks (and sorry again if I wasted your time!) Laszlo