From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.65]) by mx.groups.io with SMTP id smtpd.web10.1728.1635445743109103960 for ; Thu, 28 Oct 2021 11:29:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=iFtG6Mw7; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.65, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUeLDglOZVUnK+UZ3NkwoAlnoxD7q9Q6/WtA7Mrlhe6GxhvTwTilJU+KJpSXz/E8qi8B/NXvea0c9jmV5+fo7ITzZEpQPqT5xRTiC/mMDNqvo25nywgGFK8UORSUJgaXWZXGBykoikvTaKju5dFEPKuoFSUrkleArwshohArXDCD4xhtO7pWmijZn4VmPFKQlmFOoittITdjR/EPmERRDKKwBG4R/RLforX+KoGDb7USGeA3T6l5q9Ym9LAa1o6nKaDR2ZNLrLCs0rS5M3YtTt/1YdtGe7FRVQgrJr++mT2o48qx27+RjKngL4TwuZsX1YMed9C7PfQpE58mz0bAeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FDpoI7pcs0gEmh0Qbsg1J/lwIm94IeqCU5Mp7AM/99A=; b=A7bHDgl5k4gAmLmw4bRb6h5y1W6mXF5x0qj0QZ7eYKRm+VCw3+EjDDzOksvvuvkdY0K4ul4f1BIGYVioqY803BBvg6j2ibjLq94VQi6J0Ouv/sDjGVFxdt3VrmMdR8NXKrIET3fi5SeqYogttsXhQNvAXuQ7g/WZXaesuLv9XxojrTM9tuUjV/vBdo6Rm0VuQ27nqhRNVrWk2hilUn57ikK2MGoce7Vst5bZ9V2fFstThC/G0k27UqKQPtmy7El/ue68ztfkjwsOl2gScgMhbFs/z3Rzj7jly+rqB2VKLPM5BT0PrNAj1uwKa/5pvYuneAYvuHdiXUEy4UqnIp1GSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FDpoI7pcs0gEmh0Qbsg1J/lwIm94IeqCU5Mp7AM/99A=; b=iFtG6Mw7NdtenHKIDNhLmLdoKVED4vcDaxPzibTSZDCY/6lQk5Jh+px7Uo5RzZZiUqTWoza/TfO1rDNkBfa02VOdpAdnZ9wOH1oExYMTdOZ9Wtk9W0Cfaj5So82u88Gz2L8QN1NFln0O2740xL3YxQN5djBBtEFfZhIFaK0F3kc= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DM4PR12MB5134.namprd12.prod.outlook.com (2603:10b6:5:391::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct 2021 18:29:00 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::a87d:568d:994f:c5f9]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::a87d:568d:994f:c5f9%8]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021 18:29:00 +0000 Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception To: "Yao, Jiewen" , Brijesh Singh , "kraxel@redhat.com" , "Xu, Min M" Cc: "devel@edk2.groups.io" , Erdem Aktas , James Bottomley , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul1" References: <24d3a351f21bff1a4b20490313d039e403b1453c.1633401643.git.min.m.xu@intel.com> <20211012102716.wr6bao42f5hviz5z@sirius.home.kraxel.org> <20211026061148.omqerrswnpgs3jin@sirius.home.kraxel.org> <20211026102458.pvzp5nxyegq7ftuu@sirius.home.kraxel.org> <20211027071935.a4l3aiiu6uaaqdvl@sirius.home.kraxel.org> From: "Lendacky, Thomas" Message-ID: Date: Thu, 28 Oct 2021 13:28:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-ClientProxiedBy: SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 Received: from office-ryzen.texastahm.com (67.79.209.213) by SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14 via Frontend Transport; Thu, 28 Oct 2021 18:28:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a3e315a7-2c85-4c44-2df2-08d99a40cfbd X-MS-TrafficTypeDiagnostic: DM4PR12MB5134: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 82NlRs09LFj0szMjDPwKgfZgypfROy0PXDPRhx/kD0E+C8dNXDGZ+uNiy8zDzToQdjjuV+HXn0eR9LlpqgrA7MXR8OGMsUlQwSj60BGC9qJmzu1pYIgv7AodvNNN0oyzESNs2jd+yCtzrWgw1xX1Utgx17G+ioxMDdT6eYj4QSjBaiLPO+u/hnELH8PJ0TRT5cEjseYSM7A9qMDccf838J+jD9GG7lQAgZKrcoZoCMSXflPJzxGv0okflh3WnoKUxgaFgnCW47SSLSI3qs1ukM8TVujnG6ZJhDTmzSpu9iUSYqtVoDK3fMOOxUQLuHSFs7FTPGwQNVqOu9wmZ3CSG/vENxxRIP2gHOUV5i8Kvhof7q2BRDxqDazfnFYeUB8rP1IU2CHu9dJptoNXJsni0t8iO18ZJCYiiD81RY55QeRGL+Lbs7wGuoXUYo+lIDtBLoPcClXCWyAnFjJbjlVrzeVnD59OzK6jvLoR8RfugOXowfGpjs/qW6JOxocfBhlunP5/xpKG0GwF8GwXv7KhNbIaJV2l5BW1clc7NyvptbZt/fi7+r2fBrGSQenPfVpnZEZUjQpjQCcFitFtFcWZGQv3lPMbY5iCgc+r/q9lp/gT6AcpPcJPEY6siC77e7u2F+X1JmylFp8uWSnHiLVdkCSmeeWOPdFK5KOH5rohG0bA+0eJEYmjJ941NjbzEvju3wsFxttigXjgp7nf5IB+hzYdtBEQjF+Y2JU1etOF1R6n+9q8VB+gD+jbwGe6XAmM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(2616005)(956004)(6512007)(8936002)(83380400001)(6506007)(6486002)(5660300002)(8676002)(31686004)(54906003)(86362001)(4326008)(36756003)(316002)(31696002)(66556008)(66476007)(508600001)(2906002)(66946007)(26005)(186003)(110136005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFZVeEp1T0ZJdVBaeUJTeGd2YnB0Q0xZalRFT3RtMndBTlpZcVVhVW9USjkr?= =?utf-8?B?NUt0NW5vdnNPRzBsQTBmNFg2bWV6V0JtMmtSejdTSUxwUnNubW8wZ3UwR0lH?= =?utf-8?B?TzA3SE1kZEcwRHcrYklQempxajZodERoNnBLZkFrbStTei9ZRGMrZzgzYVRD?= =?utf-8?B?VVdkMmZzV0k0eWVYcjF5NEM5M0R4YnA3Sm0wNlZVc0daMGdPclpueXAvRVp1?= =?utf-8?B?bElwVkpoTmdJMDM1VnRHejJVa0kvRGh3dWZQKzRqanQ2Qko2WVRDdDBoNGsy?= =?utf-8?B?VGZ2OGg5MGd2VEE5QWdRaVR2UzZaUTA3Y2wza2Y3V0N2bG1SQkVIK0F5Sm5Q?= =?utf-8?B?YWtTdmd4eTlnNHo0c2cwejFNRWJFZGNOME5GcFNMODJoYm51YUZINjNCaE43?= =?utf-8?B?S3JqbU1zY1ZYM00rN29ZZ1Z3eDU5RVU5THArbnJ1a0tyejdqRUdCUGQ0SEFy?= =?utf-8?B?eFhmM0dJSjBiS2JIQjFoaXAxQ0MxNE5SdFRwc3M2cnNKQlJyektBVzZQOXlX?= =?utf-8?B?NTBoTi9BSlgvNCtQaFFLUGM1bXYwbzJFeDVXNFpYT1BNalhZWUFjYmhhOC9B?= =?utf-8?B?a1hPOXJCeG9GeUkxQ1ROV1RSMUUzNnppeWY0aGFVWE12YnhKZ2pHYm4rK29u?= =?utf-8?B?RWV1Y0tHTSsveFVQOUJ5VDN5aFRGTm0wc0VtK3lSN2xYb1R3aW9iOVBONWlp?= =?utf-8?B?dFlpQit3M0dQam11ek5YQlFiME5ab3FUL0h5ZEoxdVFZSUVzazVnc01YbCt1?= =?utf-8?B?MDNRVTBtMkxocFVWRVdHRWNUQzJHQ21kVVB5Rk1oeGtXR3crQlROL3hJVkVR?= =?utf-8?B?dnk0dzU0VThkZnFBOE84UVBmYlVFaVJuMm5HL1lSMGlxMGZmTGp4eW51THBn?= =?utf-8?B?cm9GNGpSbU9MSUg0ZGl5MHBjdEhRNyttK0NMRTMrbkxXTFlsVjZFVkpuMkcx?= =?utf-8?B?N2VLZms3STB3bUlISXlTenhjMENsdWRnU25EWC9pbFFsOGtCNGs2UmJJNjlC?= =?utf-8?B?ZlF5dkFlNW1QOWhEWHhVaG9YQXZhM1B3UlpuZmtpcUY3dHlLazhXMG1kL0FE?= =?utf-8?B?N0U2TEhnZmdmK1NaN2FEbkdrM3ZHYmlZZWdwZTArYVc5WDc2cEhkM2N6TnZU?= =?utf-8?B?NWhUTGp2bGtDYm8zTnluR1JJS2Z5bVVWelNCbEJva2VqZ3Q4aVIxN1FLZmhs?= =?utf-8?B?aWJ2WGpRTE5tMXUva1RPY1oxWjVWczMrbnd1T1F5Wm5FczhGTVhaRzl5RUQz?= =?utf-8?B?cDdRWFVFREtRVjhnMTIrVmY0VWR4ek5pVEw3aU1mS25PVkprZk54dVl5Y1pE?= =?utf-8?B?azhvUEFyR0p6eW45U2JzNFVZbkh0T0gxUWdiU1RJbnA4UXNBeDVseEgzUlZl?= =?utf-8?B?NFJicHRsWU5RanI1eFBsWjdqS005WFF3aUN2d3E4WC9UZmF0RXZMSzVzNjBW?= =?utf-8?B?S3duNE11OTdLUDFUL1ArUlgydkJUUkZTaXRjM3RhbkF6NjVKY0pVZlI0NGo2?= =?utf-8?B?K1FYdXpWdnJsYklkcFN5YWRZMWJnS1VENUdlQnFBcFVoME56ZlBHU3JxQnRF?= =?utf-8?B?TEJ5SmMvcDRnRHVkSW8rTE1Jb041cGZUVC81WGJtSHg3VHUwNEpuZk5WNHNa?= =?utf-8?B?OExHbStFcnhKSmt2RThOaU1QQ0ZMYlN6ZmI2RkRPemdCRVJObTJ4VjdZYS80?= =?utf-8?B?N2R2aWpIelI4Vy82bnpNSEViMEFEMWpnb1gvdFkrZ0lyUlJ2bE9WMVN0dG5K?= =?utf-8?B?ZTYyV0NZYUlkK1VsWDBoWWprOCt5NksxaTRFbFAvV2JQYTc3RHBySVZDeklo?= =?utf-8?B?TVo1YmU0YnRnYlp3QytQZFJDNGU4M0RmQ2dQbnU4WUxEQkJHMjJ4dVQvNVIz?= =?utf-8?B?cFI4ZGRBOVErNEJPOVdiYzdZSlgvK0FJMDBIUGUxSXIyZENWcDI0SEZQb01M?= =?utf-8?B?MzgyNE90K2YrVlh1WnpqTk9UY0dMM0w3dXlxcDV1L01hb0NobnExeUZ4TTRT?= =?utf-8?B?NTFiQ0FvaW9mMlFEU0RqamJHY1VVeWN0VkJUZHlwckZwMGVvYmFDMktvaXQy?= =?utf-8?B?SEpoNCtOeW9DbFpWZ0F0SStwcTV1UUhrNWV3VUJQQStGeGJjUzk2bDZueUFE?= =?utf-8?B?TGFFdXlNVzgvR1NWNUFaOVhHMEtRRVhmdmd6KzEzMjgzbm11RW5LK01CZFJI?= =?utf-8?Q?J8vYQmIB+5Pg9bNODkf+MKY=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3e315a7-2c85-4c44-2df2-08d99a40cfbd X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 18:29:00.6578 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MGx7sZj5EwFzl5WLd0PN4PlB7XTY10+a0mkASOF3V3vJ5z4X8BnfH9HcZCj2mrpMAuT3Y+5y1FxIoJHneX3VSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5134 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/28/21 10:52 AM, Yao, Jiewen wrote: > Thanks Brijesh. > > We can merge SNP patches at first, then decide next step. Not a problem. > > TEE is just my initial thought. And I am open to change if we have a better name. > > We already have EFI_TEE_MEASUREMENT_PROTOCOL. I did not see your feedback on that. So I assume you agree with that. > > If you have different idea, please feedback to this patch. I hope we have one name. > > COCO seems weird to me, btw. :( Like Brijesh, I worry about confusion with the ARM TEE feature. Maybe just CC then? Thanks, Tom > > Thank you > Yao Jiewen > >> -----Original Message----- >> From: Brijesh Singh >> Sent: Thursday, October 28, 2021 11:35 PM >> To: Yao, Jiewen ; kraxel@redhat.com; Xu, Min M >> >> Cc: brijesh.singh@amd.com; devel@edk2.groups.io; Erdem Aktas >> ; James Bottomley ; Tom >> Lendacky ; Dong, Eric ; Ni, >> Ray ; Kumar, Rahul1 >> Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: >> Add base support for the #VE exception >> >> >> >> On 10/27/21 8:59 PM, Yao, Jiewen wrote: >>> Hi Gerd >>> I tend to agree with you on the direction to use one TEE specific Exception lib. >>> >>> However, I have naming concern. >>> The VMG is very SEV specific term. I don't believe it is a right name to cover >> the TEE exception lib. >>> >>> If Brijesh agree to merge, I think we should rename it to a neutral name, such >> as TeeExitLib. >>> >>> What do you think, Brijesh? >> >> I am good with merging both the TDX and SEV feature into one library but >> I am not sure about the "TEE" name in it. TEE generally is used on the >> ARM. In Linux kernel and everywhere else we have been using the COCO >> (Confidential Computing), so something along that line makes much more >> sense. >> >> We can rename the library after the SNP patches are merged. I would >> prefer to avoid renaming because all of the SNP patches are Ack-ed. >> >> -Brijesh >>> >>> Thank you >>> Yao Jiewen >>> >>> >>>> -----Original Message----- >>>> From: kraxel@redhat.com >>>> Sent: Wednesday, October 27, 2021 3:20 PM >>>> To: Xu, Min M >>>> Cc: Brijesh Singh ; Yao, Jiewen >>>> ; devel@edk2.groups.io; Erdem Aktas >>>> ; James Bottomley ; Tom >>>> Lendacky ; Dong, Eric ; >> Ni, >>>> Ray ; Kumar, Rahul1 >>>> Subject: Re: [edk2-devel] [PATCH V2 12/28] >> UefiCpuPkg/CpuExceptionHandler: >>>> Add base support for the #VE exception >>>> >>>> Hi, >>>> >>>>>> How about adding the tdx exception handler to the existing library, so we >>>> don't >>>>>> have the churn of adding a new library everywhere *again*? >>>> >>>>> Do you mean add the VmTdExitVeHandler.c/VmTdExitLibNull.c in >>>> CpuExceptionHandlerLib, then include the corresponding source file in each >>>> *CpuExceptionHandlerLib.inf? >>>> >>>> No, I mean extend the existing VmgExitLib instead of adding a new >>>> VmTdExitLib, i.e. place the tdx handler in >>>> OvmfPkg/Library/VmgExitLib/TdxExitHandler.c >>>> >>>> take care, >>>> Gerd >>>