From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.9147.1672993323313429294 for ; Fri, 06 Jan 2023 00:22:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X31WRuAx; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672993322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qpyuBnz5icUjqG9wgPZJMBx94jKnbLkH3lacSUI/7W4=; b=X31WRuAxDM5GNry5GEuFwPbZzKLw5AEnr2h+d5SeOlfgfFoZ99d6KhB08uUqAdupUVERo2 2hiv820UHSJr0IJ2UGo7EHCvQZXJZp3YKwipBMHkK+jKIn6ybPfsQhqBrhDpADKUQPO4ub l0gCjeYhuMVMaiAD8Bp9jaR8nPxPS80= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-Jrh_WEcDNxKdUOjfbkhN0w-1; Fri, 06 Jan 2023 03:21:59 -0500 X-MC-Unique: Jrh_WEcDNxKdUOjfbkhN0w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92AED29AA2C0; Fri, 6 Jan 2023 08:21:58 +0000 (UTC) Received: from [10.39.192.26] (unknown [10.39.192.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A07C2026D4B; Fri, 6 Jan 2023 08:21:56 +0000 (UTC) Message-ID: Date: Fri, 6 Jan 2023 09:21:55 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: designate Gerd Hoffmann as UefiCpuPkg reviewer To: devel@edk2.groups.io, ray.ni@intel.com Cc: Andrew Fish , "Dong, Eric" , Gerd Hoffmann , Leif Lindholm , "Kinney, Michael D" , "Kumar, Rahul R" References: <20230103160539.87830-1-lersek@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/4/23 15:06, Ni, Ray wrote: > Reviewed-by: Ray Ni Thanks; PR#3861 / commit 0aca5901e344. Laszlo > >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Wednesday, January 4, 2023 12:06 AM >> To: devel@edk2.groups.io >> Cc: Andrew Fish ; Dong, Eric ; Gerd Hoffmann ; Leif >> Lindholm ; Kinney, Michael D ; Kumar, Rahul R >> ; Ni, Ray >> Subject: [PATCH 1/1] Maintainers.txt: designate Gerd Hoffmann as UefiCpuPkg reviewer >> >> I suggest that Gerd be notified about all UefiCpuPkg patches, so he may >> take a quick look at, or (by his preference) even test, the proposed >> change, in a genuine QEMU/KVM environment. >> >> Assuming this patch is accepted -- subsequently, please *wait* for Gerd's >> approval on UefiCpuPkg patches, before merging them. >> >> Notes: >> >> - It's perfectly fine for a reviewer to give an A-b just so the review >> process be unblocked, if they don't have anything to add, or don't have >> time to review or test in detail. The point is that someone outside of >> Intel should *consistently get a chance* to raise concerns about >> UefiCpuPkg patches before they are merged. >> >> - My A-b's and R-b's on UefiCpuPkg patches were never supposed to be >> "sufficient", only "necessary", for merging. The intent is the same >> here, with Gerd's designation as a reviewer. >> >> Cc: Andrew Fish >> Cc: Eric Dong >> Cc: Gerd Hoffmann >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> Cc: Rahul Kumar >> Cc: Ray Ni >> Signed-off-by: Laszlo Ersek >> --- >> Maintainers.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 13e1335a57dd..3399981bbae7 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -605,6 +605,7 @@ W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg >> M: Eric Dong [ydong10] >> M: Ray Ni [niruiyu] >> R: Rahul Kumar [rahul1-kumar] >> +R: Gerd Hoffmann [kraxel] >> >> UefiCpuPkg: Sec related modules >> F: UefiCpuPkg/SecCore/ > > > > >