From: Laszlo Ersek <lersek@redhat.com>
To: Liming Gao <liming.gao@intel.com>,
edk2-devel@lists.01.org, Dongao Guo <dongao.guo@intel.com>
Subject: Re: [Patch] OvmfPkg: Correct library class name in INF and DSC
Date: Mon, 23 Jul 2018 16:21:48 +0200 [thread overview]
Message-ID: <e245d6c0-903a-061a-bfbc-ad9587bc9226@redhat.com> (raw)
In-Reply-To: <1532320462-16376-1-git-send-email-liming.gao@intel.com>
Hi,
On 07/23/18 06:34, Liming Gao wrote:
> From: Dongao Guo <dongao.guo@intel.com>
>
> ResourcePublicationLib class name is ResourcePublicationLib.
> INF and DSC files are updated to use the correct one.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Dongao Guo <dongao.guo@intel.com>
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 2 +-
> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-
> OvmfPkg/OvmfPkgX64.dsc | 2 +-
> OvmfPkg/PlatformPei/PlatformPei.inf | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> mode change 100644 => 100755 OvmfPkg/OvmfPkgIa32.dsc
> mode change 100644 => 100755 OvmfPkg/OvmfPkgX64.dsc
> mode change 100644 => 100755 OvmfPkg/PlatformPei/PlatformPei.inf
>
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> old mode 100644
> new mode 100755
> index 7ddda89..a28b511
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -268,7 +268,7 @@
> DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf
> !endif
> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> - PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
> + ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
> !ifdef $(SOURCE_DEBUG_ENABLE)
> DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 3481cdc..115d0c0 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -273,7 +273,7 @@
> DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf
> !endif
> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> - PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
> + ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
> !ifdef $(SOURCE_DEBUG_ENABLE)
> DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> old mode 100644
> new mode 100755
> index 8b0895b..362eb78
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -273,7 +273,7 @@
> DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf
> !endif
> PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> - PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
> + ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
> !ifdef $(SOURCE_DEBUG_ENABLE)
> DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/PlatformPei.inf
> old mode 100644
> new mode 100755
> index 0f347f8..9c5ad99
> --- a/OvmfPkg/PlatformPei/PlatformPei.inf
> +++ b/OvmfPkg/PlatformPei/PlatformPei.inf
> @@ -58,7 +58,7 @@
> HobLib
> IoLib
> PciLib
> - PeiResourcePublicationLib
> + ResourcePublicationLib
> PeiServicesLib
> PeiServicesTablePointerLib
> PeimEntryPoint
>
thank you both for the patch. If it's not too much work, I'd like to
request the following updates:
- Please put "ResourcePublicationLib" somewhere in the subject line. For
example:
OvmfPkg: Correct ResourcePublicationLib class name in DSC / INF files
- Please do not change the file mode bits of the DSC files from 100644
to 100755. There's no reason for the DSC files to be executable.
Thanks!
Laszlo
next prev parent reply other threads:[~2018-07-23 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 4:34 [Patch] OvmfPkg: Correct library class name in INF and DSC Liming Gao
2018-07-23 14:21 ` Laszlo Ersek [this message]
2018-07-24 1:57 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e245d6c0-903a-061a-bfbc-ad9587bc9226@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox