ShellPkg: acpiview command doesn't appear to be included in any profile

ShellPkg: acpiview command doesn't appear to be included in any profile

[Rebecca Cran]

I noticed there's an acpiview command, in UefiShellAcpiViewCommandLib, 
but unlike similar commands like smbiosview it's not included in any of 
the shell profiles. Is that deliberate?


-- 
Rebecca Cran

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

[Samer El-Haj-Mahmoud]

smbiosview (and other standard commands) are defined in the UEFI Shell specification, which specifies the profiles/for each command (UEFI Shell Spec 2.2, Table 11). For instance, smbiosview is defined as part of the Debug1 profile. This is why the code registers that command in UefiShellDebug1CommandsLib

acpiview is not a standard command, so it is not included in any of the UEFI Shell specification defined profiles.



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Monday, April 20, 2020 4:23 PM
> To: devel@edk2.groups.io
> Cc: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>
> Subject: [edk2-devel] ShellPkg: acpiview command doesn't appear to be
> included in any profile
>
> I noticed there's an acpiview command, in UefiShellAcpiViewCommandLib, but
> unlike similar commands like smbiosview it's not included in any of the shell
> profiles. Is that deliberate?
>
>
> --
> Rebecca Cran
>
>
>
> 

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

[Michael D Kinney]

The default build of the shell does not include AcpiView.

However, there is a second version of the shell built from
ShellPkg.dsc that does include the AcpiView command.

  #
  # Build a second version of the shell with all commands integrated
  #
  ShellPkg/Application/Shell/Shell.inf {
   <Defines>
      FILE_GUID = EA4BB293-2D7F-4456-A681-1F22F42CD0BC
    <PcdsFixedAtBuild>
      gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
    <LibraryClasses>
      NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
      NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
  }

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Samer El-Haj-Mahmoud
> Sent: Monday, April 20, 2020 1:52 PM
> To: devel@edk2.groups.io; rebecca@bsdio.com
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: Re: [edk2-devel] ShellPkg: acpiview command
> doesn't appear to be included in any profile
> 
> smbiosview (and other standard commands) are defined in
> the UEFI Shell specification, which specifies the
> profiles/for each command (UEFI Shell Spec 2.2, Table
> 11). For instance, smbiosview is defined as part of the
> Debug1 profile. This is why the code registers that
> command in UefiShellDebug1CommandsLib
> 
> acpiview is not a standard command, so it is not
> included in any of the UEFI Shell specification defined
> profiles.
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Rebecca
> > Cran via groups.io
> > Sent: Monday, April 20, 2020 4:23 PM
> > To: devel@edk2.groups.io
> > Cc: Ray Ni <ray.ni@intel.com>; Zhichao Gao
> <zhichao.gao@intel.com>
> > Subject: [edk2-devel] ShellPkg: acpiview command
> doesn't appear to be
> > included in any profile
> >
> > I noticed there's an acpiview command, in
> UefiShellAcpiViewCommandLib, but
> > unlike similar commands like smbiosview it's not
> included in any of the shell
> > profiles. Is that deliberate?
> >
> >
> > --
> > Rebecca Cran
> >
> >
> >
> >
> 
> IMPORTANT NOTICE: The contents of this email and any
> attachments are confidential and may also be
> privileged. If you are not the intended recipient,
> please notify the sender immediately and do not
> disclose the contents to any other person, use it for
> any purpose, or store or copy the information in any
> medium. Thank you.
> 
> 

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

[Rothman, Michael A]

I believe the reason that you don't see ACPIVIEW in any profile is largely because the SMBIOSVIEW utility was around at the time of the creation of the Shell specification and I don't believe the ACPIVIEW one was.

Thanks,
Mike Rothman 
(迈克 罗斯曼 / माइकल रोथ्मेन् / Михаил Ротман / משה רוטמן)
רועה עיקרי של חתולים

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Monday, April 20, 2020 1:23 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

I noticed there's an acpiview command, in UefiShellAcpiViewCommandLib, but unlike similar commands like smbiosview it's not included in any of the shell profiles. Is that deliberate?


--
Rebecca Cran

Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

[Sami Mujawar]

Hi All,

There was some effort to include this as part of the UEFI shell Debug 1 profile. This goes back a while when we introduced Acpiview, see https://mantis.uefi.org/mantis/view.php?id=1784
However, Acpiview has changed significantly since then. I am happy to contribute for updating the specification.

Regards,

Sami Mujawar
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rothman, Michael A via groups.io
Sent: 20 April 2020 10:05 PM
To: devel@edk2.groups.io; rebecca@bsdio.com
Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

I believe the reason that you don't see ACPIVIEW in any profile is largely because the SMBIOSVIEW utility was around at the time of the creation of the Shell specification and I don't believe the ACPIVIEW one was.

Thanks,
Mike Rothman
(迈克 罗斯曼 / माइकल रोथ्मेन् / Михаил Ротман / משה רוטמן) רועה עיקרי של חתולים

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Monday, April 20, 2020 1:23 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: [edk2-devel] ShellPkg: acpiview command doesn't appear to be included in any profile

I noticed there's an acpiview command, in UefiShellAcpiViewCommandLib, but unlike similar commands like smbiosview it's not included in any of the shell profiles. Is that deliberate?


--
Rebecca Cran








IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.