From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.17.1662072426172277676 for ; Thu, 01 Sep 2022 15:47:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=WZSgvK5N; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 281MhHBt024793; Thu, 1 Sep 2022 22:46:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=jwp7aeRIieef2a+tncryfmYUOy3k7wen3EBXiPCtbG8=; b=WZSgvK5NlUA1AmG6wzoVJ5Dd0Wdg4SB39g1UkpZvvK8cSVu3SfJgWsQ1pekEen/6l3Yx FeMcCfXBVWwZ6eiLNY2vxgJO4OcNHif69wArxtvDaDyGGEHorc5qwMnEIrAbXkmk2ncb m7Ooo9KwovH2iS0IyveHAV7uLukIvxMdt63yVDMdeAjAVH9jztbwDhEQ1Wt5/tkxH3Dj /P0H2E/cCZ2TPTAmDsIGwbnKRhTTl06YAXihAX0IRxH/wpWCIFnaMcHyv0n3SoyxJGf3 7mTYA2uz3YuH/rPFmAXZlB61OqiDKcAO70QeWpaB5JEvYbINzs6d6dKkmOgVfmP742mA OA== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3jab5gng0p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Sep 2022 22:46:58 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 281Mkv2Z032473 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Sep 2022 22:46:57 GMT Received: from [10.110.126.51] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 1 Sep 2022 15:46:56 -0700 Message-ID: Date: Thu, 1 Sep 2022 16:46:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Use ANSI colors to indicate debug message severity To: , , CC: Mike Kinney , "Gao, Liming" , "Liu, Zhiguang" References: <20220829221211.71032-1-rebecca@quicinc.com> From: "Rebecca Cran" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: vuXI-wRioXrfnVP0bVZ5uq26duxxjXY7 X-Proofpoint-GUID: vuXI-wRioXrfnVP0bVZ5uq26duxxjXY7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-01_12,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209010100 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 9/1/22 16:21, Andrew Fish via groups.io wrote: > I think this feature flag is going to control the output of edk2 > DEBUG. In an abstract sense DEBUG is not Terminal or ConOut. It could > be mapped to the same device, but it does not have to be. > > So maybe PcdDebugAnsiSeqSupport or DebugLibAnsiSeqSupport? Thanks, that makes more sense. I'll send out a v3 patch with PcdDebugAnsiSeqSupport. -- Rebecca Cran