From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.68427.1661765339140350608 for ; Mon, 29 Aug 2022 02:28:59 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WO/XPUsU; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: ted.kuo@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661765339; x=1693301339; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zj6Z4+RNHGRf06qsUFUvErkqQ45n8drztlHz7urOyEU=; b=WO/XPUsUR8TaLtdg09QRgO/UOFm650RO485JlgYaai14Bb1XygNJCeHd 1SsP1a+xlvahko23KTBd5GVGshl0IG11obKJXUf6E2eBhcHd3IsvaogdZ w5CtY32Xbrz+rBuXTrHYlxYjaYlygmkwWAQjrN2u6jY6eYBxpUK+dErsl aULz4P8O3vnfKtgpxyIzIW30mbEp8j4BtZKAEP1FVkOO4ib7IATZ5zmoY uYK8mGvpAaCG2VFKOO4zgyeS+mJrNIYBOpzcX1u2Mb47ZYQ3GmWz989ha BZnDHrp+pT8tuWrfOHevDkWxvxIRoVQkPw98Pi+Tk2vfyXzs87+STXZnu g==; X-IronPort-AV: E=McAfee;i="6500,9779,10453"; a="295629637" X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="295629637" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 02:28:58 -0700 X-IronPort-AV: E=Sophos;i="5.93,272,1654585200"; d="scan'208";a="562159239" Received: from tedkuo1-win10.gar.corp.intel.com ([10.5.215.13]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 02:28:56 -0700 From: "Kuo, Ted" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao , Yuwei Chen , Lee Hamel Subject: [edk2-devel][PATCH v1] BaseTools: 64bit FSP FV map file cannot be created correctly Date: Mon, 29 Aug 2022 17:28:17 +0800 Message-Id: X-Mailer: git-send-email 2.35.3.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable https://bugzilla.tianocore.org/show_bug.cgi?id=3D4035 64bit FSP FV map file cannot be created correctly when using CLANG compiler. When compiling 64bit FSP with CLANG, there is no prefix symbol '_' added to function name. Hence FSP FV map file cannot be created properly. Updated the if condition for CLANG in GenFv to get the issue fixed. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Lee Hamel Signed-off-by: Ted Kuo --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c b/BaseTools/Source= /C/GenFv/GenFvInternalLib.c index d650a527a5..d28ac8f6eb 100644 --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c @@ -1004,7 +1004,7 @@ Returns: if (IsUseClang) {=0D sscanf (Line, "%llx %s %s %s", &TempLongAddress, KeyWord, KeyWord2= , FunctionTypeName);=0D FunctionAddress =3D (UINT64) TempLongAddress;=0D - if (FunctionTypeName [0] =3D=3D '_' ) {=0D + if (FunctionTypeName [0] !=3D '/' && FunctionTypeName [0] !=3D '.'= && FunctionTypeName [1] !=3D ':') {=0D fprintf (FvMapFile, " 0x%010llx ", (unsigned long long) (Ima= geBaseAddress + FunctionAddress - LinkTimeBaseAddress));=0D fprintf (FvMapFile, "%s\n", FunctionTypeName);=0D }=0D --=20 2.35.3.windows.1