Re: [edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

["Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>]

On 8/1/2024 10:02 PM, Leif Lindholm via groups.io wrote:
> On Thu, Aug 01, 2024 at 16:36:15 +0700, Nhi Pham wrote:
>> This introduces fixed PCDs for SMBUS and BMC as specified to Ampere.
>>
>> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
>> ---
>>   Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
>> index 56e8b2fd2f11..5c5015c1bf21 100644
>> --- a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
>> +++ b/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec
>> @@ -69,6 +69,18 @@ [PcdsFixedAtBuild]
>>     gAmpereTokenSpaceGuid.PcdSmbiosTables0MajorVersion|0xFF|UINT8|0x00000005
>>     gAmpereTokenSpaceGuid.PcdSmbiosTables0MinorVersion|0xFF|UINT8|0x00000006
>>   
>> +  #
>> +  # SMBUS
>> +  #
>> +  gAmpereTokenSpaceGuid.PcdSmbusI2cBusNumber|0x00|UINT8|0x00000007
>> +  gAmpereTokenSpaceGuid.PcdSmbusI2cBusSpeed|100000|UINT32|0x00000008 # Hz
>> +
>> +  #
>> +  # BMC
>> +  #
>> +  gAmpereTokenSpaceGuid.PcdBmcSlaveAddr|0x10|UINT8|0x00000009
> 
> Current Smbus specification uses controller/target terminology.
> 
> /
>      Leif

I will update in the next version, thanks Leif.

Regards,
Nhi


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120219): https://edk2.groups.io/g/devel/message/120219
Mute This Topic: https://groups.io/mt/107662236/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-