From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.898.1634245570427164639 for ; Thu, 14 Oct 2021 14:06:10 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5CD211D4; Thu, 14 Oct 2021 14:06:03 -0700 (PDT) Received: from [192.168.122.166] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 109193F694; Thu, 14 Oct 2021 14:06:03 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute To: Ard Biesheuvel , edk2-devel-groups-io , mark.kettenis@xs4all.nl Cc: Ard Biesheuvel , Leif Lindholm , Peter Batard , Mark Kettenis References: <20211010194814.17129-1-kettenis@openbsd.org> From: "Jeremy Linton" Message-ID: Date: Thu, 14 Oct 2021 16:05:51 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 10/10/21 4:10 PM, Ard Biesheuvel wrote: > On Sun, 10 Oct 2021 at 21:48, Mark Kettenis wrote: >> >> The MMIO host bridge window isn't translated as both the primary >> and secondary side are MMIO. So remove the incorrect >> TypeTranslation attribute. >> >> Signed-off-by: Mark Kettenis > > Reviewed-by: Ard Biesheuvel > > Pushed as bbb431a0c658..ab6fcc28fd99 > > Thanks, > >> --- >> Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl >> index ee37b7a21e..f485c6b5d2 100644 >> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl >> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl >> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2) >> 1, // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN >> SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW >> 2 // SANITIZED_PCIE_MMIO_LEN + 1 >> - ,,,MMI1,,TypeTranslation >> + ,,,MMI1 >> ) Its a bit late, but this looks fine. THanks! >> >> // root port registers, not to be used if SMCCC is utilized >> -- >> 2.33.0 >> >> >> >> ------------ >> Groups.io Links: You receive all messages sent to this group. >> View/Reply Online (#81734): https://edk2.groups.io/g/devel/message/81734 >> Mute This Topic: https://groups.io/mt/86221449/1131722 >> Group Owner: devel+owner@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org] >> ------------ >> >>