* [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
@ 2021-01-13 8:28 Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution Laszlo Ersek
` (4 more replies)
0 siblings, 5 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-13 8:28 UTC (permalink / raw)
To: devel
Cc: Agyeman Prince, Ard Biesheuvel, Chasel Chiu, Deepika Kethi Reddy,
Jeremy Soller, Kathappan Esakkithevar, Kelly Steele,
Leif Lindholm, Marcin Wojtas, Meenakshi Aggarwal,
Michael D Kinney, Nate DeSimone, Philippe Mathieu-Daudé,
Rangasai V Chaganty, Thomas Abraham, Wenyi Xie, Yi Qian,
Zailiang Sun
The edk2 patch
ShellPkg/ShellCommandLib: add ShellSortFileList
for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
instance dependent on the OrderedCollectionLib class. Because the shell
binaries in several silicon and platform DSCs in edk2-platforms consume
the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
class in those DSCs.
Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Jeremy Soller <jeremy@system76.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Thanks
Laszlo
Laszlo Ersek (3):
Platform/BeagleBoard: add missing TimeBaseLib resolution
ARM Silicon and Platforms: add OrderedCollectionLib class resolution
Intel Platforms: add OrderedCollectionLib class resolution
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 ++
Platform/Hisilicon/D03/D03.dsc | 1 +
Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
22 files changed, 23 insertions(+)
base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
--
2.19.1.3.g30247aa5d201
^ permalink raw reply [flat|nested] 18+ messages in thread
* [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution
2021-01-13 8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
@ 2021-01-13 8:28 ` Laszlo Ersek
2021-01-18 8:16 ` [edk2-devel] " Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution Laszlo Ersek
` (3 subsequent siblings)
4 siblings, 1 reply; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-13 8:28 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Philippe Mathieu-Daudé
Add the resolution for TimeBaseLib, which is now required to build the
EmbeddedPkg RTC driver.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
index 471f80ce3cf0..1725e5cad378 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -82,6 +82,7 @@ [LibraryClasses.common]
SemihostLib|ArmPkg/Library/SemihostLib/SemihostLib.inf
RealTimeClockLib|Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeClockLib.inf
+ TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
--
2.19.1.3.g30247aa5d201
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution
2021-01-13 8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution Laszlo Ersek
@ 2021-01-13 8:28 ` Laszlo Ersek
2021-01-15 9:27 ` Marcin Wojtas
2021-01-18 8:19 ` [edk2-devel] " Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
` (2 subsequent siblings)
4 siblings, 2 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-13 8:28 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Meenakshi Aggarwal,
Philippe Mathieu-Daudé, Thomas Abraham, Wenyi Xie
The edk2 patch
ShellPkg/ShellCommandLib: add ShellSortFileList
for BZ#3151 will make the
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
instance dependent on the OrderedCollectionLib class. Because the shell
binaries in the ARM silicon and platform DSCs consume the above
UefiShellCommandLib instance, resolve the OrderedCollectionLib class in
them.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
Platform/Hisilicon/D03/D03.dsc | 1 +
Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
12 files changed, 12 insertions(+)
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
index 274b2a297c3c..fee7cfcc2d40 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
@@ -451,6 +451,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
}
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index e8e730044117..4cdafe8b1f62 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -584,6 +584,7 @@ [Components.common]
NULL|Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.inf
NULL|Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
index 38aa1f22a49d..99a317aba7e6 100644
--- a/Silicon/NXP/NxpQoriqLs.dsc.inc
+++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
@@ -86,6 +86,7 @@ [LibraryClasses.common]
SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 19102b2ef818..05d1b69c833a 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -700,6 +700,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
index 1725e5cad378..c5fc978c5fb7 100644
--- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -482,6 +482,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index d4ec3be24336..5a2441dcd32e 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -502,6 +502,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
!ifdef $(INCLUDE_DP)
diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
index 83c901cf470c..d84462514042 100644
--- a/Platform/Hisilicon/HiKey/HiKey.dsc
+++ b/Platform/Hisilicon/HiKey/HiKey.dsc
@@ -286,6 +286,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
<PcdsFixedAtBuild>
diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
index 151c6312f87f..bf9d51e0b73d 100644
--- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
+++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
@@ -265,6 +265,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
<PcdsFixedAtBuild>
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index d787f87c0b86..26bbbb24976b 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -636,6 +636,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 0e6ab83a2495..0a11b796cca5 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -133,6 +133,7 @@ [LibraryClasses.common.UEFI_APPLICATION]
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
index 95643685e8aa..18accbfd5d89 100644
--- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
+++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
@@ -193,6 +193,7 @@ [LibraryClasses.common.UEFI_APPLICATION]
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index d5f75cbba5e5..dd45b4142c77 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -633,6 +633,7 @@ [Components.common]
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
--
2.19.1.3.g30247aa5d201
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [edk2-platforms PATCH 3/3] Intel Platforms: add OrderedCollectionLib class resolution
2021-01-13 8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution Laszlo Ersek
@ 2021-01-13 8:28 ` Laszlo Ersek
2021-01-15 23:34 ` [edk2-devel] " Nate DeSimone
` (2 more replies)
2021-01-15 8:50 ` [edk2-devel] [edk2-platforms PATCH 0/3] " Laszlo Ersek
2021-01-15 9:27 ` Philippe Mathieu-Daudé
4 siblings, 3 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-13 8:28 UTC (permalink / raw)
To: devel
Cc: Agyeman Prince, Chasel Chiu, Deepika Kethi Reddy, Jeremy Soller,
Kathappan Esakkithevar, Kelly Steele, Michael D Kinney,
Nate DeSimone, Philippe Mathieu-Daudé, Rangasai V Chaganty,
Yi Qian, Zailiang Sun
The edk2 patch
ShellPkg/ShellCommandLib: add ShellSortFileList
for BZ#3151 will make the
ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
instance dependent on the OrderedCollectionLib class. Because the shell
binaries in the Intel platform DSCs consume the above UefiShellCommandLib
instance, resolve the OrderedCollectionLib class in them.
Cc: Agyeman Prince <prince.agyeman@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
Cc: Jeremy Soller <jeremy@system76.com>
Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
10 files changed, 10 insertions(+)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 6de834565a7a..775eda4b03bc 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
@@ -378,6 +378,7 @@ [Components.X64]
NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
index 862e6a6655a3..c400173f7e0a 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
@@ -350,6 +350,7 @@ [Components.X64]
NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
index 0b30da8f9665..d76c220b9145 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
@@ -429,6 +429,7 @@ [Components.X64]
NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
index 9f64dcb62724..e29c7465b1e4 100644
--- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
@@ -912,6 +912,7 @@ [Components.IA32]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
index db144aab75ae..6fdfba9a58dc 100644
--- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
+++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
@@ -639,6 +639,7 @@ [Components.IA32]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
index 77c408a326db..186e0a0df980 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
@@ -270,6 +270,7 @@ [Components.X64]
NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 4fa3e2013120..409f31c982d7 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -1152,6 +1152,7 @@ [Components.IA32]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
<PcdsFixedAtBuild>
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 8adae2e24993..38bd825c8bdc 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -1167,6 +1167,7 @@ [Components.X64]
NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
<PcdsFixedAtBuild>
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index fb493973e22d..463234a3d948 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -371,6 +371,7 @@ [Components.X64]
NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
index 9a1f107fafe1..586fa848650f 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
@@ -377,6 +377,7 @@ [Components.X64]
NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
+ OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
--
2.19.1.3.g30247aa5d201
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
2021-01-13 8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
` (2 preceding siblings ...)
2021-01-13 8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
@ 2021-01-15 8:50 ` Laszlo Ersek
2021-01-15 9:22 ` Ard Biesheuvel
2021-01-15 22:04 ` Leif Lindholm
2021-01-15 9:27 ` Philippe Mathieu-Daudé
4 siblings, 2 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-15 8:50 UTC (permalink / raw)
To: devel
Cc: Agyeman Prince, Ard Biesheuvel, Chasel Chiu, Deepika Kethi Reddy,
Jeremy Soller, Kathappan Esakkithevar, Kelly Steele,
Leif Lindholm, Marcin Wojtas, Meenakshi Aggarwal,
Michael D Kinney, Nate DeSimone, Philippe Mathieu-Daudé,
Rangasai V Chaganty, Thomas Abraham, Wenyi Xie, Yi Qian,
Zailiang Sun, Ard Biesheuvel (ARM address)
Hi All,
sorry about the message; it's been only two days indeed.
This patch series is trivial, it adds one lib class resolution to each
of 22 platforms in edk2-platforms.
I build-tested the platforms modified by this change, so I'm planning to
push the series to edk2-platforms one week after posting it -- even if I
get no feedback. Thus, the reason I'm sending this email isn't really to
ping or urge reviewers, it's more like announcing my plan.
Thanks,
Laszlo
On 01/13/21 09:28, Laszlo Ersek wrote:
> The edk2 patch
>
> ShellPkg/ShellCommandLib: add ShellSortFileList
>
> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in several silicon and platform DSCs in edk2-platforms consume
> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
> class in those DSCs.
>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (3):
> Platform/BeagleBoard: add missing TimeBaseLib resolution
> ARM Silicon and Platforms: add OrderedCollectionLib class resolution
> Intel Platforms: add OrderedCollectionLib class resolution
>
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 ++
> Platform/Hisilicon/D03/D03.dsc | 1 +
> Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
> Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
> 22 files changed, 23 insertions(+)
>
>
> base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
2021-01-15 8:50 ` [edk2-devel] [edk2-platforms PATCH 0/3] " Laszlo Ersek
@ 2021-01-15 9:22 ` Ard Biesheuvel
2021-01-15 9:35 ` Laszlo Ersek
2021-01-15 22:04 ` Leif Lindholm
1 sibling, 1 reply; 18+ messages in thread
From: Ard Biesheuvel @ 2021-01-15 9:22 UTC (permalink / raw)
To: devel, lersek
Cc: Agyeman Prince, Ard Biesheuvel, Chasel Chiu, Deepika Kethi Reddy,
Jeremy Soller, Kathappan Esakkithevar, Kelly Steele,
Leif Lindholm, Marcin Wojtas, Meenakshi Aggarwal,
Michael D Kinney, Nate DeSimone, Philippe Mathieu-Daudé,
Rangasai V Chaganty, Thomas Abraham, Wenyi Xie, Yi Qian,
Zailiang Sun
On 1/15/21 9:50 AM, Laszlo Ersek wrote:
> Hi All,
>
> sorry about the message; it's been only two days indeed.
>
> This patch series is trivial, it adds one lib class resolution to each
> of 22 platforms in edk2-platforms.
>
> I build-tested the platforms modified by this change, so I'm planning to
> push the series to edk2-platforms one week after posting it -- even if I
> get no feedback. Thus, the reason I'm sending this email isn't really to
> ping or urge reviewers, it's more like announcing my plan.
>
> Thanks,
> Laszlo
>
>
> On 01/13/21 09:28, Laszlo Ersek wrote:
>> The edk2 patch
>>
>> ShellPkg/ShellCommandLib: add ShellSortFileList
>>
>> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>>
>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>
>> instance dependent on the OrderedCollectionLib class. Because the shell
>> binaries in several silicon and platform DSCs in edk2-platforms consume
>> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
>> class in those DSCs.
>>
>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>> Cc: Jeremy Soller <jeremy@system76.com>
>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>> Cc: Kelly Steele <kelly.steele@intel.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Marcin Wojtas <mw@semihalf.com>
>> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>> Cc: Thomas Abraham <thomas.abraham@arm.com>
>> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>>
Where appropriate in the series,
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
and
Acked-by: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (3):
>> Platform/BeagleBoard: add missing TimeBaseLib resolution
>> ARM Silicon and Platforms: add OrderedCollectionLib class resolution
>> Intel Platforms: add OrderedCollectionLib class resolution
>>
>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 ++
>> Platform/Hisilicon/D03/D03.dsc | 1 +
>> Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
>> Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
>> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
>> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
>> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
>> 22 files changed, 23 insertions(+)
>>
>>
>> base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
>>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution
2021-01-13 8:28 ` [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution Laszlo Ersek
@ 2021-01-15 9:27 ` Marcin Wojtas
2021-01-18 8:19 ` [edk2-devel] " Laszlo Ersek
1 sibling, 0 replies; 18+ messages in thread
From: Marcin Wojtas @ 2021-01-15 9:27 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel-groups-io, Ard Biesheuvel, Leif Lindholm,
Meenakshi Aggarwal, Philippe Mathieu-Daudé, Thomas Abraham,
Wenyi Xie
śr., 13 sty 2021 o 09:29 Laszlo Ersek <lersek@redhat.com> napisał(a):
>
> The edk2 patch
>
> ShellPkg/ShellCommandLib: add ShellSortFileList
>
> for BZ#3151 will make the
>
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in the ARM silicon and platform DSCs consume the above
> UefiShellCommandLib instance, resolve the OrderedCollectionLib class in
> them.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
> Platform/Hisilicon/D03/D03.dsc | 1 +
> Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
> Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
> 12 files changed, 12 insertions(+)
>
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> index 274b2a297c3c..fee7cfcc2d40 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> @@ -451,6 +451,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> }
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index e8e730044117..4cdafe8b1f62 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -584,6 +584,7 @@ [Components.common]
> NULL|Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.inf
> NULL|Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
> index 38aa1f22a49d..99a317aba7e6 100644
> --- a/Silicon/NXP/NxpQoriqLs.dsc.inc
> +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
> @@ -86,6 +86,7 @@ [LibraryClasses.common]
> SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 19102b2ef818..05d1b69c833a 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -700,6 +700,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 1725e5cad378..c5fc978c5fb7 100644
> --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -482,6 +482,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index d4ec3be24336..5a2441dcd32e 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -502,6 +502,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> !ifdef $(INCLUDE_DP)
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 83c901cf470c..d84462514042 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -286,6 +286,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> index 151c6312f87f..bf9d51e0b73d 100644
> --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
> +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> @@ -265,6 +265,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> index d787f87c0b86..26bbbb24976b 100644
> --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> @@ -636,6 +636,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> index 0e6ab83a2495..0a11b796cca5 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> @@ -133,6 +133,7 @@ [LibraryClasses.common.UEFI_APPLICATION]
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> index 95643685e8aa..18accbfd5d89 100644
> --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> @@ -193,6 +193,7 @@ [LibraryClasses.common.UEFI_APPLICATION]
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index d5f75cbba5e5..dd45b4142c77 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -633,6 +633,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> --
> 2.19.1.3.g30247aa5d201
>
>
For Marvell platforms:
Reviewed-by: Marcin Wojtas <mw@semihalf.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
2021-01-13 8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
` (3 preceding siblings ...)
2021-01-15 8:50 ` [edk2-devel] [edk2-platforms PATCH 0/3] " Laszlo Ersek
@ 2021-01-15 9:27 ` Philippe Mathieu-Daudé
4 siblings, 0 replies; 18+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-15 9:27 UTC (permalink / raw)
To: Laszlo Ersek, devel
Cc: Agyeman Prince, Ard Biesheuvel, Chasel Chiu, Deepika Kethi Reddy,
Jeremy Soller, Kathappan Esakkithevar, Kelly Steele,
Leif Lindholm, Marcin Wojtas, Meenakshi Aggarwal,
Michael D Kinney, Nate DeSimone, Rangasai V Chaganty,
Thomas Abraham, Wenyi Xie, Yi Qian, Zailiang Sun
On 1/13/21 9:28 AM, Laszlo Ersek wrote:
> The edk2 patch
>
> ShellPkg/ShellCommandLib: add ShellSortFileList
>
> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in several silicon and platform DSCs in edk2-platforms consume
> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
> class in those DSCs.
>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (3):
> Platform/BeagleBoard: add missing TimeBaseLib resolution
> ARM Silicon and Platforms: add OrderedCollectionLib class resolution
> Intel Platforms: add OrderedCollectionLib class resolution
>
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 ++
> Platform/Hisilicon/D03/D03.dsc | 1 +
> Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
> Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
> 22 files changed, 23 insertions(+)
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
2021-01-15 9:22 ` Ard Biesheuvel
@ 2021-01-15 9:35 ` Laszlo Ersek
0 siblings, 0 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-15 9:35 UTC (permalink / raw)
To: Ard Biesheuvel, devel
Cc: Agyeman Prince, Ard Biesheuvel, Chasel Chiu, Deepika Kethi Reddy,
Jeremy Soller, Kathappan Esakkithevar, Kelly Steele,
Leif Lindholm, Marcin Wojtas, Meenakshi Aggarwal,
Michael D Kinney, Nate DeSimone, Philippe Mathieu-Daudé,
Rangasai V Chaganty, Thomas Abraham, Wenyi Xie, Yi Qian,
Zailiang Sun
On 01/15/21 10:22, Ard Biesheuvel wrote:
> On 1/15/21 9:50 AM, Laszlo Ersek wrote:
>> Hi All,
>>
>> sorry about the message; it's been only two days indeed.
>>
>> This patch series is trivial, it adds one lib class resolution to each
>> of 22 platforms in edk2-platforms.
>>
>> I build-tested the platforms modified by this change, so I'm planning to
>> push the series to edk2-platforms one week after posting it -- even if I
>> get no feedback. Thus, the reason I'm sending this email isn't really to
>> ping or urge reviewers, it's more like announcing my plan.
>>
>> Thanks,
>> Laszlo
>>
>>
>> On 01/13/21 09:28, Laszlo Ersek wrote:
>>> The edk2 patch
>>>
>>> ShellPkg/ShellCommandLib: add ShellSortFileList
>>>
>>> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>>>
>>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>>
>>> instance dependent on the OrderedCollectionLib class. Because the shell
>>> binaries in several silicon and platform DSCs in edk2-platforms consume
>>> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
>>> class in those DSCs.
>>>
>>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>>> Cc: Jeremy Soller <jeremy@system76.com>
>>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>>> Cc: Kelly Steele <kelly.steele@intel.com>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Marcin Wojtas <mw@semihalf.com>
>>> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>>> Cc: Thomas Abraham <thomas.abraham@arm.com>
>>> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>>> Cc: Yi Qian <yi.qian@intel.com>
>>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>>>
>
> Where appropriate in the series,
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> and
>
> Acked-by: Ard Biesheuvel <ardb+tianocore@kernel.org>
much appreciated everyone!
Laszlo
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
2021-01-15 8:50 ` [edk2-devel] [edk2-platforms PATCH 0/3] " Laszlo Ersek
2021-01-15 9:22 ` Ard Biesheuvel
@ 2021-01-15 22:04 ` Leif Lindholm
2021-01-18 7:41 ` Laszlo Ersek
1 sibling, 1 reply; 18+ messages in thread
From: Leif Lindholm @ 2021-01-15 22:04 UTC (permalink / raw)
To: devel, lersek
Cc: Agyeman Prince, Ard Biesheuvel, Chasel Chiu, Deepika Kethi Reddy,
Jeremy Soller, Kathappan Esakkithevar, Kelly Steele,
Marcin Wojtas, Meenakshi Aggarwal, Michael D Kinney,
Nate DeSimone, Philippe Mathieu-Daudé, Rangasai V Chaganty,
Thomas Abraham, Wenyi Xie, Yi Qian, Zailiang Sun,
Ard Biesheuvel (ARM address)
Hi Laszlo,
On Fri, Jan 15, 2021 at 09:50:57 +0100, Laszlo Ersek wrote:
> Hi All,
>
> sorry about the message; it's been only two days indeed.
>
> This patch series is trivial, it adds one lib class resolution to each
> of 22 platforms in edk2-platforms.
>
> I build-tested the platforms modified by this change, so I'm planning to
> push the series to edk2-platforms one week after posting it -- even if I
> get no feedback. Thus, the reason I'm sending this email isn't really to
> ping or urge reviewers, it's more like announcing my plan.
>
> Thanks,
> Laszlo
Apologies, I woke up Wednesday to the news we had been acquired by
Qualcomm, and the week got a bit hazy at that point :)
Many thanks for fixing up BeagleBoard as well.
For the relevant patches:
Acked-by: Leif Lindholm <leif@nuviainc.com>
> On 01/13/21 09:28, Laszlo Ersek wrote:
> > The edk2 patch
> >
> > ShellPkg/ShellCommandLib: add ShellSortFileList
> >
> > for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
> >
> > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> >
> > instance dependent on the OrderedCollectionLib class. Because the shell
> > binaries in several silicon and platform DSCs in edk2-platforms consume
> > the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
> > class in those DSCs.
> >
> > Cc: Agyeman Prince <prince.agyeman@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > Cc: Jeremy Soller <jeremy@system76.com>
> > Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > Cc: Kelly Steele <kelly.steele@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Marcin Wojtas <mw@semihalf.com>
> > Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Thomas Abraham <thomas.abraham@arm.com>
> > Cc: Wenyi Xie <xiewenyi2@huawei.com>
> > Cc: Yi Qian <yi.qian@intel.com>
> > Cc: Zailiang Sun <zailiang.sun@intel.com>
> >
> > Thanks
> > Laszlo
> >
> > Laszlo Ersek (3):
> > Platform/BeagleBoard: add missing TimeBaseLib resolution
> > ARM Silicon and Platforms: add OrderedCollectionLib class resolution
> > Intel Platforms: add OrderedCollectionLib class resolution
> >
> > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
> > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
> > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 ++
> > Platform/Hisilicon/D03/D03.dsc | 1 +
> > Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
> > Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
> > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
> > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
> > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
> > Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
> > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
> > Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
> > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
> > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
> > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
> > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
> > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
> > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
> > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> > Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
> > 22 files changed, 23 insertions(+)
> >
> >
> > base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
> >
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add OrderedCollectionLib class resolution
2021-01-13 8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
@ 2021-01-15 23:34 ` Nate DeSimone
2021-01-18 1:38 ` 回复: " gaoliming
2021-01-18 8:16 ` Laszlo Ersek
2 siblings, 0 replies; 18+ messages in thread
From: Nate DeSimone @ 2021-01-15 23:34 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com
Cc: Agyeman, Prince, Chiu, Chasel, Kethi Reddy, Deepika,
Jeremy Soller, Esakkithevar, Kathappan, Steele, Kelly,
Kinney, Michael D, Philippe Mathieu-Daudé,
Chaganty, Rangasai V, Qian, Yi, Sun, Zailiang
Hi Laszlo,
Thanks for taking the time to fix this!
Reviewed-by: Nate DeSimone
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, January 13, 2021 12:29 AM
> To: devel@edk2.groups.io
> Cc: Agyeman, Prince <prince.agyeman@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Kethi Reddy, Deepika
> <deepika.kethi.reddy@intel.com>; Jeremy Soller <jeremy@system76.com>;
> Esakkithevar, Kathappan <kathappan.esakkithevar@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Philippe
> Mathieu-Daudé <philmd@redhat.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Qian, Yi <yi.qian@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add
> OrderedCollectionLib class resolution
>
> The edk2 patch
>
> ShellPkg/ShellCommandLib: add ShellSortFileList
>
> for BZ#3151 will make the
>
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in the Intel platform DSCs consume the above UefiShellCommandLib
> instance, resolve the OrderedCollectionLib class in them.
>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d
> sc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> | 1 +
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
> g.dsc | 1 +
> 10 files changed, 10 insertions(+)
>
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .dsc
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .dsc
> index 6de834565a7a..775eda4b03bc 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .dsc
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg
> .ds
> +++ c
> @@ -378,6 +378,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma
> ndLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> index 862e6a6655a3..c400173f7e0a 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> @@ -350,6 +350,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma
> ndLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index 0b30da8f9665..d76c220b9145 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -429,6 +429,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma
> ndLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> index 9f64dcb62724..e29c7465b1e4 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> @@ -912,6 +912,7 @@ [Components.IA32]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
>
> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> index db144aab75ae..6fdfba9a58dc 100644
> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> @@ -639,6 +639,7 @@ [Components.IA32]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
>
> diff --git
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> index 77c408a326db..186e0a0df980 100644
> ---
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> @@ -270,6 +270,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma
> ndLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 4fa3e2013120..409f31c982d7 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -1152,6 +1152,7 @@ [Components.IA32]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 8adae2e24993..38bd825c8bdc 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -1167,6 +1167,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> <PcdsFixedAtBuild>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> index fb493973e22d..463234a3d948 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> @@ -371,6 +371,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma
> ndLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> Pkg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> Pkg.dsc
> index 9a1f107fafe1..586fa848650f 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> Pkg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard
> Pk
> +++ g.dsc
> @@ -377,6 +377,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma
> ndLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL
> + ib/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg
> CommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> --
> 2.19.1.3.g30247aa5d201
>
>
>
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* 回复: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add OrderedCollectionLib class resolution
2021-01-13 8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
2021-01-15 23:34 ` [edk2-devel] " Nate DeSimone
@ 2021-01-18 1:38 ` gaoliming
2021-01-18 7:56 ` Laszlo Ersek
2021-01-18 8:16 ` Laszlo Ersek
2 siblings, 1 reply; 18+ messages in thread
From: gaoliming @ 2021-01-18 1:38 UTC (permalink / raw)
To: devel, lersek
Cc: 'Agyeman Prince', 'Chasel Chiu',
'Deepika Kethi Reddy', 'Jeremy Soller',
'Kathappan Esakkithevar', 'Kelly Steele',
'Michael D Kinney', 'Nate DeSimone',
'Philippe Mathieu-Daudé',
'Rangasai V Chaganty', 'Yi Qian',
'Zailiang Sun'
Laszlo:
Can you add OrderedCollectionLib library instance into edk2-platforms\Platform\Intel\MinPlatformPkg\Include\Dsc\CoreCommonLib.dsc?
All Intel MinPlatform includes this file. Once this file is updated, their OpenBoardPkg.dsc doesn't need to be changed. That means below DSCs can keep no change.
Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70213+4905953+8761045@groups.io
> <bounce+27952+70213+4905953+8761045@groups.io> 代表 Laszlo Ersek
> 发送时间: 2021年1月13日 16:29
> 收件人: devel@edk2.groups.io
> 抄送: Agyeman Prince <prince.agyeman@intel.com>; Chasel Chiu
> <chasel.chiu@intel.com>; Deepika Kethi Reddy
> <deepika.kethi.reddy@intel.com>; Jeremy Soller <jeremy@system76.com>;
> Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>; Kelly Steele
> <kelly.steele@intel.com>; Michael D Kinney <michael.d.kinney@intel.com>;
> Nate DeSimone <nathaniel.l.desimone@intel.com>; Philippe Mathieu-Daudé
> <philmd@redhat.com>; Rangasai V Chaganty
> <rangasai.v.chaganty@intel.com>; Yi Qian <yi.qian@intel.com>; Zailiang Sun
> <zailiang.sun@intel.com>
> 主题: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add
> OrderedCollectionLib class resolution
>
> The edk2 patch
>
> ShellPkg/ShellCommandLib: add ShellSortFileList
>
> for BZ#3151 will make the
>
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in the Intel platform DSCs consume the above UefiShellCommandLib
> instance, resolve the OrderedCollectionLib class in them.
>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/QuarkPlatformPkg/Quark.dsc
> | 1 +
> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> | 1 +
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> | 1 +
>
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg
> .dsc | 1 +
> 10 files changed, 10 insertions(+)
>
> diff --git
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> dsc
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> dsc
> index 6de834565a7a..775eda4b03bc 100644
> ---
> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> dsc
> +++
> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
> dsc
> @@ -378,6 +378,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
> dLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> index 862e6a6655a3..c400173f7e0a 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> @@ -350,6 +350,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
> dLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index 0b30da8f9665..d76c220b9145 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -429,6 +429,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
> dLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> index 9f64dcb62724..e29c7465b1e4 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> @@ -912,6 +912,7 @@ [Components.IA32]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> index db144aab75ae..6fdfba9a58dc 100644
> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> @@ -639,6 +639,7 @@ [Components.IA32]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> diff --git
> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> index 77c408a326db..186e0a0df980 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> @@ -270,6 +270,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
> dLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 4fa3e2013120..409f31c982d7 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -1152,6 +1152,7 @@ [Components.IA32]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 8adae2e24993..38bd825c8bdc 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -1167,6 +1167,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
> mandsLib.inf
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
> CommandsLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
> <PcdsFixedAtBuild>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> index fb493973e22d..463234a3d948 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> @@ -371,6 +371,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
> dLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> index 9a1f107fafe1..586fa848650f 100644
> ---
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> +++
> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
> kg.dsc
> @@ -377,6 +377,7 @@ [Components.X64]
>
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
> CommandsLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
> dLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
> ib.inf
> +
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
> b/BaseOrderedCollectionRedBlackTreeLib.inf
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
> ommandLib.inf
>
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> --
> 2.19.1.3.g30247aa5d201
>
>
>
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
2021-01-15 22:04 ` Leif Lindholm
@ 2021-01-18 7:41 ` Laszlo Ersek
0 siblings, 0 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-18 7:41 UTC (permalink / raw)
To: Leif Lindholm, devel
Cc: Agyeman Prince, Ard Biesheuvel, Chasel Chiu, Deepika Kethi Reddy,
Jeremy Soller, Kathappan Esakkithevar, Kelly Steele,
Marcin Wojtas, Meenakshi Aggarwal, Michael D Kinney,
Nate DeSimone, Philippe Mathieu-Daudé, Rangasai V Chaganty,
Thomas Abraham, Wenyi Xie, Yi Qian, Zailiang Sun,
Ard Biesheuvel (ARM address)
On 01/15/21 23:04, Leif Lindholm wrote:
> Hi Laszlo,
>
> On Fri, Jan 15, 2021 at 09:50:57 +0100, Laszlo Ersek wrote:
>> Hi All,
>>
>> sorry about the message; it's been only two days indeed.
>>
>> This patch series is trivial, it adds one lib class resolution to each
>> of 22 platforms in edk2-platforms.
>>
>> I build-tested the platforms modified by this change, so I'm planning to
>> push the series to edk2-platforms one week after posting it -- even if I
>> get no feedback. Thus, the reason I'm sending this email isn't really to
>> ping or urge reviewers, it's more like announcing my plan.
>>
>> Thanks,
>> Laszlo
>
> Apologies, I woke up Wednesday to the news we had been acquired by
> Qualcomm, and the week got a bit hazy at that point :)
Yes, that was a surprise.
>
> Many thanks for fixing up BeagleBoard as well.
>
> For the relevant patches:
> Acked-by: Leif Lindholm <leif@nuviainc.com>
Thanks!
Laszlo
>
>> On 01/13/21 09:28, Laszlo Ersek wrote:
>>> The edk2 patch
>>>
>>> ShellPkg/ShellCommandLib: add ShellSortFileList
>>>
>>> for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
>>>
>>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>>
>>> instance dependent on the OrderedCollectionLib class. Because the shell
>>> binaries in several silicon and platform DSCs in edk2-platforms consume
>>> the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
>>> class in those DSCs.
>>>
>>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>>> Cc: Jeremy Soller <jeremy@system76.com>
>>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>>> Cc: Kelly Steele <kelly.steele@intel.com>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Marcin Wojtas <mw@semihalf.com>
>>> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>>> Cc: Thomas Abraham <thomas.abraham@arm.com>
>>> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>>> Cc: Yi Qian <yi.qian@intel.com>
>>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>>>
>>> Thanks
>>> Laszlo
>>>
>>> Laszlo Ersek (3):
>>> Platform/BeagleBoard: add missing TimeBaseLib resolution
>>> ARM Silicon and Platforms: add OrderedCollectionLib class resolution
>>> Intel Platforms: add OrderedCollectionLib class resolution
>>>
>>> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
>>> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
>>> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 ++
>>> Platform/Hisilicon/D03/D03.dsc | 1 +
>>> Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
>>> Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
>>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
>>> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
>>> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
>>> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
>>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
>>> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
>>> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
>>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>>> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
>>> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
>>> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
>>> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
>>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
>>> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
>>> 22 files changed, 23 insertions(+)
>>>
>>>
>>> base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
>>>
>>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: 回复: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add OrderedCollectionLib class resolution
2021-01-18 1:38 ` 回复: " gaoliming
@ 2021-01-18 7:56 ` Laszlo Ersek
0 siblings, 0 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-18 7:56 UTC (permalink / raw)
To: gaoliming, devel
Cc: 'Agyeman Prince', 'Chasel Chiu',
'Deepika Kethi Reddy', 'Jeremy Soller',
'Kathappan Esakkithevar', 'Kelly Steele',
'Michael D Kinney', 'Nate DeSimone',
'Philippe Mathieu-Daudé',
'Rangasai V Chaganty', 'Yi Qian',
'Zailiang Sun'
On 01/18/21 02:38, gaoliming wrote:
> Laszlo:
> Can you add OrderedCollectionLib library instance into edk2-platforms\Platform\Intel\MinPlatformPkg\Include\Dsc\CoreCommonLib.dsc?
OK, I'll do that.
Thanks
Laszlo
>
> All Intel MinPlatform includes this file. Once this file is updated, their OpenBoardPkg.dsc doesn't need to be changed. That means below DSCs can keep no change.
>
> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: bounce+27952+70213+4905953+8761045@groups.io
>> <bounce+27952+70213+4905953+8761045@groups.io> 代表 Laszlo Ersek
>> 发送时间: 2021年1月13日 16:29
>> 收件人: devel@edk2.groups.io
>> 抄送: Agyeman Prince <prince.agyeman@intel.com>; Chasel Chiu
>> <chasel.chiu@intel.com>; Deepika Kethi Reddy
>> <deepika.kethi.reddy@intel.com>; Jeremy Soller <jeremy@system76.com>;
>> Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>; Kelly Steele
>> <kelly.steele@intel.com>; Michael D Kinney <michael.d.kinney@intel.com>;
>> Nate DeSimone <nathaniel.l.desimone@intel.com>; Philippe Mathieu-Daudé
>> <philmd@redhat.com>; Rangasai V Chaganty
>> <rangasai.v.chaganty@intel.com>; Yi Qian <yi.qian@intel.com>; Zailiang Sun
>> <zailiang.sun@intel.com>
>> 主题: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add
>> OrderedCollectionLib class resolution
>>
>> The edk2 patch
>>
>> ShellPkg/ShellCommandLib: add ShellSortFileList
>>
>> for BZ#3151 will make the
>>
>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>
>> instance dependent on the OrderedCollectionLib class. Because the shell
>> binaries in the Intel platform DSCs consume the above UefiShellCommandLib
>> instance, resolve the OrderedCollectionLib class in them.
>>
>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>> Cc: Jeremy Soller <jeremy@system76.com>
>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>> Cc: Kelly Steele <kelly.steele@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> | 1 +
>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> | 1 +
>> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> | 1 +
>> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> | 1 +
>>
>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg
>> .dsc | 1 +
>> 10 files changed, 10 insertions(+)
>>
>> diff --git
>> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> index 6de834565a7a..775eda4b03bc 100644
>> ---
>> a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> +++
>> b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.
>> dsc
>> @@ -378,6 +378,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git
>> a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> index 862e6a6655a3..c400173f7e0a 100644
>> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> @@ -350,6 +350,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git
>> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> index 0b30da8f9665..d76c220b9145 100644
>> ---
>> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> +++
>> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> @@ -429,6 +429,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> index 9f64dcb62724..e29c7465b1e4 100644
>> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> @@ -912,6 +912,7 @@ [Components.IA32]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> index db144aab75ae..6fdfba9a58dc 100644
>> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> @@ -639,6 +639,7 @@ [Components.IA32]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> diff --git
>> a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> index 77c408a326db..186e0a0df980 100644
>> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> +++
>> b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> @@ -270,6 +270,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> index 4fa3e2013120..409f31c982d7 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> @@ -1152,6 +1152,7 @@ [Components.IA32]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>> <PcdsFixedAtBuild>
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> index 8adae2e24993..38bd825c8bdc 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> @@ -1167,6 +1167,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com
>> mandsLib.inf
>>
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1
>> CommandsLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>> <PcdsFixedAtBuild>
>> diff --git
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> index fb493973e22d..463234a3d948 100644
>> ---
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> +++
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> @@ -371,6 +371,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> index 9a1f107fafe1..586fa848650f 100644
>> ---
>> a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> +++
>> b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardP
>> kg.dsc
>> @@ -377,6 +377,7 @@ [Components.X64]
>>
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2
>> CommandsLib.inf
>>
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComman
>> dLib.inf
>>
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingL
>> ib.inf
>> +
>> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLi
>> b/BaseOrderedCollectionRedBlackTreeLib.inf
>>
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC
>> ommandLib.inf
>>
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> --
>> 2.19.1.3.g30247aa5d201
>>
>>
>>
>>
>>
>
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution
2021-01-13 8:28 ` [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution Laszlo Ersek
@ 2021-01-18 8:16 ` Laszlo Ersek
0 siblings, 0 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-18 8:16 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Philippe Mathieu-Daudé
On 01/13/21 09:28, Laszlo Ersek wrote:
> Add the resolution for TimeBaseLib, which is now required to build the
> EmbeddedPkg RTC driver.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 471f80ce3cf0..1725e5cad378 100644
> --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -82,6 +82,7 @@ [LibraryClasses.common]
> SemihostLib|ArmPkg/Library/SemihostLib/SemihostLib.inf
>
> RealTimeClockLib|Silicon/TexasInstruments/Omap35xxPkg/Library/RealTimeClockLib/RealTimeClockLib.inf
> + TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf
>
> IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>
>
This patch has been committed with hash 0864b5027085.
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add OrderedCollectionLib class resolution
2021-01-13 8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
2021-01-15 23:34 ` [edk2-devel] " Nate DeSimone
2021-01-18 1:38 ` 回复: " gaoliming
@ 2021-01-18 8:16 ` Laszlo Ersek
2021-01-18 8:18 ` Laszlo Ersek
2 siblings, 1 reply; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-18 8:16 UTC (permalink / raw)
To: devel
Cc: Agyeman Prince, Chasel Chiu, Deepika Kethi Reddy, Jeremy Soller,
Kathappan Esakkithevar, Kelly Steele, Michael D Kinney,
Nate DeSimone, Philippe Mathieu-Daudé, Rangasai V Chaganty,
Yi Qian, Zailiang Sun
On 01/13/21 09:28, Laszlo Ersek wrote:
> The edk2 patch
>
> ShellPkg/ShellCommandLib: add ShellSortFileList
>
> for BZ#3151 will make the
>
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in the Intel platform DSCs consume the above UefiShellCommandLib
> instance, resolve the OrderedCollectionLib class in them.
>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> Cc: Jeremy Soller <jeremy@system76.com>
> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
> 10 files changed, 10 insertions(+)
This patch has been committed with hash d12d9c963ba3.
Thanks,
Laszlo
>
> diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> index 6de834565a7a..775eda4b03bc 100644
> --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
> @@ -378,6 +378,7 @@ [Components.X64]
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> index 862e6a6655a3..c400173f7e0a 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
> @@ -350,6 +350,7 @@ [Components.X64]
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index 0b30da8f9665..d76c220b9145 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -429,6 +429,7 @@ [Components.X64]
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> index 9f64dcb62724..e29c7465b1e4 100644
> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
> @@ -912,6 +912,7 @@ [Components.IA32]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> index db144aab75ae..6fdfba9a58dc 100644
> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
> @@ -639,6 +639,7 @@ [Components.IA32]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> index 77c408a326db..186e0a0df980 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
> @@ -270,6 +270,7 @@ [Components.X64]
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 4fa3e2013120..409f31c982d7 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -1152,6 +1152,7 @@ [Components.IA32]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 8adae2e24993..38bd825c8bdc 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -1167,6 +1167,7 @@ [Components.X64]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> index fb493973e22d..463234a3d948 100644
> --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
> @@ -371,6 +371,7 @@ [Components.X64]
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
> index 9a1f107fafe1..586fa848650f 100644
> --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
> +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
> @@ -377,6 +377,7 @@ [Components.X64]
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 3/3] Intel Platforms: add OrderedCollectionLib class resolution
2021-01-18 8:16 ` Laszlo Ersek
@ 2021-01-18 8:18 ` Laszlo Ersek
0 siblings, 0 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-18 8:18 UTC (permalink / raw)
To: devel
Cc: Agyeman Prince, Chasel Chiu, Deepika Kethi Reddy, Jeremy Soller,
Kathappan Esakkithevar, Kelly Steele, Michael D Kinney,
Nate DeSimone, Philippe Mathieu-Daudé, Rangasai V Chaganty,
Yi Qian, Zailiang Sun
On 01/18/21 09:16, Laszlo Ersek wrote:
> On 01/13/21 09:28, Laszlo Ersek wrote:
>> The edk2 patch
>>
>> ShellPkg/ShellCommandLib: add ShellSortFileList
>>
>> for BZ#3151 will make the
>>
>> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>>
>> instance dependent on the OrderedCollectionLib class. Because the shell
>> binaries in the Intel platform DSCs consume the above UefiShellCommandLib
>> instance, resolve the OrderedCollectionLib class in them.
>>
>> Cc: Agyeman Prince <prince.agyeman@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
>> Cc: Jeremy Soller <jeremy@system76.com>
>> Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
>> Cc: Kelly Steele <kelly.steele@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
>> Cc: Yi Qian <yi.qian@intel.com>
>> Cc: Zailiang Sun <zailiang.sun@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 +
>> Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 +
>> Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
>> Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
>> Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 1 +
>> Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
>> 10 files changed, 10 insertions(+)
>
> This patch has been committed with hash d12d9c963ba3.
I'm sorry -- I did the right thing regarding the master branch in
edk2-platforms, but commented under the wrong patch on the list.
I'm going to submit a new version of patch#3, as suggested by Liming.
Commit d12d9c963ba3 is what patch#2 of this series has become.
Sorry about the confusion,
Laszlo
>>
>> diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
>> index 6de834565a7a..775eda4b03bc 100644
>> --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
>> @@ -378,6 +378,7 @@ [Components.X64]
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> index 862e6a6655a3..c400173f7e0a 100644
>> --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
>> @@ -350,6 +350,7 @@ [Components.X64]
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> index 0b30da8f9665..d76c220b9145 100644
>> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
>> @@ -429,6 +429,7 @@ [Components.X64]
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> index 9f64dcb62724..e29c7465b1e4 100644
>> --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc
>> @@ -912,6 +912,7 @@ [Components.IA32]
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>>
>> diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> index db144aab75ae..6fdfba9a58dc 100644
>> --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc
>> @@ -639,6 +639,7 @@ [Components.IA32]
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>>
>> diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> index 77c408a326db..186e0a0df980 100644
>> --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
>> @@ -270,6 +270,7 @@ [Components.X64]
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> index 4fa3e2013120..409f31c982d7 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>> @@ -1152,6 +1152,7 @@ [Components.IA32]
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> <PcdsFixedAtBuild>
>> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> index 8adae2e24993..38bd825c8bdc 100644
>> --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
>> @@ -1167,6 +1167,7 @@ [Components.X64]
>> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
>> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> <PcdsFixedAtBuild>
>> diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> index fb493973e22d..463234a3d948 100644
>> --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
>> @@ -371,6 +371,7 @@ [Components.X64]
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>> diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
>> index 9a1f107fafe1..586fa848650f 100644
>> --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
>> +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
>> @@ -377,6 +377,7 @@ [Components.X64]
>> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
>> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
>> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>> ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [edk2-devel] [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution
2021-01-13 8:28 ` [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-15 9:27 ` Marcin Wojtas
@ 2021-01-18 8:19 ` Laszlo Ersek
1 sibling, 0 replies; 18+ messages in thread
From: Laszlo Ersek @ 2021-01-18 8:19 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Marcin Wojtas, Meenakshi Aggarwal,
Philippe Mathieu-Daudé, Thomas Abraham, Wenyi Xie
On 01/13/21 09:28, Laszlo Ersek wrote:
> The edk2 patch
>
> ShellPkg/ShellCommandLib: add ShellSortFileList
>
> for BZ#3151 will make the
>
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>
> instance dependent on the OrderedCollectionLib class. Because the shell
> binaries in the ARM silicon and platform DSCs consume the above
> UefiShellCommandLib instance, resolve the OrderedCollectionLib class in
> them.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3151
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 +
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 +
> Silicon/NXP/NxpQoriqLs.dsc.inc | 1 +
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +
> Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 +
> Platform/Hisilicon/D03/D03.dsc | 1 +
> Platform/Hisilicon/HiKey/HiKey.dsc | 1 +
> Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
> Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 +
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 +
> Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 +
> 12 files changed, 12 insertions(+)
Commit d12d9c963ba3.
Thanks,
Laszlo
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> index 274b2a297c3c..fee7cfcc2d40 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> @@ -451,6 +451,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> }
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index e8e730044117..4cdafe8b1f62 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -584,6 +584,7 @@ [Components.common]
> NULL|Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.inf
> NULL|Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
> index 38aa1f22a49d..99a317aba7e6 100644
> --- a/Silicon/NXP/NxpQoriqLs.dsc.inc
> +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
> @@ -86,6 +86,7 @@ [LibraryClasses.common]
> SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 19102b2ef818..05d1b69c833a 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -700,6 +700,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> index 1725e5cad378..c5fc978c5fb7 100644
> --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -482,6 +482,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index d4ec3be24336..5a2441dcd32e 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -502,6 +502,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> !ifdef $(INCLUDE_DP)
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 83c901cf470c..d84462514042 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -286,6 +286,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> index 151c6312f87f..bf9d51e0b73d 100644
> --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc
> +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc
> @@ -265,6 +265,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> <PcdsFixedAtBuild>
> diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> index d787f87c0b86..26bbbb24976b 100644
> --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
> @@ -636,6 +636,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> index 0e6ab83a2495..0a11b796cca5 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> @@ -133,6 +133,7 @@ [LibraryClasses.common.UEFI_APPLICATION]
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> index 95643685e8aa..18accbfd5d89 100644
> --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc
> @@ -193,6 +193,7 @@ [LibraryClasses.common.UEFI_APPLICATION]
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index d5f75cbba5e5..dd45b4142c77 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -633,6 +633,7 @@ [Components.common]
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
>
>
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2021-01-18 8:19 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-13 8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution Laszlo Ersek
2021-01-18 8:16 ` [edk2-devel] " Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-15 9:27 ` Marcin Wojtas
2021-01-18 8:19 ` [edk2-devel] " Laszlo Ersek
2021-01-13 8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
2021-01-15 23:34 ` [edk2-devel] " Nate DeSimone
2021-01-18 1:38 ` 回复: " gaoliming
2021-01-18 7:56 ` Laszlo Ersek
2021-01-18 8:16 ` Laszlo Ersek
2021-01-18 8:18 ` Laszlo Ersek
2021-01-15 8:50 ` [edk2-devel] [edk2-platforms PATCH 0/3] " Laszlo Ersek
2021-01-15 9:22 ` Ard Biesheuvel
2021-01-15 9:35 ` Laszlo Ersek
2021-01-15 22:04 ` Leif Lindholm
2021-01-18 7:41 ` Laszlo Ersek
2021-01-15 9:27 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox