From: "Laszlo Ersek" <lersek@redhat.com>
To: Philippe Mathieu-Daude <philmd@redhat.com>, devel@edk2.groups.io
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 2/2] ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos
Date: Tue, 30 Jul 2019 15:26:30 +0200 [thread overview]
Message-ID: <e2ea06d6-f4c4-061a-7d29-4a5e7a086307@redhat.com> (raw)
In-Reply-To: <20190729180321.1715-3-philmd@redhat.com>
On 07/29/19 20:03, Philippe Mathieu-Daude wrote:
> Fix a pair of trivial typos by inserting a space.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c
> index 3379744aa185..3f88e84372ee 100644
> --- a/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c
> +++ b/ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c
> @@ -87,7 +87,7 @@ PeCoffLoaderRelocateImageExtraAction (
> DEBUG ((EFI_D_LOAD | EFI_D_INFO, "add-symbol-file %a 0x%p\n", DeCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(ImageContext->ImageAddress + ImageContext->SizeOfHeaders)));
> #endif
> #elif __GNUC__
> - // This may not work correctly if you generate PE/COFF directlyas then the Offset would not be required
> + // This may not work correctly if you generate PE/COFF directly as then the Offset would not be required
> DEBUG ((EFI_D_LOAD | EFI_D_INFO, "add-symbol-file %a 0x%p\n", DeCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(ImageContext->ImageAddress + ImageContext->SizeOfHeaders)));
> #else
> DEBUG ((EFI_D_LOAD | EFI_D_INFO, "Loading driver at 0x%11p EntryPoint=0x%11p\n", (VOID *)(UINTN) ImageContext->ImageAddress, FUNCTION_ENTRY_POINT (ImageContext->EntryPoint)));
> @@ -124,7 +124,7 @@ PeCoffLoaderUnloadImageExtraAction (
> // Print out the command for the RVD debugger to load symbols for this image
> DEBUG ((DEBUG_LOAD | DEBUG_INFO, "unload symbols_only %a\n", DeCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp))));
> #elif __GNUC__
> - // This may not work correctly if you generate PE/COFF directlyas then the Offset would not be required
> + // This may not work correctly if you generate PE/COFF directly as then the Offset would not be required
> DEBUG ((DEBUG_LOAD | DEBUG_INFO, "remove-symbol-file %a 0x%08x\n", DeCygwinPathIfNeeded (ImageContext->PdbPointer, Temp, sizeof (Temp)), (UINTN)(ImageContext->ImageAddress + ImageContext->SizeOfHeaders)));
> #else
> DEBUG ((DEBUG_LOAD | DEBUG_INFO, "Unloading %a\n", ImageContext->PdbPointer));
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-07-30 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 18:03 [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors Philippe Mathieu-Daudé
2019-07-29 18:03 ` [PATCH 1/2] " Philippe Mathieu-Daudé
2019-07-30 13:25 ` Laszlo Ersek
2019-07-29 18:03 ` [PATCH 2/2] ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos Philippe Mathieu-Daudé
2019-07-30 13:26 ` Laszlo Ersek [this message]
2019-07-30 14:01 ` [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors Leif Lindholm
2019-07-30 14:07 ` [edk2-devel] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2ea06d6-f4c4-061a-7d29-4a5e7a086307@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox