From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3CEE721160A2E for ; Sun, 7 Oct 2018 23:38:18 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2018 23:38:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,355,1534834800"; d="scan'208";a="79577536" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 07 Oct 2018 23:37:59 -0700 To: Ming Huang , "linaro-uefi@lists.linaro.org" , "edk2-devel@lists.01.org" , "Zeng, Star" , "Dong, Eric" Cc: "huangming23@huawei.com" , "Gao, Liming" , "zhangjinsong2@huawei.com" , "Kinney, Michael D" , "waip23@126.com" , "wanghuiqiang@huawei.com" , "huangdaode@hisilicon.com" References: <20180915063656.6250-1-ming.huang@linaro.org> <20180915063656.6250-2-ming.huang@linaro.org> <734D49CCEBEEF84792F5B80ED585239D5BE4E5E4@SHSMSX104.ccr.corp.intel.com> From: "Ni, Ruiyu" Message-ID: Date: Mon, 8 Oct 2018 14:39:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: [RFC MdeModulePkg/UefiBootManagerLib v1 1/1] MdeModulePkg/UefiBootManagerLib: Fix raid card repair fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 06:38:19 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/28/2018 2:18 PM, Ming Huang wrote: > > > On 9/26/2018 1:00 PM, Ni, Ruiyu wrote: >>> @@ -507,12 +552,13 @@ BmRepairAllControllers ( >>> FormBrowser2, >>> &HiiHandles[Index], >>> 1, >>> - PcdGetPtr (PcdDriverHealthConfigureForm), >>> + &gEfiHiiDriverHealthFormsetGuid, >> >> I still don't quite understand the changes. >> But the above specific change removes the PcdDriverHealthConfigureForm form pop up. >> Instead it pops up each driver health form one by one. >> Why? > > This change is refer to the below function: > ProcessSingleControllerHealth (IntelFrameworkModulePkg/Universal/Bdsdxe/DeviceMngr/DeviceManager.c). > I don't real understand it also, but it works. > I am sorry. I cannot review the changes if you cannot explain it:) Fix should be based on the thoroughly understanding to the issue. >> >>> 0, >>> NULL, >>> NULL >>> ); >>> if (!EFI_ERROR (Status)) { >>> + ShowConfigureForm (FormBrowser2, >>> + InfoConfigurationRequired); >>> break; >>> } >>> } >>> -- >>> 2.18.0 >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > -- Thanks, Ray