From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.1817.1632870662576239922 for ; Tue, 28 Sep 2021 16:11:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=MHzf+L8I; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=090543438a=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18SIqon9028535; Tue, 28 Sep 2021 23:10:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=NqVTnpIYcCflzvLCKgxn+bRv23usTNSsP8QmwNT7YYM=; b=MHzf+L8IngVPu90VO0BM/zge+AU+tAWDjxsf9d35Zh2nQQ/hVyvKr01MB76oHDXnemon 3S99lgAF1xvQWjxTUdAkO7phIK8FQWlFpCmQNEXDRc0TtPwvsSg3Uxrk9SY7AZsWrLMM 2yqr6GrXijtPWISdYyb/0Snm0Vit33QL+P6xp4vYYDx0WdURFrsQPpPnACsZQmFPF+BG sYoyRGXbdX6mOfUz6skL6g2QLVLU2dMTTQz0q7HPkuyl8fWiz1w4G7ueuV0MoHMQdCb+ CUORSIy3aQG80cDSDcohOjSXv+SLSt1AbolgH12HVNcX+eq0qeGYyvyDTM9LBwfsExyn zA== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 3bbv8h8g4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Sep 2021 23:10:44 +0000 Received: from G4W9121.americas.hpqcorp.net (g4w9121.houston.hp.com [16.210.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 83DB77F; Tue, 28 Sep 2021 23:10:43 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 28 Sep 2021 23:10:43 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.241.52.12) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Tue, 28 Sep 2021 23:10:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K1a8msCiYg0G6gqtPrYnHHGbsjbxOI3rkI3yY9OUJaRzZnkIW7gtibhdkZ+ULeJw2hpwes5zw+ydEP2W+4V1lF6l/SLQXUyqkdmyUwVB9AE9mCylMRsgiCB4qxIV2M8u9v0SUXA+ACF4U8tyXfcDspk7oXQ/k57Q9hvPnO2nch9Xze/tt1FatWx6qCHzj5N6OOOqokb85IGZHeR2X8aTusUkW/vBbhb/jdky2vdfvLQi9+LyuTpiMa2+HZDFe03JygWsuqclTvAejx31XiiPAHBIBgU+/dpOBiuI+HlvXE6wpGVkVh5iVS6xVevX5zv/qUKXtnZFP1XKFTOb0Bbrjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NqVTnpIYcCflzvLCKgxn+bRv23usTNSsP8QmwNT7YYM=; b=kVLxom1BVX7DqlcEdS2mIbGeLvaasgRUVS+Od5VPmcE5Ssa/kTnGV4yHgJTIdeFLUFeMFZzwoYM7nHrfxR2yzL8QLqYfunU2JgIGNNocAp7nf7CqXAnHt9laneYeXvgcACHHnrIT4qcyM2J4027mjk0FWxPElQpHzOJOYI53NvDDciw9RUvlqBdkP9X4DG2On9l3uMi2RnPJgHX0I+JaXhBStX7kzWdKGGotzriXRXYQYFwvM8rCgUxnZ4K4OP44ss0NXVDLEb3Vhw+MdA5Hk17NLriGt7Gq50hylEBvedlM0F+z9Ezz2qHcX6EAmC1JBs5QerDstioozneg9iuycA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) by DF4PR8401MB0330.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7605::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.18; Tue, 28 Sep 2021 23:10:42 +0000 Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469]) by DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469%3]) with mapi id 15.20.4544.021; Tue, 28 Sep 2021 23:10:41 +0000 Message-ID: Date: Wed, 29 Sep 2021 07:10:31 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD To: Abner Chang , CC: Michael D Kinney , Liming Gao , Zhiguang Liu , Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Gerd Hoffmann , Sunil V L References: <20210928083107.7418-1-abner.chang@hpe.com> <20210928083107.7418-3-abner.chang@hpe.com> From: "Daniel Schaefer" In-Reply-To: <20210928083107.7418-3-abner.chang@hpe.com> X-ClientProxiedBy: HK2PR04CA0055.apcprd04.prod.outlook.com (2603:1096:202:14::23) To DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) MIME-Version: 1.0 Received: from [192.168.100.176] (123.193.59.220) by HK2PR04CA0055.apcprd04.prod.outlook.com (2603:1096:202:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Tue, 28 Sep 2021 23:10:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9206309-01dc-4a64-d916-08d982d53144 X-MS-TrafficTypeDiagnostic: DF4PR8401MB0330: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: loPIk8v03Srxcib31SpiFPStAPADKuX+XnnoMp4iCfIEz12WQ1QFIlQjypQSagaxPTGZEYTNQBe/rxFfJu1qMPrJtcZqHqTfPI3UmJ1Knrc8stfjYManNoCIouoiWox2l19UciAWdCgZJIuazTxqD4K3IRflrBO6uj1wcvfDo+Eq0UQA0TRCJ3/r7h2HRk6fVLHou05xJkx9lboPAgWODoqHNCi8/98zRfJX88ltnPMagHQnF+F7zAK5LDhVj6dIM9yNuOeVMoOK46BKr29/UhfyeuJiYztZdLX2xYipzECVqEOX4VC+e+47JK8iTfAO3ywUho48Uebt9G6Ep0VujMN4qD//QC2Sb5pET0dFa47IAXBXAQfOAxLDWSqzLz0SHAZfjO0kDqUqvM0mOdbO9IQwzgTDiQdThxnDGGz+Dpa9YEEZJkjIxvkNluuXjuKSikpV98LaURucMTBxmG5ah+VsWVz2vtOUd+olvIO7x1ic+P/MlwYYG+zcA4Gdz03boutxg+VD0ezKCc07hSdXSIcJYNrtdRYVupq3ShKJkY1Dt2PsVS3uVp5x3+PXFJs/JSS5vyYXmGDgavjnM/9J5kAC+XJDkB9xr5eRdaexdUtaFlCRmTKNyY2hmHlhuQhR5EyYWQATWcdSmEtCyBNxVZ5dMKQemxOri8C3NmqCPOA5Gm9jl/0SX7eyif/7WwA9teIC1YniQ39g7dhi5XbWCI2oRCa1i+jyxrKOmSWqM2ElWEawTMXo65exgHCl3SZ5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(6029001)(366004)(36756003)(31686004)(6666004)(8936002)(31696002)(8676002)(86362001)(44832011)(66946007)(66556008)(66476007)(508600001)(26005)(186003)(5660300002)(316002)(38100700002)(16576012)(83380400001)(54906003)(4326008)(2616005)(6486002)(2906002)(53546011)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkNZVUZRcEtDRHcxVzVJZ3pUZzV5UXpHL01xOVQ0V0pMZ1hMUXhEMDFYME9Q?= =?utf-8?B?ZzdiUmJjNmg1c1E1Y3YyUFJDTE9SVlBzeXJOQURmRHQzbElFMXltZmc5UTZ0?= =?utf-8?B?R3RYTmNlblhEbUlJdXdSNzhWUm05TFBTeWxUR0ZqeEI4bStMeEJOWkordk53?= =?utf-8?B?bUpYUk1aQ05lSUxraVlGVnpvY1hRcjlXZEVsVi9TdVo3YnI0cDhMbWRkcGgz?= =?utf-8?B?a0d3c0hFenNrangvQWkwd0JQUERPM1NPRzVZZStRZVFINnlkaTUrMHozQ0ZR?= =?utf-8?B?blNyOFVHVUpPMGNBbjZOQkRxQXhkMllWZFoweFJ2OXNoeHU3MUNWRTQyNGFQ?= =?utf-8?B?ZjFpMWYrdlIrUmhQV053MkVqYlhJRE0zWXBDMGVudmdOdmg1Q2krV3VIQldD?= =?utf-8?B?VXlwVUh0OFMzdTdpbllwRncyc1JmUmVndW5sbFRBQnNaOFJEMlJhdFVDSS9B?= =?utf-8?B?RkV4Uk9nTFBIN0FyVlVwOUhGbzlKV0tITTZFblowdTFDOXF1dC9ISUdHVE9k?= =?utf-8?B?bUJvRThDUU94d3BoYmhFai9uSDE4RjFtVTNoQlc4MWY0SkIvUWo3bzJ2OUxn?= =?utf-8?B?VmZEWUZRNk5oTzZXbFpJdHRIcmN4VG5way9HWkppK3pGMUVyVERzc2NmemRl?= =?utf-8?B?TWNsVytvU0NPMDNJWStqWWtRU3MvTUN1TzVpRFBQOVZROXI4Q3VVUmk0T0JK?= =?utf-8?B?Qlo1eEVGSkNIeHowb1FCTDZBeVptTTVlSGJjUkhRUXhRcEdvSkU2KzZ5cm43?= =?utf-8?B?cjlhOG5nOHVTbkVCWUJrdC9wV085TGwxcmwxcFdiTzZ1endmMGhvdlRxUmNi?= =?utf-8?B?YUI4VkRrQUZueVBiQWttUGhwc2QycmFqS0Z3aHJJd1NVR1lQWE1jVGQzeWZn?= =?utf-8?B?RHJUTndqL0M3bys0R0VreHkzQWFLT29FMXdsOGhwMEdNZmwvV2dwbE43T1dO?= =?utf-8?B?U3hJVnQyN0MyaURla1g1R3pzS3ZPUU1nbGpqZEd5NURXRkY1RWJGampOeXJW?= =?utf-8?B?N2dBWlcxQllnNHc5OWtJODZzSHhlcjA4Yi83eDNBbVdrZ20xaGhSK0EwaGNH?= =?utf-8?B?MnJqNTMwRkpkTVpqRUlvREtMSTRTclRPMEYzRFdad29Bb1pYc2p6ODVjM0NG?= =?utf-8?B?Q2s0bEI1V0Jha1N3SWNoWiswM25qalA3RlRWVHFQeVRRQVdOVDlTNFlwL3cx?= =?utf-8?B?QlB6VHFmM3FGWTBrWE95QUNtOFo3M0hnYmZ0TW1QbXlGR2NPYTI1Y3ZNRXZy?= =?utf-8?B?SVh2R3hUbVkyazJUcE5YdzRudlAvd1R1YUkrV3lucGlPNWkyT2lVcjRZdjR6?= =?utf-8?B?Z3c0Rm5ucG96Njc4d1ZHL1cvK3ZWQUEyMk5FODR4NDNOdWQ3NU9KRTdtbnRD?= =?utf-8?B?LzJVOXpyb2JZSGlHRXN3TXpiSzlER25iNWNHYzBpV3VsTHpoVlorbGVQbGpZ?= =?utf-8?B?QkV1Q2FsWHZLdGNSZm40SXUvTFBWYmh1dmVWRFRCSVQwVlJCNTVHTDBHWGVD?= =?utf-8?B?THlpeGd1K2lYdXhYeUNmQ014VXNMbjRmbGpoYmNLZ09wa1MvSWJpdlFsTUxI?= =?utf-8?B?SDRUY1RCenhyVkFpdWk3ZmgwZE8wc3huV3FmRWVJcFJ5TWdqTVhRbWN6VDhE?= =?utf-8?B?enAvd2Q1NjJnUXhMcHZydFFpdFk0MkhQblpNNnpxbGd0Q0VmRG9Eck5hcDBJ?= =?utf-8?B?TWpjL0NxcDZNRE1aN25wTHBJZG84dXpYQlFxRDF3c0xHTGVDakpKZ1JFQUJ5?= =?utf-8?Q?VCTO3dsFhLyaH2XC4U8DdKGqsOmhP9jPYU8tBsV?= X-MS-Exchange-CrossTenant-Network-Message-Id: a9206309-01dc-4a64-d916-08d982d53144 X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 23:10:41.9014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5cI98qaKAaSm+m3U2ULQ+1QT7NmGXkUaM8ifVlWC0Nzy4xqJVobWqdtc9vdSdG919105FpOXz/+eFIbK1ScCoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0330 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: gl7VyccHqH1WR9Hr9XBBLeiEVKl8htCv X-Proofpoint-GUID: gl7VyccHqH1WR9Hr9XBBLeiEVKl8htCv X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-28_10,2021-09-28_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 clxscore=1011 mlxscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109280135 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit I think it would make sense to combine this patch with 3/9 ArmPkg: Use PcdPciIoTranslation PCD from MdePkg It's pointless by itself. On 9/28/21 16:31, Abner Chang wrote: > This PCD is moved from ArmPkg that is used to set the base address > of PCI MMIO window that provides I/O access. We relocate this PCD > because this PCD is common to ARM and RSIC-V arch. > > Signed-off-by: Abner Chang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Cc: Daniel Schaefer > Cc: Sunil V L > --- > MdePkg/MdePkg.dec | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index a28a2daaff..08d259764a 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -2302,6 +2302,10 @@ > # @Prompt PCI Express Base Address. > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000|UINT64|0x0000000a > > + ## This value is used to set the base address of PCI MMIO window that provides I/O access. > + # @Prompt PCI I/O Memory Map Window Base Address. > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0|UINT64|0x00000040 > + > ## This value is used to set the size of PCI express hierarchy. The default is 256 MB. > # @Prompt PCI Express Base Size. > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x10000000|UINT64|0x0000000f >