From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9D9BED800EA for ; Mon, 20 Nov 2023 12:22:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DXPYOaCyK9oYK+7e58GvhUqY9mT83eYOXS2N+5zBFBI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700482966; v=1; b=G+eANJ+3S9V3ME/Sw/Sh55GWGUlcPgT4wEHHh+2V9AzvMb4nbGCFlWk9iCA2lBYDhRDhcmZG lrTIOL1d/LKr5uswS6d53LDriHt1V8eyQNQwY1UJTHOjvZPfJ5KSDQTVFffSarlzTvdj/E9c5/s iw1tO1r5h7ywYcV0q6ea2jFY= X-Received: by 127.0.0.2 with SMTP id IWQ9YY7687511xEgwczLTZ0m; Mon, 20 Nov 2023 04:22:46 -0800 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.69]) by mx.groups.io with SMTP id smtpd.web11.48886.1700482964867443015 for ; Mon, 20 Nov 2023 04:22:45 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=V5J32LTD16VCGqAiZ/CAyt4kp5f8zjtP7M/lXriu1hurlOr9xzroA07siUCWC+PoSTjeydAYHnqyYf2/3+t/AFm5Ts01iOzKrO2+oscvXWlxVgI1c+tz42cD63lxw25WgeyiZBd0+WEGsT/+Ku1M9wWwLevHJdSlXl3gNZ9Jo2qTb9Uu7bIi4gTipCnN2PHQwG7b+uWYVANypzB4H4DLucppFxd42wP9U+oXY6ITrr3NHw94oXaygHuRf0S5FxjsPeRXRYibOMFeY+Rx2kjxplbIY3ZsdWeQEpGqJiyI9C3bjVJvRB2VZxTUmov68LgGCfv5tUQ6SsMePBgBaGdzWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JbP9CWLMCAxdi0Uznettoi4er1EGFvJb8i3KigGEAI0=; b=jAK4FrEm9hrC3pwNIWd+WM4TriEe20VDKLwREXVCmbGIc4rQ6WJf5Va42b34SmZJxsiDJah/JiBxlfT/PMyLAMabxcbkowKREMQvAm1Omdvti+/n9hWiy9VRmE/ORzNjcc335oxyyJkerULElEHvF+Yzs0AjuBKstHkO1Ne9hhUrRmMoBIwt45ahUQ02JgUsse44Adb5omH6cVnNXd5w2+39xKzhypgAK1Ud9qiBZLOrMH6AVlMlKMaZNmtQMmoV+UpIW4UWuMQBG/DFVnUOQEa8VJD7I1JvcJwIwrKleelKk1fbw+qWgIJW65udR6p6XH3wfua2C6x6oRRezVir4Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DB7PR03CA0108.eurprd03.prod.outlook.com (2603:10a6:10:72::49) by DB9PR08MB8508.eurprd08.prod.outlook.com (2603:10a6:10:3d3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26; Mon, 20 Nov 2023 12:22:36 +0000 X-Received: from DU2PEPF0001E9C1.eurprd03.prod.outlook.com (2603:10a6:10:72:cafe::fd) by DB7PR03CA0108.outlook.office365.com (2603:10a6:10:72::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26 via Frontend Transport; Mon, 20 Nov 2023 12:22:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF0001E9C1.mail.protection.outlook.com (10.167.8.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.12 via Frontend Transport; Mon, 20 Nov 2023 12:22:35 +0000 X-Received: ("Tessian outbound 26ee1d40577c:v228"); Mon, 20 Nov 2023 12:22:35 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: de60cb8fc42923fc X-CR-MTA-TID: 64aa7808 X-Received: from e5eba444961b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 160F94A8-6B15-422C-B26A-887F4E65D84C.1; Mon, 20 Nov 2023 12:22:28 +0000 X-Received: from EUR02-AM0-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e5eba444961b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Nov 2023 12:22:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=laLFUc+wf22LdtFobqDMPpBq0qkejrZNUJQt9/pqWMrAW9dy0uJFt6hIzvSFKSghA9ni9X/v0mJiF8Aw4AIavxfw/Lyc//rLsLKOoGVWKk9FIsZZxNLHb/I+o+1UYttxJ4SBUUQ/G+IglxPP93ZDZhpa3vU8uZgCD6VRgkZ1lQz6xKuq4LVFKlfJh3XmEk5xJcKbI65HMKlGs4UlwuqCyxHQSdnKlNoErNzmY0G+A4/6SKzWbsFq4A3+vV76UL6BtY8xoWM97rXhf+RvWxRVffdAnd+F+6++BOgWB6MiCG1yFWd04cZjczrivlIwhQYaKLWbUwWiwD4RC9HKjUH3Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JbP9CWLMCAxdi0Uznettoi4er1EGFvJb8i3KigGEAI0=; b=VSpwSI2MWToJv8rM+B9u6GKgX0Cet+ue7WJ8KppjwMtO4C/tCnBKrLBxGWmeRhAYPJ/ICjxzpsnBMTu2pfVBmMEXG7jxvk8SpXmGrMUYk/ncuDCds0564NRB4EupgpqvRaDxYDTW+L4tuZOFtDIqNCL8A3oQ9kxtAPVtqqFm8Y2XVIB0db+Eq3eAovjpau9Pzpz+cCrYW8Xz+1Xjdi+4eCW3GOJlMSUiZgmZw9YtBga0ispDowXgiLHg6q9s3BL0jyhfCgrF5/faSYDxV1ZA4IIVXux8LZb0lJz3wmRIZ/JpMGGu4vziCr//IFzib1o435Vwlzh+Wzq9vLXclueeSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by VE1PR08MB5725.eurprd08.prod.outlook.com (2603:10a6:800:1b0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.27; Mon, 20 Nov 2023 12:22:24 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7002.027; Mon, 20 Nov 2023 12:22:24 +0000 Message-ID: Date: Mon, 20 Nov 2023 12:22:21 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation To: Ashish Singhal , devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, jbrasen@nvidia.com, "nd@arm.com" , lersek@redhat.com References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> From: "Sami Mujawar" In-Reply-To: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> X-ClientProxiedBy: LO4P123CA0043.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::12) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|VE1PR08MB5725:EE_|DU2PEPF0001E9C1:EE_|DB9PR08MB8508:EE_ X-MS-Office365-Filtering-Correlation-Id: e944e674-25d0-4c1a-784f-08dbe9c36101 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HoTX3Om9Y3ckgLthj6Xrlwtwd1OPZ7hhuaCj30Sw2u6cgyPEyE3PKBl2qyopz15yzG1Ubhyj9mOzCVnzQgLoSQFFl14RK2R4kvZgEpfAr4qfkjZDTf7fa+kcXvez+uBzGCFqX9odWzbsyFiOAwWOV0LXVnD2u75VjiM1gNjfcSWRiPdMScEDQxam7ZauKQnI9lSitzxFyuZc1QCYeM55WTnMH+4EuUrusUxvF0dULCyNNzhlHxtMY6AGD+3MFXwOHW96gKekg6r9zujw31C/EFXxHRTGLM8zgwYNET2Bhy6/S161ZzKR+FKjgcZsKbjKqKixSooHEn/IVMEkjgYd33jWTIo46RRs7FECmsI/YwaEc4fZBccYLVe3yRaxOdmVXjmgyHHFSq6jov+E1YPPswuGPj7Is3TtMCjlLpGkPbgwPPtRaG93iFGmjxTzGbBZUnnDzlAXa9FSMrB3VdUZ1gadqNTWCzJE6zNSk5VOXOTG7zNAi62ukZeHEG4XdiJd0AdwMBab5s/YNV1h/qwchIoL7f9VaPVwweldjZBLv36ZxaTIjOJcog6Af0g2qHnw3ynnSYqWNA3jY1QyHojsbc4xpqvyhch2bTTuiWurvqgohCcl+48+3XWi6TPQv1nRv/duxKRrNclGU14gXej7tA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(366004)(376002)(396003)(39850400004)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(6512007)(478600001)(6486002)(26005)(2616005)(53546011)(66556008)(66946007)(66476007)(31686004)(316002)(6666004)(38100700002)(6506007)(110136005)(83380400001)(8676002)(8936002)(2906002)(31696002)(44832011)(86362001)(5660300002)(41300700001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5725 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF0001E9C1.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1857642d-f34d-4b8f-fce0-08dbe9c359e4 X-Microsoft-Antispam-Message-Info: YIITC0E3O5TINuhxG6OiNthkJ6gYd7t+h1lE+xIvCVDW4llXDP7Ib/XMTKdUHB+yOnKKxJAk2x/M915BETKT4TbvJzt+5MwmIWoxCfZqg70SdZAQU2AiGugI+Jbh1bA/6nBaN3YBP3HsSwdea/E9YsFn3bM9AL1A5C2nnb9a2qA0gAIvPAPJ9Hj4jJBLpDONFxDQXwC+LOtK8vVwWncyh271YGjD5rZ3Clo0xnSVYmlVr0kGAdNfhK8NpsA6ujXUsXRzUmGcHRmVWKDL5a0YYKbgcTPEY45xPCPu5pGEjF9DgwuF4BywIyhzsl0lfoCE9Q4aDtuljx1s+FOnLRsa58QJBkASYhu+b4ljl3rpIWO/CuBr6yJqivkLUH978x06vpMAkbT2U9nndAS7XM3kp3/j2i+hVK8tnUN4G2CxV4puQXrvukc2oKEOiHUf7CjOj+N5OUY5ThRF17TZDYRE08msQMoezjkF/83tD4vstfgSFId+ll9Ikv9knjP7IGF1AOhDCqr6N8nM1BLb7T92iq1mQMnFX9THJ3TBmuwtjTU4pcp1dcIeYmaNRFW/ZHRgRX83gymc5UJxI2NSfxj0puP8BhGa2Yg7h4Ukl6ICUcIFNxudJ8tEUZ48ThZS22wOvgZUx4FiF5gDILvfKH1xoZzVG87ZNAHOC/yqO6QrfO9D3tpuydJn6goocTOVbDUwzP1X3Z9BASsRZoA6BeyAELjQSuFF+mYPofhh08PoZPuL9dzjQn2nGfgAH12ueO2y/mD2YtKAl6fUpBgS+5ksPA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 12:22:35.8437 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e944e674-25d0-4c1a-784f-08dbe9c36101 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF0001E9C1.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8508 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TZGwxlOpEE9czxFqEbCI2f4ex7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=G+eANJ+3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Ashish, Thank you for this fix. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 15/11/2023 03:19 am, Ashish Singhal wrote: > Just like CPU _UID, ETE UID also needs to be unique so > use AcpiProcessorUid instead of CpuName > > Signed-off-by: Ashish Singhal > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/= SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuT= opologyLibArm/SsdtCpuTopologyGenerator.c > index 8228c7845a..724f33c660 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > @@ -359,6 +359,7 @@ CreateAmlCpcNode ( > > @param [in] Generator The SSDT Cpu Topology generator. > @param [in] ParentNode Parent node to attach the Cpu node to. > + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the n= ode. > @param [in] CpuName Value used to generate the node name. > @param [out] EtNodePtr If not NULL, return the created Cpu node. > > @@ -372,6 +373,7 @@ EFIAPI > CreateAmlEtd ( > IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, > IN AML_NODE_HANDLE ParentNode, > + IN CM_ARM_GICC_INFO *GicCInfo, > IN UINT32 CpuName, > OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL > ) > @@ -397,7 +399,7 @@ CreateAmlEtd ( > > Status =3D AmlCodeGenNameInteger ( > "_UID", > - CpuName, > + GicCInfo->AcpiProcessorUid, > EtNode, > NULL > ); > @@ -474,6 +476,7 @@ CreateAmlEtNode ( > Status =3D CreateAmlEtd ( > Generator, > Node, > + GicCInfo, > CpuName, > NULL > ); IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111469): https://edk2.groups.io/g/devel/message/111469 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-