From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.10090.1589196525729724322 for ; Mon, 11 May 2020 04:28:45 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5360D1FB; Mon, 11 May 2020 04:28:45 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0DEF93F305; Mon, 11 May 2020 04:28:43 -0700 (PDT) Subject: Re: [edk2-platforms][PATCH 0/2] RPi - add DT-only mode To: Andrei Warkentin , devel@edk2.groups.io Cc: leif@nuviainc.com, pete@akeo.ie, philmd@redhat.com References: <20200510213450.12642-1-andrey.warkentin@gmail.com> From: "Ard Biesheuvel" Message-ID: Date: Mon, 11 May 2020 13:28:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200510213450.12642-1-andrey.warkentin@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/10/20 11:34 PM, Andrei Warkentin wrote: > Today the Pies can be booted in a way where only ACPI is exposed, > or both ACPI and DT are exposed. > > This patch set adds one more mode - DT only, no ACPI. The target > audience is developers. When both are exposed, it's up to the OS > to decide which gets used, and that choice can differ between OSes. > > Note: this does _not_ change defaults. Pi 3 still defaults to > ACPI + DT, while Pi 4 still defaults to ACPI only. > > We don't really want to remove DT + ACPI mode - it is the default > on Pi 3, and removing it is bound to just annoy users - WoA and > NetBSD (voa UEFI) on Pi 3 only work with ACPI, while everything > else (Linux, FreeBSD) only work with DT. I'd make an analogy of > MPS and ACPI being exposed for the longest time ever together on > PCs. > > Andrei Warkentin (2): > RPi: move varstore structure defs to ConfigVars.h > RPi: allow selecting DT-only mode > Pushed as 51da3c318e3d..d492639638ee (with Pete's R-b and his remark addressed) Thanks! > .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 21 ++- > .../Drivers/ConfigDxe/ConfigDxe.inf | 2 +- > .../Drivers/ConfigDxe/ConfigDxeHii.uni | 9 +- > .../Drivers/ConfigDxe/ConfigDxeHii.vfr | 146 ++---------------- > Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c | 6 +- > .../RaspberryPi/Drivers/FdtDxe/FdtDxe.inf | 2 +- > Platform/RaspberryPi/Include/ConfigVars.h | 131 ++++++++++++++++ > Platform/RaspberryPi/RPi3/RPi3.dsc | 8 +- > Platform/RaspberryPi/RPi4/RPi4.dsc | 8 +- > Platform/RaspberryPi/RaspberryPi.dec | 2 +- > 10 files changed, 180 insertions(+), 155 deletions(-) > create mode 100644 Platform/RaspberryPi/Include/ConfigVars.h >