From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6FE4B7803D1 for ; Mon, 25 Sep 2023 17:17:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QPL/8buwQENTz8lNdue9vwUt7ebk4QbTlKrDAP0YNCw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695662230; v=1; b=DWfieqGouqT65AVtvPpzQpLR0JqrvWj0c918Sn3R68CgK8l/xBzdxmN+qE5tKdsgRnq2TM/7 f3SaNh5TX+wn1FLumhMoK2dUd7y407ApV/YjGA4Yn4685IJXlxjGj0R32lCJyaVWl0bqafdfKzw 2tEgHl6W9Kl0wTc4+ZNJDFKQ= X-Received: by 127.0.0.2 with SMTP id 9UHYYY7687511xTD7yPRTGl0; Mon, 25 Sep 2023 10:17:10 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.110]) by mx.groups.io with SMTP id smtpd.web10.66830.1695662228924717984 for ; Mon, 25 Sep 2023 10:17:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=al2FBmDkc+9K88guXZJ8McUiMJfvBp4DKgDUOOSYJ3Yj8Pd8fxts5jgVgAnLdKFcUjMlkdkmUYo3JG1tc3N0VabnKcHUrqlLeCYPji6nUcZ7hBZ3aI9tPvBy1k4ErkSZFEd5xtdpFXY/iL2gP/UGkUSAV79yflsfWrosh7/hWwT2EwUqWRvzf90w0z02deYy8fiReLYk53wtSTQqpvi+y4dMI0jiukwLCmm2Mb9r78zEh/L2RJPYUAQR9pRqmubughlmDK/7TfHmVkl13hmGrgPDV3qCd+PhUz5FUQM3irwFF5AoevxvPE4+whFBao6wqlbFHWbEpNNWVdEBZ/GPng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iuvr7FN1iQ/HR8Zi8eKGmy+yxx0oheXLDWxUGC374W4=; b=k+tWjv1C2z8HkXc42zNIVi5DXF2xOBYINqNvn3qfh7+yoTzJNOSvY+xWPQx8rtJJ6/7Oa3a+ZJD/4xOm99txAfWVDMGt90lKSbCaGI+EOdq5QoMgsoeYZTxTd6BVL9O1kWB5+6Wf72msjj5WnCAHiuYSty5GmgWIAexMjg65LN7S66SWS61X4WszHE1WiSQCAHXRhOFL7W5Ip/Kp5W/3iCfquN8740HgftNsQESiujKI+ZRFZAOJ9WjAmuiiSaw/H7OKfB2OFTL7UOo4G+pgrtGAirIrIhMpu0b7bkgstek5JiyG7Uc083hMlw2QgRkp7qHhKTCf4s8+ltC+sA2GLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by PH7PR01MB7629.prod.exchangelabs.com (2603:10b6:510:1d1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.23; Mon, 25 Sep 2023 17:16:58 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::c4f1:5794:f1e6:5fdd]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::c4f1:5794:f1e6:5fdd%4]) with mapi id 15.20.6813.027; Mon, 25 Sep 2023 17:16:58 +0000 Message-ID: Date: Mon, 25 Sep 2023 11:16:51 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Maybe it is time to update code style? To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org References: From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: CH0PR13CA0018.namprd13.prod.outlook.com (2603:10b6:610:b1::23) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|PH7PR01MB7629:EE_ X-MS-Office365-Filtering-Correlation-Id: e08e49a0-3528-417a-317e-08dbbdeb3983 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: cGH4CQ9lVGueZrPJqkh2+Ak+umQeXrVDdUTGv4/ctOkV4JtrGxCYeSHN5TrSBGyLbrYY/8gX5N/4w5tvY6mCUIAcVajtQvhhDOwYTqqFK3/Tx5Tuw06ikVcI0ItdVhuF1LJpRrUZd88uhoqDMrSjyNo5ALNiZNjsK5YPD2YcG/hZXq46YPoCq6wEW5N3ZM8UcolVYx4Xhx0ZKUfkHWVcJzFkCCc4spLC04EAF/v3pmhPYj/rTZsdd/DJb8QcDIrVmbnlqemeejEn3iymgAOUFBuoyKOKZgK85Yk8qO9oVmrPal+aozPxY4BMpHIyIl0PmvTpS8pM9u9gqWuVndutteR37YnNBMDaBuVR6yQ8DMB5C6U9vGCNtHOgJ5kLx3JyRtbDhgeF6w6/zm1Ds9GZ2nIPia0JRWOh2a54fpQSHs0os0/o9WX9TOoRXzEapQvR8bdzaCUo3+cgOKdI82hChk1rR0PNaNpnZ/cmtWxs3AJuO5aSoyAyOA+xHoq/TW4kQWriXfESYS1/E+Q96vJtDSqKd/sITTCI3+QSV+Xv2ReJ60HtG+s8rNDTOEoHpAY60UtxxNysFnD3XTkQcB/8Fj9wlBlngLC7Udc+nkzeybI= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TldyYXUyK1dVMnlRRXdpQU10TVJNUGZwcWZmKzgxaEhLVld3UjZna2plcVZk?= =?utf-8?B?NEdRRE5Mb1RaMVBxYkplb3BLUC8zR3IwSkxFdERqaFNkeWZ3a0tyUkpaRlB1?= =?utf-8?B?SXU5b285VmtWVmp6c0VnOXF2RmlEUVFzVTRnN0dRa29XcnVqTkhGdWc5dVpU?= =?utf-8?B?QnJtWWh1YnpSZjN6Z3dENWV4aXVXVVdlNVZkSVdUYmFyWmxWTmdpV2RMSUdF?= =?utf-8?B?WnB2dU1Lem9sMkZ2Sm5zRm9NbTBaQTk5eEpsOGp4S3dhajdWSjdJNWlZT0hs?= =?utf-8?B?NndpdWNjaWZYNzZmNTZ4UTR4L0ZYR2wvSEF6Z1VwZnBNaUtmeldNeXYwb0J3?= =?utf-8?B?aEtjTlFQbFNaTFJSeDJxVU9CS1llQVNuZDljSSt5Y3FkaTlXYUVKZThQNkJ5?= =?utf-8?B?QWppVnU1OUprM2tqeW4zQUtDemU2T0xWRnJkMnQ2U1pOdDJmRU9qNmRmSk1X?= =?utf-8?B?UVZweVNueHZnQ05VSWtMK0xOQ216N3VHWFhrZnN5TzNXTDhYVElCM0M4bjZu?= =?utf-8?B?Qm0ySldMS2I0TzBSUE5sWURXYmlNRk1UUE9HcG5mdXgxcm9XNTlDVEVKUE5Z?= =?utf-8?B?MkVaWW1kenJtTjNwc2ZTY1Z6c2xTL2w0YmRPNWpkUUo1SU9DMk5HOW1GNERG?= =?utf-8?B?Yi9WUDlDM0g4OUZwRi9FaGtNK1FDelh0dWsrNFNmdFY1SGVrcFBGQTRYRFgy?= =?utf-8?B?UFd0enhUeklkb0s0N3NncWFZRzFDTjEreDR3UE9WZE1ucHljL1VtRDFPS2hl?= =?utf-8?B?a3BqTTF0M2JKNDVoeGJKNXI4MGg0VDFHeXVlamZWWDV2SUlsaHo4YnZaWTN1?= =?utf-8?B?QzNFYzRHcHduckp5aDZoSU81eW9sWVYwUUQ5Z3hNcXlsakxyNmlDRDNUTzFE?= =?utf-8?B?WmxJYzU0bllGRVpBVjBjdnBOM2ZVdkcreGh1NWljREdYYkVoVWt3M2VaNno2?= =?utf-8?B?cElEdXBraEhUVVNpTlhPOUl6MlFSNE5qcjhCTGtyenNyUTJOTDBFbnU1c3pq?= =?utf-8?B?M0lPZm1QQ09TK2JGajZYNjhlbyt3UnIzUHFSeFhzRHJDVXhkK3JQREtmZWhO?= =?utf-8?B?OW83ZGMvanloNHRYamNDK0hObnJMR285L1dEWFFVdXk5WjRMOEJHQnIrRjRO?= =?utf-8?B?Y2lMNjJFeUM5S0gzZTlVaVlZbjk4WkRJSXpGU3BMQ0NyQUZjd052Q2dvUUxm?= =?utf-8?B?OXBGUlFLUVFzc3lMMlh3MUhvN1RvRlRkNHpSelUrdk9uWUJtZnNpYkdkK2RY?= =?utf-8?B?RGJLeEpYbWZNZlpBZ3FldTRlSkxLNXZQSTRNQUtMTUhpTWRWNUErRERaV2Fw?= =?utf-8?B?THBDSmZTSWhFSVhwNi9PL0pqN2N6MkxXV1dRRFo3MnpoaFJBa1NkOEY4MzNo?= =?utf-8?B?Z3ZqZm4zYUYvR1pHZzE1TGVlMTlSdzRFZ3JCR21JaTdSU2pQVHZiVmFUTThh?= =?utf-8?B?aHo3U1dKcC9FN25YU25xT3dDNVZFYnZJbnI5R29QRXlOZ1lCTS9TVjJ3WlNm?= =?utf-8?B?S2R4cFh3cXBEaUp5VXFtNWFEWHo4dFdWQy9mSjI2WUtMZytQNHJjNFA2cHI2?= =?utf-8?B?amNWZXdRQS9DUXdYem9OSE16aG4zUFRWbDdaLzlJYythbGVtSlV2Tkw0MlRI?= =?utf-8?B?bTdSQ2tuTCtYQnpna3pjUUsxd3c0WVY1Q3FGVnBWUG5DdHRQY3QwK0I2Y25p?= =?utf-8?B?RFRxUllidy94YzFvaWlMNFpjZ0Zjd1V1N2dTTGFCMk9ZeGxoVXFRK3hqREU4?= =?utf-8?B?Q0pucS81VDFUOE5Mb0c0cVRVOTR5MHVrWlNtd0wzVHhOUU5zdGJrb2JLYkF3?= =?utf-8?B?bmFkSnJkTmpPNzRlcDQybzYycXVhQnMvZThQcEJNb05Wc3RzMWNyQ240WnZM?= =?utf-8?B?Uzc0Q3dSVTBsYkJnUTY3NlV6MVZEUGs1QVZST0JOeGkvUlR3b3ZvNXlieXVo?= =?utf-8?B?bFFtdG56U3VQUVBXeXo4aWNSWm5lRC85ckl1UXZ6cnlZN0luY0pLaE05OWEy?= =?utf-8?B?OGU1WkdjZDhoaFBxU3NDcWR4d09McmtLOXBOOEFhblFLWFNydDdHSVUxa3Fi?= =?utf-8?B?YTNMcFdQOVk4V3J1MjhHdEhFVFNaY0ZiQ212b3c0Tjh6a01mN3J0SUZ1WVpp?= =?utf-8?B?b0dXREtnTjV0UU9Tdm9tQkVyTTA4cHpSeWNYaWd4MU9EazRlN2lxYlY3MWNp?= =?utf-8?Q?d1KFv5OL4yNvpxvVTli1GgI=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: e08e49a0-3528-417a-317e-08dbbdeb3983 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 17:16:58.4185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8TTsqvQtFwYaLaUXUjWE8H+9i+hqRUxus8elFXbRW3B0VY9btNHRrTWPEY7E1HtD42WZaFcizjL6ID2nfCkO+aPFktCv2U9E7yNs9VxaW5ySzUIQMKm+NCYgwUQovluf X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR01MB7629 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pX0HKwNPUaTibeW4tuD7H8Vmx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DWfieqGo; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 9/25/2023 3:03 AM, Marcin Juszkiewicz via groups.io wrote: > I feel sick each time I have to edit EDK2 code. >=20 > All those INF, DEC, DSC, FDF, XYZ files are something I do not even try > to understand, just got minimal knowledge what goes where by asking Leif > (thanks a lot!) and observing build error messages. >=20 > I got used to UINTN and other weird variable types. No idea where from > they came from (MS Windows?) Given that people at Intel/Microsoft are still adding code with the=20 Windows NT style function documentation, I suspect there will be quite a=20 resistance to changing things. For example, the following was added in 2019: EFI_STATUS GetSelfTest ( ... ) /*++ Routine Description: Execute the Get Self Test ... Arguments: IpmiInstance - Data structure... Returns: EFI_SUCCESS - BMC Self test results... --*/ { EFI_STATUS Status; Vincent provided the following explanation on Twitter: "It's from MS, namley the coding style used in Windows NT=20 https://computernewb.com/~lily/files/Documents/NTDesignWorkbook/coding.pdf= =20 . Ken Reneris wrote the original EFI sample at Intel after working=20 having worked on various parts of NT, including the HAL, at MS. He=20 brought that coding style with him to Intel." --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109047): https://edk2.groups.io/g/devel/message/109047 Mute This Topic: https://groups.io/mt/101570674/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-