From: rebecca@bluestop.org
To: devel@edk2.groups.io, liming.gao@intel.com, "Feng,
Bob C" <bob.c.feng@intel.com>,
"Fan, ZhijuX" <zhijux.fan@intel.com>
Subject: Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3
Date: Fri, 28 Jun 2019 09:30:15 -0600 [thread overview]
Message-ID: <e348ee6d-ec0d-76ee-712f-26e2feb9a0cd@bluestop.org> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48F1D3@SHSMSX104.ccr.corp.intel.com>
On 6/28/19 2:04 AM, Liming Gao wrote:
> The change is good. Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> I suggest you run this script in Linux and double confirm.
I've tested it on openSUSE Tumbleweed 20190626 and verified it still
works, by building OVMF.
I tested both with and without PYTHON3_ENABLE=TRUE set.
--
Rebecca Cran
next prev parent reply other threads:[~2019-06-28 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 16:54 [PATCH] Fix indentation in edksetup.sh SetupPython3 rebecca
2019-06-27 7:37 ` [edk2-devel] " Liming Gao
2019-06-27 13:05 ` rebecca
2019-06-28 8:04 ` Liming Gao
2019-06-28 15:30 ` rebecca [this message]
2019-07-01 3:58 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e348ee6d-ec0d-76ee-712f-26e2feb9a0cd@bluestop.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox