From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: bluestop.org, ip: 65.103.231.193, mailfrom: rebecca@bluestop.org)
Received: from muon.bluestop.org (muon.bluestop.org [65.103.231.193])
 by groups.io with SMTP; Fri, 28 Jun 2019 08:30:17 -0700
Received: from muon.bluestop.org (localhost [127.0.0.1])
	by muon.bluestop.org (Postfix) with ESMTP id 00A835D851;
	Fri, 28 Jun 2019 09:30:17 -0600 (MDT)
Received: from muon.bluestop.org ([127.0.0.1])
	by muon.bluestop.org (muon.bluestop.org [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id ozMmryQPoOfv; Fri, 28 Jun 2019 09:30:16 -0600 (MDT)
Received: from [10.0.10.120] (unknown [10.0.10.120])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by muon.bluestop.org (Postfix) with ESMTPSA;
	Fri, 28 Jun 2019 09:30:16 -0600 (MDT)
Subject: Re: [edk2-devel] [PATCH] Fix indentation in edksetup.sh SetupPython3
To: devel@edk2.groups.io, liming.gao@intel.com,
 "Feng, Bob C" <bob.c.feng@intel.com>, "Fan, ZhijuX" <zhijux.fan@intel.com>
References: <20190626165456.63388-1-rebecca@bluestop.org>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14E48E3D7@SHSMSX104.ccr.corp.intel.com>
 <8c8cf830-a60b-ad67-0ad4-481df423d7df@bluestop.org>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14E48F1D3@SHSMSX104.ccr.corp.intel.com>
From: rebecca@bluestop.org
Message-ID: <e348ee6d-ec0d-76ee-712f-26e2feb9a0cd@bluestop.org>
Date: Fri, 28 Jun 2019 09:30:15 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E48F1D3@SHSMSX104.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US

On 6/28/19 2:04 AM, Liming Gao wrote:
> The change is good. Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> I suggest you run this script in Linux and double confirm.


I've tested it on openSUSE Tumbleweed 20190626 and verified it still 
works, by building OVMF.

I tested both with and without PYTHON3_ENABLE=TRUE set.


-- 

Rebecca Cran