* [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method
@ 2020-05-25 18:24 Ard Biesheuvel
2020-05-26 20:49 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2020-05-25 18:24 UTC (permalink / raw)
To: devel; +Cc: leif, Ard Biesheuvel
The _EVT method on the ACPI0013 Generic Event device takes a single
argument. Even though we are not interested in its value (given that
there is only one interrupt source), we still have to declare the
prototype correctly, or the OS might complain and refuse to call it.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
index 0ea8ce6d5f44..50f1753c3565 100644
--- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
+++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
@@ -226,7 +226,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
MASK = 0xfffffeff
}
- Method (_EVT) {
+ Method (_EVT, 0x1) {
REQC = 0x100
Notify (\_SB.PWRB, 0x80)
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method
2020-05-25 18:24 [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method Ard Biesheuvel
@ 2020-05-26 20:49 ` Leif Lindholm
2020-05-27 7:14 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2020-05-26 20:49 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: devel
On Mon, May 25, 2020 at 20:24:55 +0200, Ard Biesheuvel wrote:
> The _EVT method on the ACPI0013 Generic Event device takes a single
> argument. Even though we are not interested in its value (given that
> there is only one interrupt source), we still have to declare the
> prototype correctly, or the OS might complain and refuse to call it.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> index 0ea8ce6d5f44..50f1753c3565 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> @@ -226,7 +226,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
> MASK = 0xfffffeff
> }
>
> - Method (_EVT) {
> + Method (_EVT, 0x1) {
> REQC = 0x100
> Notify (\_SB.PWRB, 0x80)
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method
2020-05-26 20:49 ` Leif Lindholm
@ 2020-05-27 7:14 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-05-27 7:14 UTC (permalink / raw)
To: Leif Lindholm; +Cc: devel
On 5/26/20 10:49 PM, Leif Lindholm wrote:
> On Mon, May 25, 2020 at 20:24:55 +0200, Ard Biesheuvel wrote:
>> The _EVT method on the ACPI0013 Generic Event device takes a single
>> argument. Even though we are not interested in its value (given that
>> there is only one interrupt source), we still have to declare the
>> prototype correctly, or the OS might complain and refuse to call it.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
Thanks
Pushed as 7121691cfcbc..85a50de1b459
>> ---
>> Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
>> index 0ea8ce6d5f44..50f1753c3565 100644
>> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
>> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
>> @@ -226,7 +226,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
>> MASK = 0xfffffeff
>> }
>>
>> - Method (_EVT) {
>> + Method (_EVT, 0x1) {
>> REQC = 0x100
>> Notify (\_SB.PWRB, 0x80)
>> }
>> --
>> 2.17.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-27 7:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-25 18:24 [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method Ard Biesheuvel
2020-05-26 20:49 ` Leif Lindholm
2020-05-27 7:14 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox