From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.1334.1590563699285858119 for ; Wed, 27 May 2020 00:14:59 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5E8855D; Wed, 27 May 2020 00:14:57 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 560D63F305; Wed, 27 May 2020 00:14:57 -0700 (PDT) Subject: Re: [PATCH edk2-platforms 1/1] Silicon/SynQuacer: use correct argument count for _EVT ACPI method To: Leif Lindholm Cc: devel@edk2.groups.io References: <20200525182455.18481-1-ard.biesheuvel@arm.com> <20200526204940.GS1923@vanye> From: "Ard Biesheuvel" Message-ID: Date: Wed, 27 May 2020 09:14:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200526204940.GS1923@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/26/20 10:49 PM, Leif Lindholm wrote: > On Mon, May 25, 2020 at 20:24:55 +0200, Ard Biesheuvel wrote: >> The _EVT method on the ACPI0013 Generic Event device takes a single >> argument. Even though we are not interested in its value (given that >> there is only one interrupt source), we still have to declare the >> prototype correctly, or the OS might complain and refuse to call it. >> >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks Pushed as 7121691cfcbc..85a50de1b459 >> --- >> Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl >> index 0ea8ce6d5f44..50f1753c3565 100644 >> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl >> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl >> @@ -226,7 +226,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR", >> MASK = 0xfffffeff >> } >> >> - Method (_EVT) { >> + Method (_EVT, 0x1) { >> REQC = 0x100 >> Notify (\_SB.PWRB, 0x80) >> } >> -- >> 2.17.1 >>