From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web12.15221.1664305252901051769 for ; Tue, 27 Sep 2022 12:00:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=CN3LSEml; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_llindhol@quicinc.com) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28RHS9Gw018235; Tue, 27 Sep 2022 19:00:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=SS4p3a3aWhNaE11wqry5wBCt8xt/V1E23XWZ6w6mU2c=; b=CN3LSEmlAK6kPUB5He7IBQXQ9OmjvEZhzMOOM+KjYB9JNiK2qCDV3wn8EHAlNtXrPCQ8 XzVG1Qptxkl0BUX/kvnqf9Th2Yq9KIkvWrPy3T0LmGrRDaOTmt+Oj11b41XUnlBzHrsx rXxquW1QTs/FxYNu1/5DsQ4rhAzHAriX3fvOFlvebrz8uny8TI8E2zbineeHXWk2/DFD u91WrrDT4QwbHrc+xqHEytNL5JHcT7+4/iSg+IZm5sIfF9W+aXh4em/f6urVhXqRsfYO bPrscFAZk0vZMqfzbGy0SXDyO6yZQEP4U2mKepW9mzD88F3tGngBW33FUCKCjhNu7t6N 9w== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3juw51jd5m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 19:00:40 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 28RItdv5014145 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Sep 2022 18:55:39 GMT Received: from [10.110.17.52] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 27 Sep 2022 11:55:38 -0700 Message-ID: Date: Tue, 27 Sep 2022 11:55:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v5 04/21] ArmPkg/ArmHvcNullLib: Add NULL instance of ArmHvcLib To: , CC: Sami Mujawar , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , Jiewen Yao , Jian J Wang References: <20220919192207.637786-1-Pierre.Gondois@arm.com> <20220919192207.637786-5-Pierre.Gondois@arm.com> From: "Leif Lindholm" In-Reply-To: <20220919192207.637786-5-Pierre.Gondois@arm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: F7PceZ0SYKGFTR2Al0GH4kjY1hEDy1fb X-Proofpoint-GUID: F7PceZ0SYKGFTR2Al0GH4kjY1hEDy1fb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-27_09,2022-09-27_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209270119 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2022-09-19 12:21, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Add a Null instance of ArmHvcLib in case of library dependencies. > > Signed-off-by: Pierre Gondois > --- > ArmPkg/ArmPkg.dsc | 1 + > ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c | 29 +++++++++++++++++++ > .../Library/ArmHvcNullLib/ArmHvcNullLib.inf | 22 ++++++++++++++ > 3 files changed, 52 insertions(+) > create mode 100644 ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c > create mode 100644 ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.inf I think the name of the library, source files and library class should be ArmHvcLibNull rather than ArmHvcNullLib - to match existing code. > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index 3afd212f472b..e33b40f2c215 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -134,6 +134,7 @@ [Components.common] > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > ArmPkg/Library/ArmSmcLibNull/ArmSmcLibNull.inf > ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf > + ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.inf Please sort alphabetically. > ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf > ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf > ArmPkg/Library/OpteeLib/OpteeLib.inf > diff --git a/ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c b/ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c > new file mode 100644 > index 000000000000..6905631ccb6c > --- /dev/null > +++ b/ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c > @@ -0,0 +1,29 @@ > +/** @file > + Arm HyperVisor Call (HVC) Null Library. > + > + Copyright (c) 2022, Arm Limited. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include Please sort alphabetically. / Leif > + > +/** > + Trigger an HVC call > + > + HVC calls can take up to 8 arguments and return up to 4 return values. > + Therefore, the 4 first fields in the ARM_HVC_ARGS structure are used > + for both input and output values. > + > + @param [in, out] Args Arguments for the HVC call. > +**/ > +VOID > +ArmCallHvc ( > + IN OUT ARM_HVC_ARGS *Args > + ) > +{ > + ASSERT (FALSE); > + return; > +} > diff --git a/ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.inf b/ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.inf > new file mode 100644 > index 000000000000..c4665d34018b > --- /dev/null > +++ b/ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.inf > @@ -0,0 +1,22 @@ > +## @file > +# Arm Hvc Null Library > +# > +# Copyright (c) 2022, Arm Limited. All rights reserved.
> +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = ArmHvcNullLib > + FILE_GUID = 02076A46-D6DB-48DD-8E5F-153172DD73A1 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = ArmHvcLib > + > +[Sources] > + ArmHvcNullLib.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + MdePkg/MdePkg.dec