From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25])
by mx.groups.io with SMTP id smtpd.web11.48249.1683204031593165099
for <devel@edk2.groups.io>;
Thu, 04 May 2023 05:40:31 -0700
Authentication-Results: mx.groups.io;
dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=yelV3p14;
spf=pass (domain: bsdio.com, ip: 64.147.123.25, mailfrom: rebecca@bsdio.com)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.west.internal (Postfix) with ESMTP id A02813200994;
Thu, 4 May 2023 08:40:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Thu, 04 May 2023 08:40:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc
:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm1; t=
1683204029; x=1683290429; bh=P0MR/BVCr3SH9l+WBwP0EpzrsDkco9hGZRF
brBOSY9E=; b=yelV3p14ZZarJzp8NJgveCs97VyXfZ0tr9Pu2lGUQ/LPD9vh2ym
wVVS0jZXXkSrQl84UTzvx1vbthjpTGRHYw+4VC8udfsZ4+VRM3kgibszBrzl9BeA
6kAgEdjps/PGEoEzIu51gGnsu3aY0JcDCo3/8bvUdd4mPiLJlSagE+t3Gp1CfXp+
FpjxeLBxqR+vNiBykmgS0dmdxTKZ74Z/0L/6tFeGa2lf4ydftysoRcioPldjE5xo
o0Axbudsr4fBQJJ6/oCX4TqGpw0lCGZsSvDdQauKJkl5dYSZC335cCyugjCKoCU7
pQjWDuAd4oAw9oVaiJuWoce6zsZNWnpWeTg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
1683204029; x=1683290429; bh=P0MR/BVCr3SH9l+WBwP0EpzrsDkco9hGZRF
brBOSY9E=; b=dBSJMGZORcn/XhBUDNm8fKgr+9FPYb+hm8YD1+sjKS9SxpU/XsZ
mxtkUvJpJZPZ0PEpTX9HVrd9jWgL1HHgL9c+EQpfwYX7oBSluBWDGDryMliRWjzU
1y2cyirpVtuTEZhG9Kt5KItgesQg3JOytCbtV8o67bWLRIzxfOyt6RjsmTNRKCJ7
sDSWyweGc9HeOZScBkDW1cWcqohRMJIPIkjzn/Tc9Xmtit3fwUSYH4kL5L9o5c8I
ihZ4xSh2gzBzZp9PT4QvN5ijYhfkY6J+TAwdGBBzPEmn4r2Iqh2HXwyK2Eg0vQXg
r0iSM0CEFT/PdJ/9Gcv7je81/HEXgj6kcOw==
X-ME-Sender: <xms:vKdTZFpdHd3nEGNzQPodu_CO5GkGuwkoTr_ywWbSDXrYGDby_h64HA>
<xme:vKdTZHq3Teq1sNJF7xD0bOzEMVoWhhSzgFpasgC1HJAYOSfs2_zz2zVwDpVA6W2RW
P6exZOdMMN5YOdHgAE>
X-ME-Received: <xmr:vKdTZCMTx319TZgc3sN803AWntvTIQyLgm8wYSELGQNt9hBNZWyWA5p6RtF2iKXmkRmqiiKjt76uiELKj80geiokhud80S4b7ciTWg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeftddgheegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs
vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg
htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff
ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
hrvggsvggttggrsegsshguihhordgtohhm
X-ME-Proxy: <xmx:vKdTZA4EHKw0qzaalt7ezceJrirLBjOlsBsO6mR8UYsndSQanClmjg>
<xmx:vKdTZE4SvpCcWNJ46x7HusRNl71ZzH_7iIIl6l_oHyKPTG11LgA9aQ>
<xmx:vKdTZIh7LmpWXbkpeUeHi2UXqfciyf_ob8nTVECLuyJ_zjQ3UCUClg>
<xmx:vadTZPowmPjF_VQqPIyn1p7qam13CqIVeM6N0ti8vno0sNvUrkz18A>
Feedback-ID: i5b994698:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
4 May 2023 08:40:27 -0400 (EDT)
Message-ID: <e3753948-63f4-3a26-4b25-627b4564f503@bsdio.com>
Date: Thu, 4 May 2023 06:40:26 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.10.0
Subject: Re: [PATCH v5 00/10] BaseTools: remove duplicate includes.
To: Gerd Hoffmann <kraxel@redhat.com>, devel@edk2.groups.io
Cc: Yuwei Chen <yuwei.chen@intel.com>, Oliver Steffen <osteffen@redhat.com>,
Bob Feng <bob.c.feng@intel.com>, =?UTF-8?Q?Marvin_H=c3=a4user?=
<mhaeuser@posteo.de>, Daniel Schaefer <git@danielschaefer.me>,
Chao Li <lichao@loongson.cn>, Dongyan Qian <qiandongyan@loongson.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Pawel Polawski <ppolawsk@redhat.com>, Baoqi Zhang <zhangbaoqi@loongson.cn>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Zhiguang Liu <zhiguang.liu@intel.com>, Sunil V L <sunilvl@ventanamicro.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Liming Gao <gaoliming@byosoft.com.cn>
References: <20230421044535.4030762-1-kraxel@redhat.com>
<x2jyc6gxx4gey6f25d4asz6p7pl6lhlwgfxkq2froh6auyyas3@fiz4q56zc5hq>
From: "Rebecca Cran" <rebecca@bsdio.com>
In-Reply-To: <x2jyc6gxx4gey6f25d4asz6p7pl6lhlwgfxkq2froh6auyyas3@fiz4q56zc5hq>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sorry for the delay.
For the series:
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
On 5/4/23 04:11, Gerd Hoffmann wrote:
> Ping.
>
> On Fri, Apr 21, 2023 at 06:45:25AM +0200, Gerd Hoffmann wrote:
>> There is alot of code duplication between BaseTools and MdePkg (and also
>> MdeModulePkg). This patch series starts reducing this by removing some
>> header files. BaseTools are switched over to use the include files in
>> MdePkg instead. It also cleans up some (apparently) obsolete code and
>> adapts BaseTools code in a few places to work with the MdePkg version of
>> the include files.
>>
>> v5 changes:
>> - remove visibility hidden on x64
>> - add assert for GOT being empty.
>> v4 changes:
>> - fix clang build failure
>> v3 changes:
>> - fix build failure on ubuntu 22.04
>> v2 changes:
>> - rebase to latest master, resolve conflicts.
>> - pick up reviews and acks.
>>
>> take care,
>> Gerd
>>
>> Gerd Hoffmann (10):
>> BaseTools: make sure the got is empty
>> MdePkg: don't set visibility to hidden
>> BaseTools: remove WinNtInclude.h
>> BaseTools: remove duplicate includes: <arch>/ProcessorBind.h
>> BaseTools: remove duplicate includes: IndustryStandard/Acpi*.h
>> MdePkg/PeImage.h: add bits from BaseTools version
>> BaseTools: drop IMAGE_FILE_MACHINE_ARM hacks
>> BaseTools: switch from EFI_IMAGE_MACHINE_* to IMAGE_FILE_MACHINE_*
>> BaseTools: remove duplicate includes: IndustryStandard/PeImage.h
>> BaseTools: remove duplicate includes: IndustryStandard/*.h
>>
>> BaseTools/Source/C/Common/WinNtInclude.h | 66 --
>> BaseTools/Source/C/EfiRom/EfiRom.h | 14 +-
>> .../Source/C/Include/AArch64/ProcessorBind.h | 148 ----
>> .../Source/C/Include/Arm/ProcessorBind.h | 147 ----
>> .../Source/C/Include/Ia32/ProcessorBind.h | 155 ----
>> .../Source/C/Include/IndustryStandard/Acpi.h | 117 ---
>> .../C/Include/IndustryStandard/Acpi1_0.h | 285 -------
>> .../C/Include/IndustryStandard/Acpi2_0.h | 520 ------------
>> .../C/Include/IndustryStandard/Acpi3_0.h | 668 ---------------
>> .../C/Include/IndustryStandard/Bluetooth.h | 56 --
>> .../C/Include/IndustryStandard/EfiPci.h | 51 --
>> ...emoryMappedConfigurationSpaceAccessTable.h | 39 -
>> .../C/Include/IndustryStandard/PeImage.h | 789 ------------------
>> .../Source/C/Include/IndustryStandard/pci22.h | 536 ------------
>> .../Source/C/Include/IndustryStandard/pci23.h | 18 -
>> .../Source/C/Include/IndustryStandard/pci30.h | 38 -
>> .../C/Include/LoongArch64/ProcessorBind.h | 80 --
>> .../Source/C/Include/Protocol/DevicePath.h | 2 +-
>> .../Source/C/Include/RiscV64/ProcessorBind.h | 85 --
>> .../Source/C/Include/X64/ProcessorBind.h | 183 ----
>> MdePkg/Include/IndustryStandard/PeImage.h | 31 +
>> MdePkg/Include/X64/ProcessorBind.h | 14 -
>> BaseTools/Source/C/Common/BasePeCoff.c | 51 +-
>> BaseTools/Source/C/Common/Decompress.c | 1 +
>> BaseTools/Source/C/GenFv/GenFvInternalLib.c | 43 +-
>> BaseTools/Source/C/GenFw/Elf32Convert.c | 8 +-
>> BaseTools/Source/C/GenFw/Elf64Convert.c | 12 +-
>> BaseTools/Source/C/GenFw/ElfConvert.c | 2 -
>> BaseTools/Source/C/GenFw/GenFw.c | 18 +-
>> BaseTools/Scripts/ClangBase.lds | 10 +
>> BaseTools/Scripts/GccBase.lds | 10 +
>> BaseTools/Source/C/Makefiles/header.makefile | 15 +-
>> BaseTools/Source/C/Makefiles/ms.common | 13 +-
>> 33 files changed, 132 insertions(+), 4093 deletions(-)
>> delete mode 100644 BaseTools/Source/C/Common/WinNtInclude.h
>> delete mode 100644 BaseTools/Source/C/Include/AArch64/ProcessorBind.h
>> delete mode 100644 BaseTools/Source/C/Include/Arm/ProcessorBind.h
>> delete mode 100644 BaseTools/Source/C/Include/Ia32/ProcessorBind.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi1_0.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi2_0.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Acpi3_0.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/Bluetooth.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/EfiPci.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/PeImage.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci22.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci23.h
>> delete mode 100644 BaseTools/Source/C/Include/IndustryStandard/pci30.h
>> delete mode 100644 BaseTools/Source/C/Include/LoongArch64/ProcessorBind.h
>> delete mode 100644 BaseTools/Source/C/Include/RiscV64/ProcessorBind.h
>> delete mode 100644 BaseTools/Source/C/Include/X64/ProcessorBind.h
>>
>> --
>> 2.40.0
>>