From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by mx.groups.io with SMTP id smtpd.web10.9496.1591792285770075005
 for <devel@edk2.groups.io>;
 Wed, 10 Jun 2020 05:31:25 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.24, mailfrom: maciej.rabeda@linux.intel.com)
IronPort-SDR: fuqqn0AiR7l//WK0i+O4wljbqeYPDewqDPctVWVy19PwrwofDTkArZFWEp1qAvAFcvgyrAUbrB
 wXnPaBv8hZTw==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
  by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 05:31:24 -0700
IronPort-SDR: ydgMYdtwlmvA38p9X+03PMnbYEb5M5PyJVzZWbwG+FAUeGpZxgLqSSQh4MD+pckDxBmsTibC8c
 bDFxdlsScYIg==
X-IronPort-AV: E=Sophos;i="5.73,496,1583222400"; 
   d="scan'208";a="447485927"
Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.213.20.84]) ([10.213.20.84])
  by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2020 05:31:23 -0700
Subject: Re: [PATCH v3 11/17] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
To: Shenglei Zhang <shenglei.zhang@intel.com>, devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>
References: <20200610081437.61352-1-shenglei.zhang@intel.com>
 <20200610081437.61352-12-shenglei.zhang@intel.com>
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
Message-ID: <e37c85fc-4662-f001-c899-d0b22cb73ded@linux.intel.com>
Date: Wed, 10 Jun 2020 14:31:17 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <20200610081437.61352-12-shenglei.zhang@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: pl

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

On 10-Jun-20 10:14, Shenglei Zhang wrote:
> Add configuration ExceptionList and IgnoreFiles for package config
> files. So users can rely on this to ignore some Ecc issues.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>   NetworkPkg/NetworkPkg.ci.yaml | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/NetworkPkg/NetworkPkg.ci.yaml b/NetworkPkg/NetworkPkg.ci.yaml
> index 70f2e1014748..7cd61912c71e 100644
> --- a/NetworkPkg/NetworkPkg.ci.yaml
> +++ b/NetworkPkg/NetworkPkg.ci.yaml
> @@ -5,6 +5,16 @@
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   ##
>   {
> +    "EccCheck": {
> +        ## Exception sample looks like below:
> +        ## "ExceptionList": [
> +        ##     "<ErrorID>", "<KeyWord>"
> +        ## ]
> +        "ExceptionList": [
> +        ],
> +        "IgnoreFiles": [
> +        ]
> +    },
>       "CompilerPlugin": {
>           "DscPath": "NetworkPkg.dsc"
>       },