From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1FC61223230CC for ; Fri, 16 Feb 2018 01:26:44 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C7A13EB6F6; Fri, 16 Feb 2018 09:32:37 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-135.rdu2.redhat.com [10.10.120.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0E64213AEE2; Fri, 16 Feb 2018 09:32:36 +0000 (UTC) To: Meenakshi Aggarwal , "ruiyu.ni@intel.com" , "jaben.carsey@intel.com" , "edk2-devel@lists.01.org" References: <1518535345-3327-1-git-send-email-meenakshi.aggarwal@nxp.com> <87796a79-a092-4280-2e5d-11f0c87cfde3@redhat.com> From: Laszlo Ersek Message-ID: Date: Fri, 16 Feb 2018 10:32:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 16 Feb 2018 09:32:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 16 Feb 2018 09:32:37 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] RFC : Ping : Fix for loss of first ping packet X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 09:26:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/16/18 06:45, Meenakshi Aggarwal wrote: > Hi, > > I have shared patch with correction in subject. > > Please see if it is visible to you now. Yes, the new patch seems well-formed and it is on the list. I'll let the ShellPkg maintainers review it. Thanks! Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Thursday, February 15, 2018 5:59 PM >> To: Meenakshi Aggarwal ; >> ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org >> Subject: Re: [edk2] [PATCH] RFC : Ping : Fix for loss of first ping packet >> >> Hi Meenakshi, >> >> On 02/15/18 13:08, Meenakshi Aggarwal wrote: >>> Hi, >>> >>> Any comment? >> >> I don't see your original patch email on the list, either in my personal >> folder, or in the archive at >> > ts.01.org%2Fpipermail%2Fedk2-devel%2F2018- >> February%2Fthread.html&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.co >> m%7Cd55e68d82714417526e008d5746faad4%7Cbd8a2a2207224ec7b35f1c4f0 >> 497e341%7C0%7C0%7C636542945322839311&sdata=OyrBgmxscmLtSjkhrcglD >> A%2BYAPH77IbycKEql759m1s%3D&reserved=0>. >> Can you resend? >> >> Also, I suggest a subject line like: >> >> [RFC] ShellPkg/Ping: fix loss of first packet >> >> In other words, "RFC" should only be in the bracketed part (= the >> subject prefix). You can change the [PATCH] prefix into [RFC] by adding >> >> --subject-prefix=RFC >> >> to the git-format-patch command line. >> >> Thanks >> Laszlo >> >>>> -----Original Message----- >>>> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com] >>>> Sent: Tuesday, February 13, 2018 8:52 PM >>>> To: ruiyu.ni@intel.com; jaben.carsey@intel.com; edk2-devel@lists.01.org >>>> Cc: Udit Kumar ; Varun Sethi >> ; >>>> Meenakshi Aggarwal >>>> Subject: [PATCH] RFC : Ping : Fix for loss of first ping packet >>>> >>>> Issue: >>>> Reply for first ping packet was getting dropped. >>>> >>>> Cause: >>>> Sometimes reply message comes even before trasmit >>>> function returns, hence missing 1st reply >>>> >>>> Fix: >>>> Prepare the TxList before calling Transmit function. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Meenakshi Aggarwal >>>> --- >>>> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>> index bec9535..46ba701 100644 >>>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c >>>> @@ -784,14 +784,17 @@ PingSendEchoRequest ( >>>> } >>>> >>>> ASSERT(Private->ProtocolPointers.Transmit != NULL); >>>> + >>>> + InsertTailList (&Private->TxList, &TxInfo->Link); >>>> + >>>> Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, >> TxInfo- >>>>> Token); >>>> >>>> if (EFI_ERROR (Status)) { >>>> + RemoveEntryList (&TxInfo->Link); >>>> PingDestroyTxInfo (TxInfo, Private->IpChoice); >>>> return Status; >>>> } >>>> >>>> - InsertTailList (&Private->TxList, &TxInfo->Link); >>>> Private->TxCount++; >>>> >>>> return EFI_SUCCESS; >>>> -- >>>> 1.9.1 >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> >> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist >> s.01.org%2Fmailman%2Flistinfo%2Fedk2- >> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7Cd55e68d8271 >> 4417526e008d5746faad4%7Cbd8a2a2207224ec7b35f1c4f0497e341%7C0%7C0 >> %7C636542945322839311&sdata=zCc8J582i3pSgXHDKvF3SJTJ7Z0mPAq1VenJ6 >> WeoNqQ%3D&reserved=0 >>> >