From: Laszlo Ersek <lersek@redhat.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
edk2-devel@ml01.01.org, "Gao, Liming" <liming.gao@intel.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
"Tian, Feng" <feng.tian@intel.com>,
"Zeng, Star" <star.zeng@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Andrew Fish <afish@apple.com>, Jeff Fan <jeff.fan@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Kelly Steele <kelly.steele@intel.com>,
David Wei <david.wei@intel.com>, Mang Guo <mang.guo@intel.com>
Subject: Re: [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs
Date: Wed, 30 Nov 2016 21:08:01 +0100 [thread overview]
Message-ID: <e3ae8e22-d026-0d88-e514-920b4dc09003@redhat.com> (raw)
In-Reply-To: <20161130172028.1430-1-leif.lindholm@linaro.org>
On 11/30/16 18:20, Leif Lindholm wrote:
> LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied
> from IntelFrameworkModulePkg to MdeModulePkg, but the originals were
> kept for compatibility.
>
> Nevertheless, new code should be using the MdeModulePkg versions, so
> change all references in in-tree platforms.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> DuetPkg/DuetPkgIa32.dsc | 4 ++--
> DuetPkg/DuetPkgX64.dsc | 4 ++--
> EmbeddedPkg/EmbeddedPkg.dsc | 2 +-
> EmulatorPkg/EmulatorPkg.dsc | 4 ++--
> IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 6 +++---
> OvmfPkg/OvmfPkgIa32.dsc | 4 ++--
> OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++--
> OvmfPkg/OvmfPkgX64.dsc | 4 ++--
> QuarkSocPkg/QuarkSocPkg.dsc | 2 +-
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++--
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++---
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++---
> 13 files changed, 27 insertions(+), 27 deletions(-)
[snip]
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index d913030..81f7521 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -505,7 +505,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -550,7 +550,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 8143ea9..f7855b6 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -513,7 +513,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -559,7 +559,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index d48d603..e933a41 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -512,7 +512,7 @@
> #
> OvmfPkg/Sec/SecMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> }
>
> #
> @@ -557,7 +557,7 @@
> #
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
> - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> }
>
[snip]
I diffed the two library instances (the directories) recursively, and
they are identical. That's actually too much of a match for my taste;
the copy under MdeModulePkg should have at least received a different
FILE_GUID.
Anyway, the change looks safe. If you split out the OvmfPkg patch
(please do that in the non-RFC version), you can add my
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
next prev parent reply other threads:[~2016-11-30 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 17:16 LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode Leif Lindholm
2016-11-15 3:01 ` Gao, Liming
2016-11-30 17:20 ` [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs Leif Lindholm
2016-11-30 20:08 ` Laszlo Ersek [this message]
2016-12-01 1:12 ` Gao, Liming
2016-12-01 1:52 ` Zeng, Star
2016-12-01 10:23 ` Leif Lindholm
2016-12-01 2:29 ` Kinney, Michael D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ae8e22-d026-0d88-e514-920b4dc09003@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox