From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6436D81C95 for ; Wed, 30 Nov 2016 12:08:06 -0800 (PST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 77EA369CCC; Wed, 30 Nov 2016 20:08:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-51.phx2.redhat.com [10.3.116.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUK81g7014932; Wed, 30 Nov 2016 15:08:02 -0500 To: Leif Lindholm , edk2-devel@ml01.01.org, "Gao, Liming" References: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B1F83@shsmsx102.ccr.corp.intel.com> <20161130172028.1430-1-leif.lindholm@linaro.org> Cc: "Wu, Hao A" , "Tian, Feng" , "Zeng, Star" , Ruiyu Ni , Jordan Justen , Andrew Fish , Jeff Fan , Michael D Kinney , Kelly Steele , David Wei , Mang Guo From: Laszlo Ersek Message-ID: Date: Wed, 30 Nov 2016 21:08:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161130172028.1430-1-leif.lindholm@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 30 Nov 2016 20:08:05 +0000 (UTC) Subject: Re: [RFC] Various: Remove EDK2 use of IntelFrameworkModulePkg legacy libs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 20:08:06 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/30/16 18:20, Leif Lindholm wrote: > LzmaCustomDecompressLib and PeiDxeDebugLibReportStatusCode were copied > from IntelFrameworkModulePkg to MdeModulePkg, but the originals were > kept for compatibility. > > Nevertheless, new code should be using the MdeModulePkg versions, so > change all references in in-tree platforms. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++-- > DuetPkg/DuetPkgIa32.dsc | 4 ++-- > DuetPkg/DuetPkgX64.dsc | 4 ++-- > EmbeddedPkg/EmbeddedPkg.dsc | 2 +- > EmulatorPkg/EmulatorPkg.dsc | 4 ++-- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 6 +++--- > OvmfPkg/OvmfPkgIa32.dsc | 4 ++-- > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++-- > OvmfPkg/OvmfPkgX64.dsc | 4 ++-- > QuarkSocPkg/QuarkSocPkg.dsc | 2 +- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 4 ++-- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 +++--- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 +++--- > 13 files changed, 27 insertions(+), 27 deletions(-) [snip] > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index d913030..81f7521 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -505,7 +505,7 @@ > # > OvmfPkg/Sec/SecMain.inf { > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > } > > # > @@ -550,7 +550,7 @@ > # > MdeModulePkg/Core/Dxe/DxeMain.inf { > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > } > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 8143ea9..f7855b6 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -513,7 +513,7 @@ > # > OvmfPkg/Sec/SecMain.inf { > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > } > > # > @@ -559,7 +559,7 @@ > # > MdeModulePkg/Core/Dxe/DxeMain.inf { > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > } > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index d48d603..e933a41 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -512,7 +512,7 @@ > # > OvmfPkg/Sec/SecMain.inf { > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > } > > # > @@ -557,7 +557,7 @@ > # > MdeModulePkg/Core/Dxe/DxeMain.inf { > > - NULL|IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > + NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > } > [snip] I diffed the two library instances (the directories) recursively, and they are identical. That's actually too much of a match for my taste; the copy under MdeModulePkg should have at least received a different FILE_GUID. Anyway, the change looks safe. If you split out the OvmfPkg patch (please do that in the non-RFC version), you can add my Reviewed-by: Laszlo Ersek Thanks! Laszlo