From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 24 Sep 2019 03:50:03 -0700 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9770F86663 for ; Tue, 24 Sep 2019 10:50:02 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id r21so647182wme.5 for ; Tue, 24 Sep 2019 03:50:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bcP+ksyZ28cur+Bf/nzg9zyLn9NvLWlUam4/g3wLUdo=; b=qaFg2PNIVUein9q4+OvmG8fWtnBTEe1JuRGXL1GgbD85To+ZZ+WyIgRxdRn4zPzXf1 t0MNpfZVjGXpZvDguwGA7ESHbMRb5SmQRdTLJQ+TwIGQNEFrkQmSls7dkuRisISylk/+ H1R4PPI7Kb7u0pskAfylQIoMbJHSXK+6yQWRSXtauPb8djwHqtayUrYVDVLp90ycm0UI 65SOYjmW6fCwqtjTrF+q1OECKPnCCQuvyaQki6BK31M5FN5VUd0msTlf0w+88Pvj1MRM nAbnsydeRTvhtwsoU1EhdMYdwI6DYFLRNYVdHx6PJBqyRN714vGMYi99haBuTJDw4iqw gyHQ== X-Gm-Message-State: APjAAAW8zWER9k5htbGxsZvIwMb0+cR+kY+PptCpB9dBlfz/l05VmCEy KWLdokAqEbseJlESXdVfJkTZz5Hl4NdhHfCNAiw0S/CLcbbObyqVsIu5xtH9I1aAM7Z9ie52lxk t8BOCVES/eeG1uw== X-Received: by 2002:a05:6000:12:: with SMTP id h18mr1775827wrx.156.1569322201306; Tue, 24 Sep 2019 03:50:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqy4/+fhXrO7W592RmonE4QDB5fvokVyyKl6X/WeJz91z7yPK8yo/6IzxPDbcFqG8+zew72Ukw== X-Received: by 2002:a05:6000:12:: with SMTP id h18mr1775808wrx.156.1569322201127; Tue, 24 Sep 2019 03:50:01 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id n18sm1802721wmi.20.2019.09.24.03.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2019 03:50:00 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 08/35] MdeModulePkg/UefiHiiLib: stop using EFI_HANDLE in place of EFI_HII_HANDLE To: devel@edk2.groups.io, lersek@redhat.com Cc: Dandan Bi , Eric Dong , Hao A Wu , Jian J Wang References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-9-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Tue, 24 Sep 2019 12:49:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-9-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > HiiGetHiiHandles() returns an array of EFI_HII_HANDLEs, not EFI_HANDLEs. > HiiGetString() takes an EFI_HII_HANDLE, not an EFI_HANDLE. > > This change is a no-op in practice; it's a semantic improvement. > > Cc: Dandan Bi > Cc: Eric Dong > Cc: Hao A Wu > Cc: Jian J Wang > Signed-off-by: Laszlo Ersek > --- > > Notes: > lightly tested, as UefiHiiLib is used by both ArmVirt and OVMF > > MdeModulePkg/Library/UefiHiiLib/HiiString.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiString.c b/MdeModulePkg/Library/UefiHiiLib/HiiString.c > index 498f245dce1f..95229f8a8c9f 100644 > --- a/MdeModulePkg/Library/UefiHiiLib/HiiString.c > +++ b/MdeModulePkg/Library/UefiHiiLib/HiiString.c > @@ -173,8 +173,8 @@ HiiGetPackageString ( > IN CONST CHAR8 *Language OPTIONAL > ) > { > - EFI_HANDLE *HiiHandleBuffer; > - EFI_HANDLE HiiHandle; > + EFI_HII_HANDLE *HiiHandleBuffer; > + EFI_HII_HANDLE HiiHandle; > > ASSERT (PackageListGuid != NULL); > > Reviewed-by: Philippe Mathieu-Daude