From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.13979.1583155360257347011 for ; Mon, 02 Mar 2020 05:22:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EMSM0nea; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583155359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uQlfsDiyzvZQHVZto4x5xwMjR7UcYhqQ8SSYKEkLZ7k=; b=EMSM0neaL2qbua5zNrnrn77q7Jq8KoDYfXtuEhHpnpZHdzcjapctsBkikfoHJQz/1Y9OSU kgUCvCKU4ET0U2WRf+p8N/lj785usPwUYlnY0c/JeIaVjp7lHFvJnVab3tz61RL7DsUYZS AwRHkaL2b7QuUMgTf/l2CIsmPxa5uBk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-n2OG6AdiPcmVpoTRHoaA-g-1; Mon, 02 Mar 2020 08:22:33 -0500 X-MC-Unique: n2OG6AdiPcmVpoTRHoaA-g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2C2B913F6; Mon, 2 Mar 2020 13:22:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-197.ams2.redhat.com [10.36.117.197]) by smtp.corp.redhat.com (Postfix) with ESMTP id 88C4D60BF3; Mon, 2 Mar 2020 13:22:31 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 01/13] OvmfPkg: add GUID for the QEMU kernel loader fs media device path To: devel@edk2.groups.io, ard.biesheuvel@linaro.org References: <20200302072936.29221-1-ard.biesheuvel@linaro.org> <20200302072936.29221-2-ard.biesheuvel@linaro.org> From: "Laszlo Ersek" Message-ID: Date: Mon, 2 Mar 2020 14:22:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200302072936.29221-2-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/02/20 08:29, Ard Biesheuvel wrote: > In an upcoming patch, we will introduce a separate DXE driver that > exposes the virtual SimpleFileSystem implementation that carries the > kernel and initrd passed via the QEMU command line, and a separate > library that consumes it, to be incorporated into the boot manager. > > Since the GUID used for the SimpleFileSystem implementation's device > path will no longer be for internal use only, create a well defined > GUID to identify the media device path. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2566 > Signed-off-by: Ard Biesheuvel > --- > OvmfPkg/Include/Guid/QemuKernelLoaderFsMedia.h | 18 ++++++++++++++++++ > OvmfPkg/OvmfPkg.dec | 1 + > 2 files changed, 19 insertions(+) > > diff --git a/OvmfPkg/Include/Guid/QemuKernelLoaderFsMedia.h b/OvmfPkg/Include/Guid/QemuKernelLoaderFsMedia.h > new file mode 100644 > index 000000000000..225c3c494613 > --- /dev/null > +++ b/OvmfPkg/Include/Guid/QemuKernelLoaderFsMedia.h > @@ -0,0 +1,18 @@ > +/** @file > + GUID definition for the QEMU LoaderFs media device path, containing the > + kernel, initrd and command line as file objects > + > + Copyright (c) 2020, Arm, Ltd. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef QEMU_KERNEL_LOADER_FS_MEDIA_GUID_H__ > +#define QEMU_KERNEL_LOADER_FS_MEDIA_GUID_H__ > + > +#define QEMU_KERNEL_LOADER_FS_MEDIA_GUID \ > + {0x1428f772, 0xb64a, 0x441e, {0xb8, 0xc3, 0x9e, 0xbd, 0xd7, 0xf8, 0x93, 0xc7}} > + > +extern EFI_GUID gQemuKernelLoaderFsMediaGuid; > + > +#endif > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index 6849a79cd8b0..d88778600517 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -87,6 +87,7 @@ [Guids] > gEfiLegacyBiosGuid = {0x2E3044AC, 0x879F, 0x490F, {0x97, 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50}} > gEfiLegacyDevOrderVariableGuid = {0xa56074db, 0x65fe, 0x45f7, {0xbd, 0x21, 0x2d, 0x2b, 0xdd, 0x8e, 0x96, 0x52}} > gLinuxEfiInitrdMediaGuid = {0x5568e427, 0x68fc, 0x4f3d, {0xac, 0x74, 0xca, 0x55, 0x52, 0x31, 0xcc, 0x68}} > + gQemuKernelLoaderFsMediaGuid = {0x1428f772, 0xb64a, 0x441e, {0xb8, 0xc3, 0x9e, 0xbd, 0xd7, 0xf8, 0x93, 0xc7}} > > [Protocols] > gVirtioDeviceProtocolGuid = {0xfa920010, 0x6785, 0x4941, {0xb6, 0xec, 0x49, 0x8c, 0x57, 0x9f, 0x16, 0x0a}} > Reviewed-by: Laszlo Ersek