From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: <devel@edk2.groups.io>, <sami.mujawar@arm.com>,
PierreGondois <pierre.gondois@arm.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>, nd <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: Add AmlCodeGenMethodRetInteger function
Date: Wed, 2 Feb 2022 08:03:54 -0700 [thread overview]
Message-ID: <e3db3a77-174c-5f53-e747-94041ecb1d4f@quicinc.com> (raw)
In-Reply-To: <3a153d35-2509-ad08-3651-f96b411c053e@arm.com>
On 2/2/22 07:53, Sami Mujawar wrote:
>> + Status = AmlCodeGenInteger (Integer, &IntNode);
>> + ASSERT_EFI_ERROR (Status);
> [SAMI] In release builds, ASSERT_EFI_ERROR() would vanish and we could
> end up accessing an invalid pointer.
> If you agree, I will change this to check the status and return the
> error code, before merging.
> [/SAMI]
Yes, please do.
Thanks.
Rebecca Cran
next prev parent reply other threads:[~2022-02-02 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 16:40 [PATCH v3 0/3] Add Memory32Fixed and AmlCodeGenMethodRetInteger functions Rebecca Cran
2022-01-13 16:40 ` [PATCH v3 1/3] DynamicTablesPkg: Add Memory32Fixed function Rebecca Cran
2022-02-02 14:52 ` Sami Mujawar
2022-02-02 15:03 ` [edk2-devel] " Rebecca Cran
2022-01-13 16:40 ` [PATCH v3 2/3] DynamicTablesPkg: Remove redundant cast in AmlCodeGenReturn Rebecca Cran
2022-02-02 14:53 ` Sami Mujawar
2022-01-13 16:40 ` [PATCH v3 3/3] DynamicTablesPkg: Add AmlCodeGenMethodRetInteger function Rebecca Cran
2022-02-02 14:53 ` Sami Mujawar
2022-02-02 15:03 ` Rebecca Cran [this message]
2022-02-02 19:41 ` [PATCH v3 0/3] Add Memory32Fixed and AmlCodeGenMethodRetInteger functions Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3db3a77-174c-5f53-e747-94041ecb1d4f@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox