From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38])
 by mx.groups.io with SMTP id smtpd.web11.65491.1643814235440167501
 for <devel@edk2.groups.io>;
 Wed, 02 Feb 2022 07:03:55 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=MfknKn2z;
 spf=pass (domain: quicinc.com, ip: 199.106.114.38, mailfrom: quic_rcran@quicinc.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim;
  t=1643814235; x=1675350235;
  h=message-id:date:mime-version:subject:to:references:from:
   in-reply-to:content-transfer-encoding;
  bh=h7VhMfWrKYhP+3k+OVdwVtdRiFMt99qkY/rjAu8SPnM=;
  b=MfknKn2zDiAt41l4UOMqSjgGGYUrdwEqaTObbVlHWM6o2rf6j4pC60Pe
   NADw7qAwgFWWg6S5oArcqE2iyW4fWzTqWFDZfbnAGy2MaIdvq4KIjRbjU
   e0RcfGv0tCmOQ5aY3OkNceF671/wDkXTzUnACT9AxiAFu5nA8Cn6pkUPb
   A=;
Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141])
  by alexa-out-sd-01.qualcomm.com with ESMTP; 02 Feb 2022 07:03:55 -0800
X-QCInternal: smtphost
Received: from nasanex01b.na.qualcomm.com ([10.46.141.250])
  by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 07:03:55 -0800
Received: from [10.110.3.55] (10.80.80.8) by nasanex01b.na.qualcomm.com
 (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Wed, 2 Feb 2022
 07:03:54 -0800
Message-ID: <e3db3a77-174c-5f53-e747-94041ecb1d4f@quicinc.com>
Date: Wed, 2 Feb 2022 08:03:54 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [edk2-devel] [PATCH v3 3/3] DynamicTablesPkg: Add AmlCodeGenMethodRetInteger function
To: <devel@edk2.groups.io>, <sami.mujawar@arm.com>, PierreGondois
	<pierre.gondois@arm.com>, Alexei Fedorov <Alexei.Fedorov@arm.com>, "Leif
 Lindholm" <quic_llindhol@quicinc.com>, nd <nd@arm.com>
References: <20220113164052.20841-1-quic_rcran@quicinc.com>
 <20220113164052.20841-4-quic_rcran@quicinc.com>
 <3a153d35-2509-ad08-3651-f96b411c053e@arm.com>
From: "Rebecca Cran" <quic_rcran@quicinc.com>
In-Reply-To: <3a153d35-2509-ad08-3651-f96b411c053e@arm.com>
Return-Path: quic_rcran@quicinc.com
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
 nasanex01b.na.qualcomm.com (10.46.141.250)
Content-Language: en-US
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

On 2/2/22 07:53, Sami Mujawar wrote:
>> +  Status = AmlCodeGenInteger (Integer, &IntNode);
>> +  ASSERT_EFI_ERROR (Status);
> [SAMI] In release builds, ASSERT_EFI_ERROR() would vanish and we could
> end up accessing an invalid pointer.
> If you agree, I will change this to check the status and return the
> error code, before merging.
> [/SAMI]

Yes, please do.


Thanks.

Rebecca Cran