public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Jeremy Linton <jeremy.linton@arm.com>, devel@edk2.groups.io
Cc: leif@nuviainc.com, pete@akeo.ie, awarkentin@vmware.com
Subject: Re: [PATCH] Platform/RaspberryPi4: Correct thermal offset
Date: Thu, 22 Oct 2020 15:45:43 +0200	[thread overview]
Message-ID: <e3f426ff-d054-354c-ef8a-6dba1eb75420@arm.com> (raw)
In-Reply-To: <20200909231100.213015-1-jeremy.linton@arm.com>

On 9/10/20 1:11 AM, Jeremy Linton wrote:
> The current mainline DT indicates that the thermal offset
> on the rpi is 410040 rather than the 419949 being used.
> This means our temp calculation is offset nearly 10C higher
> when running in ACPI mode vs DT.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>   Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
> index 2b9e8211cf..d116f965e1 100644
> --- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
> @@ -269,7 +269,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI", 2)
>             Field (TEMS, DWordAcc, NoLock, Preserve) {
>               TMPS, 32
>             }
> -          return (((419949 - ((TMPS & 0x3ff) * 487)) / 100) + 2732);
> +          return (((410040 - ((TMPS & 0x3ff) * 487)) / 100) + 2732);
>           }
>           Method (_SCP, 3) { }               // receive cooling policy from OS
>   
> 

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as dc6a619f933f..78c884bbe7d3

      parent reply	other threads:[~2020-10-22 13:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 23:11 [PATCH] Platform/RaspberryPi4: Correct thermal offset Jeremy Linton
2020-09-11 18:13 ` Pete Batard
2020-09-11 19:48   ` Jeremy Linton
2020-10-22 13:45 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3f426ff-d054-354c-ef8a-6dba1eb75420@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox