Re: [edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms

["PierreGondois" <pierre.gondois@arm.com>]

Hello Prabin,

On 1/12/24 16:47, Prabin CA via groups.io wrote:
> Introducing a flag called PCIE_ENABLE, which can be set to TRUE or
> FALSE from the respective <platform>.dsc files to enable or disable the
> PCIe support. As not all reference design platforms have PCIe support
> enabled, this flag is introduced.
> 
> Signed-off-by: Prabin CA <prabin.ca@arm.com>
> ---
>   Platform/ARM/SgiPkg/SgiPlatform.dec                      |  1 +
>   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                  |  6 ++++++
>   Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc                |  4 +++-
>   Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc                |  4 +++-
>   Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc            |  4 +++-
>   Platform/ARM/SgiPkg/RdV1/RdV1.dsc                        |  4 +++-
>   Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc                    |  4 +++-
>   Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc                    |  4 +++-
>   Platform/ARM/SgiPkg/SgiPlatform.fdf                      |  4 +++-
>   Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf  |  5 ++++-
>   Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 19 +++++++++++--------
>   11 files changed, 43 insertions(+), 16 deletions(-)
> 
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/SgiPlatform.dec
> index 4087ff6cad2e..af7887e54126 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dec
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dec
> @@ -31,6 +31,7 @@ [Guids.common]
>   [PcdsFeatureFlag.common]
>     gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported|FALSE|BOOLEAN|0x00000001
>     gArmSgiTokenSpaceGuid.PcdVirtioNetSupported|FALSE|BOOLEAN|0x00000010
> +  gArmSgiTokenSpaceGuid.PcdPcieEnable|FALSE|BOOLEAN|0x0000002E
>   
>   [PcdsFixedAtBuild]
>     gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0|UINT64|0x00000002
> diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> index 1cfe07c7e4ed..1bf489ffeb39 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
> @@ -103,6 +103,10 @@ [PcdsFeatureFlag.common]
>     gArmSgiTokenSpaceGuid.PcdVirtioNetSupported|TRUE
>     gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|FALSE
>   
> +!if $(PCIE_ENABLE) == TRUE
> +  gArmSgiTokenSpaceGuid.PcdPcieEnable|TRUE
> +!endif
> +
>   [PcdsFixedAtBuild.common]
>     gArmTokenSpaceGuid.PcdVFPEnabled|1
>     gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
> @@ -330,6 +334,7 @@ [Components.common]
>     # Virtio Network
>     OvmfPkg/VirtioNetDxe/VirtioNet.inf
>   
> +!if $(PCIE_ENABLE) == TRUE
>     #
>     # Required by PCI
>     #
> @@ -343,6 +348,7 @@ [Components.common]
>       <PcdsFixedAtBuild>
>         gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F
>     }
> +!endif
>   
>     #
>     # AHCI Support

Does the following module also require to be only enabed when PCI is available ?
Or is it kept because the module gracefully fails to be loaded by detecting
the absence of PCI ?

MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf

[snip]


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113816): https://edk2.groups.io/g/devel/message/113816
Mute This Topic: https://groups.io/mt/103685115/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-