From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fb.mail.gandi.net (spool8.mail.gandi.net [217.70.178.217]) by nmboxes7-ms7.sd4.0x35.net (Postfix) with ESMTPS id D16D061930 for ; Tue, 16 Jan 2024 05:56:59 +0000 (UTC) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by fb.mail.gandi.net (Postfix) with ESMTPS id 5F88960376 for ; Tue, 16 Jan 2024 05:56:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Gg17CuF1orIhBF58sgB4QP9oRDRQBApLxQguoAczmnI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:From:Subject:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705384618; v=1; b=JNvritYJay+txXCQsif3wX6LnccHwR6R+/nXUSBjgvZl/+SRwiObUI6AGGPom69HbU7iC7aC HvZ/fMQZ/k5pkiWWAqt6TOT7/b7TznDyjKGaHbGe09zsvE+lBNHzuHuC2AENjrUwI5sejQ0sOV2 tjWN2CoYX+zDpiL4z+t+QmZU= X-Received: by 127.0.0.2 with SMTP id jKu7YY7687511xwOqRACRqMD; Mon, 15 Jan 2024 21:56:58 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.76600.1705317017501520403 for ; Mon, 15 Jan 2024 03:10:17 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57268150C; Mon, 15 Jan 2024 03:11:03 -0800 (PST) X-Received: from [10.34.100.129] (e126645.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 19E263F5A1; Mon, 15 Jan 2024 03:10:15 -0800 (PST) Message-ID: Date: Mon, 15 Jan 2024 12:10:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "PierreGondois" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2 3/8] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms To: devel@edk2.groups.io, prabin.ca@arm.com Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <20240112154759.1222138-1-prabin.ca@arm.com> <20240112154759.1222138-4-prabin.ca@arm.com> In-Reply-To: <20240112154759.1222138-4-prabin.ca@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1Rin1z7t6y47d6X1xLI2kOHfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: fb.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JNvritYJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (fb.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Prabin, On 1/12/24 16:47, Prabin CA via groups.io wrote: > Introducing a flag called PCIE_ENABLE, which can be set to TRUE or > FALSE from the respective .dsc files to enable or disable the > PCIe support. As not all reference design platforms have PCIe support > enabled, this flag is introduced. >=20 > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 6 ++++++ > Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc | 4 +++- > Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc | 4 +++- > Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc | 4 +++- > Platform/ARM/SgiPkg/RdV1/RdV1.dsc | 4 +++- > Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc | 4 +++- > Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc | 4 +++- > Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +++- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 5 ++++- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c | 19 +++++++++= ++-------- > 11 files changed, 43 insertions(+), 16 deletions(-) >=20 > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/Sg= iPlatform.dec > index 4087ff6cad2e..af7887e54126 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dec > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dec > @@ -31,6 +31,7 @@ [Guids.common] > [PcdsFeatureFlag.common] > gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported|FALSE|BOOLEAN|0x00000001 > gArmSgiTokenSpaceGuid.PcdVirtioNetSupported|FALSE|BOOLEAN|0x00000010 > + gArmSgiTokenSpaceGuid.PcdPcieEnable|FALSE|BOOLEAN|0x0000002E > =20 > [PcdsFixedAtBuild] > gArmSgiTokenSpaceGuid.PcdDramBlock2Base|0|UINT64|0x00000002 > diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPk= g/SgiPlatform.dsc.inc > index 1cfe07c7e4ed..1bf489ffeb39 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc > @@ -103,6 +103,10 @@ [PcdsFeatureFlag.common] > gArmSgiTokenSpaceGuid.PcdVirtioNetSupported|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache|FALSE > =20 > +!if $(PCIE_ENABLE) =3D=3D TRUE > + gArmSgiTokenSpaceGuid.PcdPcieEnable|TRUE > +!endif > + > [PcdsFixedAtBuild.common] > gArmTokenSpaceGuid.PcdVFPEnabled|1 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > @@ -330,6 +334,7 @@ [Components.common] > # Virtio Network > OvmfPkg/VirtioNetDxe/VirtioNet.inf > =20 > +!if $(PCIE_ENABLE) =3D=3D TRUE > # > # Required by PCI > # > @@ -343,6 +348,7 @@ [Components.common] > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8010004F > } > +!endif > =20 > # > # AHCI Support Does the following module also require to be only enabed when PCI is availa= ble ? Or is it kept because the module gracefully fails to be loaded by detecting the absence of PCI ? MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf [snip] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113816): https://edk2.groups.io/g/devel/message/113816 Mute This Topic: https://groups.io/mt/103685115/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-