From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 15 Jul 2019 18:40:12 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AD55585541; Tue, 16 Jul 2019 01:40:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-33.ams2.redhat.com [10.36.116.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 243BF1001B19; Tue, 16 Jul 2019 01:40:09 +0000 (UTC) Subject: Re: [PATCH 3/6] edksetup.sh: when executing arithmetic commands, $ isn't needed To: Rebecca Cran , devel@edk2.groups.io, bob.c.feng@intel.com, liming.gao@intel.com, leif.lindholm@linaro.org, michael.d.kinney@intel.com, afish@apple.com References: <20190715222516.53254-1-rebecca@bsdio.com> <20190715222516.53254-3-rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 16 Jul 2019 03:40:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190715222516.53254-3-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 16 Jul 2019 01:40:11 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/16/19 00:25, Rebecca Cran wrote: > Signed-off-by: Rebecca Cran > --- > edksetup.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/edksetup.sh b/edksetup.sh > index 752e47e7cb..76c8d7916e 100755 > --- a/edksetup.sh > +++ b/edksetup.sh > @@ -199,7 +199,7 @@ do > break > ;; > esac > - I=$(($I - 1)) > + I=$((I - 1)) > done > > if [ $I -gt 0 ] > Reviewed-by: Laszlo Ersek