From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web12.18091.1599150367188606097
 for <devel@edk2.groups.io>;
 Thu, 03 Sep 2020 09:26:07 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=flz3ne1e;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1599150366;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=iLlmvX8GIBS/MqQ7iF1nCYMyMY8xlKiHYyT4ReQtviw=;
	b=flz3ne1epadCPh1dYm6m6hPBYqp07MyMfCPldibTap5IAOyt9+TBJJn14yvj0+K9we1XJc
	YQwEGOgxHzlagPJK14DXxRFofaRjWtOtdoAAnYK84y7VmhvRezH33hf/LFgJZt9h9nJou4
	6JcTTlZWIRXWqiiRMhAKU+zeCfUi/u4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-444-ez7mVWJ1Poq1OjZNeSkmAA-1; Thu, 03 Sep 2020 12:26:04 -0400
X-MC-Unique: ez7mVWJ1Poq1OjZNeSkmAA-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B461801AEA;
	Thu,  3 Sep 2020 16:26:03 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-168.ams2.redhat.com [10.36.112.168])
	by smtp.corp.redhat.com (Postfix) with ESMTP id F36C65D6C4;
	Thu,  3 Sep 2020 16:26:01 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Add check for CR3/GDT/IDT.
To: "Dong, Eric" <eric.dong@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
References: <20200902004353.1515-1-eric.dong@intel.com>
 <75a0a10e-f303-304e-0a36-628a79116284@redhat.com>
 <CY4PR11MB1272066CDB596A3F468189ABFE2C0@CY4PR11MB1272.namprd11.prod.outlook.com>
 <7d864273-b2f0-9899-5661-e70202b92941@redhat.com>
 <CY4PR11MB1272DEC49EAAFD881B7BCB8DFE2C0@CY4PR11MB1272.namprd11.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <e41afe17-fd89-d384-3ec3-9a21e8a99d08@redhat.com>
Date: Thu, 3 Sep 2020 18:26:01 +0200
MIME-Version: 1.0
In-Reply-To: <CY4PR11MB1272DEC49EAAFD881B7BCB8DFE2C0@CY4PR11MB1272.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0.002
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US

On 09/03/20 17:21, Dong, Eric wrote:

> - modify the following functions in MpInitLib:
> 
>   - MpInitLibStartupAllAPs
>   - MpInitLibStartupThisAP
>   - MpInitLibSwitchBSP
>   - MpInitLibEnableDisableAP
> [Eric] I found above 4 API need to wake up AP to do the task, so I add code to check the CR3/GDT/IDT.
> Below 3 API does not need to wake up AP, so I don’t add the check.
> 
>   - MpInitLibGetNumberOfProcessors
>   - MpInitLibGetProcessorInfo
>   - MpInitLibWhoAmI

That's even better, thanks!
Laszlo