From: "Laszlo Ersek" <lersek@redhat.com>
To: Liming Gao <liming.gao@intel.com>, devel@edk2.groups.io
Subject: Re: [Patch 4/5] OvmfPkg DSC: Update tool chain name to CLANGPDB
Date: Thu, 14 Nov 2019 10:39:51 +0100 [thread overview]
Message-ID: <e452cb45-e061-86c6-aea4-6751a3c161eb@redhat.com> (raw)
In-Reply-To: <1573719880-6820-5-git-send-email-liming.gao@intel.com>
On 11/14/19 09:24, Liming Gao wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341
>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/OvmfPkgIa32.dsc | 6 +++---
> OvmfPkg/OvmfPkgIa32X64.dsc | 6 +++---
> OvmfPkg/OvmfPkgX64.dsc | 6 +++---
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index d350b75630..9a60eb8fe2 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -67,7 +67,7 @@
> GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
> MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
> -!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(TOOL_CHAIN_TAG) != "CLANG9"
> +!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(TOOL_CHAIN_TAG) != "CLANGPDB"
> GCC:*_*_*_CC_FLAGS = -mno-mmx -mno-sse
> !endif
>
> @@ -81,14 +81,14 @@
> [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> XCODE:*_*_*_DLINK_FLAGS =
> - CLANGPE: *_*_*_DLINK_FLAGS = /ALIGN:4096
> + CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096
>
> # Force PE/COFF sections to be aligned at 4KB boundaries to support page level
> # protection of DXE_SMM_DRIVER/SMM_CORE modules
> [BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE]
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> XCODE:*_*_*_DLINK_FLAGS =
> - CLANGPE: *_*_*_DLINK_FLAGS = /ALIGN:4096
> + CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096
>
> ################################################################################
> #
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 1ef82cafe4..1d1480b50b 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -67,7 +67,7 @@
> GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
> MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
> -!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(TOOL_CHAIN_TAG) != "CLANG9"
> +!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(TOOL_CHAIN_TAG) != "CLANGPDB"
> GCC:*_*_*_CC_FLAGS = -mno-mmx -mno-sse
> !endif
> !if $(SOURCE_DEBUG_ENABLE) == TRUE
> @@ -86,14 +86,14 @@
> [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> XCODE:*_*_*_DLINK_FLAGS =
> - CLANGPE: *_*_*_DLINK_FLAGS = /ALIGN:4096
> + CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096
>
> # Force PE/COFF sections to be aligned at 4KB boundaries to support page level
> # protection of DXE_SMM_DRIVER/SMM_CORE modules
> [BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE]
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> XCODE:*_*_*_DLINK_FLAGS =
> - CLANGPE: *_*_*_DLINK_FLAGS = /ALIGN:4096
> + CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096
>
> ################################################################################
> #
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index 232815c08e..c287a436f8 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -67,7 +67,7 @@
> GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
> INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
> MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG
> -!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(TOOL_CHAIN_TAG) != "CLANG9"
> +!if $(TOOL_CHAIN_TAG) != "XCODE5" && $(TOOL_CHAIN_TAG) != "CLANGPDB"
> GCC:*_*_*_CC_FLAGS = -mno-mmx -mno-sse
> !endif
> !if $(SOURCE_DEBUG_ENABLE) == TRUE
> @@ -86,14 +86,14 @@
> [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> XCODE:*_*_*_DLINK_FLAGS =
> - CLANGPE: *_*_*_DLINK_FLAGS = /ALIGN:4096
> + CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096
>
> # Force PE/COFF sections to be aligned at 4KB boundaries to support page level
> # protection of DXE_SMM_DRIVER/SMM_CORE modules
> [BuildOptions.common.EDKII.DXE_SMM_DRIVER, BuildOptions.common.EDKII.SMM_CORE]
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> XCODE:*_*_*_DLINK_FLAGS =
> - CLANGPE: *_*_*_DLINK_FLAGS = /ALIGN:4096
> + CLANGPDB:*_*_*_DLINK_FLAGS = /ALIGN:4096
>
> ################################################################################
> #
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2019-11-14 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 8:24 [Patch 0/5] Rename tool chain name CLANG9 to CLANGPDB Liming Gao
2019-11-14 8:24 ` [Patch 1/5] BaseTools: Rename tool chain " Liming Gao
2019-11-15 1:25 ` Bob Feng
2019-11-14 8:24 ` [Patch 2/5] MdeModulePkg RegularExpressionDxe: Update tool chain name " Liming Gao
2019-11-14 16:09 ` Wang, Jian J
2019-11-14 8:24 ` [Patch 3/5] CryptoPkg CryptoLib: " Liming Gao
2019-11-14 8:57 ` [edk2-devel] " Wang, Jian J
2019-11-14 8:24 ` [Patch 4/5] OvmfPkg DSC: " Liming Gao
2019-11-14 9:39 ` Laszlo Ersek [this message]
2019-11-14 8:24 ` [Patch 5/5] EmulatorPkg DSC and WinHost.inf: " Liming Gao
2019-11-14 8:44 ` Ni, Ray
2019-11-14 14:44 ` [edk2-devel] [Patch 0/5] Rename tool chain name CLANG9 " Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e452cb45-e061-86c6-aea4-6751a3c161eb@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox