Re: [edk2-devel] [PATCH v8 02/10] OvmfPkg/CpuHotplugSmm: collect hot-unplug events

["Laszlo Ersek" <lersek@redhat.com>]

On 02/22/21 23:03, Ankur Arora wrote:
> On 2021-02-22 4:27 a.m., Laszlo Ersek wrote:
>> On 02/22/21 08:19, Ankur Arora wrote:

>>> diff --git a/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c
>>> b/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c
>>> index 8d4a6693c8d6..36372a5e6193 100644
>>> --- a/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c
>>> +++ b/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c
>>> @@ -164,6 +164,9 @@ QemuCpuhpWriteCommand (
>>>     @param[out] ToUnplugApicIds  The APIC IDs of the CPUs that are
>>> about to be
>>>                                  hot-unplugged.
>>>   +  @param[out] ToUnplugSelector The QEMU Selectors of the CPUs that
>>> are about to
>>> +                               be hot-unplugged.
>>> +
>>>     @param[out] ToUnplugCount    The number of filled-in APIC IDs in
>>>                                  ToUnplugApicIds.
>>>   
>>
> Acking the comments above.
> 
>> (7) Please (a) call the parameter "ToUnplugSelectors" (plural), and (b)
>> make sure that there are two space characters between the variable name
>> "column" and the documentation "column". (All in all, please move the
>> RHS column to the right by two spaces.)
> 
> That would make the RHS of ToUnplugSelectors not line up with the other
> two out params. (Even though this mail does not seem to show that, they
> do line up in the code.) Is that okay?

Sorry, I was unclear. I meant the request as follows: please move the
full-height RHS column, containing *all* the parameter descriptions, to
the right, by 2 spaces; please also re-wrap wherever necessary, to
maintain <= 80 chars width.

Thanks
Laszlo